Skip to content

Add Chronos display name constant to fix search showing Chat Report #84391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
MelvinBot wants to merge 9 commits into
base: main
Choose a base branch
from
+10 −0
Draft

Add Chronos display name constant to fix search showing Chat Report #84391

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4064938
Update option display names when derived reportAttributes change
MelvinBot Mar 6, 2026
b17d361
Replace reportAttributes effect with Chronos display name constant
MelvinBot Mar 9, 2026
43ee364
Fix: Sort imports to match Prettier configuration
MelvinBot Mar 9, 2026
b1ac72f
Fix Chronos display name overriding Concierge in report name resolution
MelvinBot Mar 9, 2026
db2c0f5
Merge remote-tracking branch 'origin/main' into claude-fixChronosDisp…
MelvinBot Mar 19, 2026
2bb44a7
Re-apply Chronos display name changes after merge with main
MelvinBot Mar 19, 2026
86b6728
Remove stale old-version sentry patch files
MelvinBot Mar 19, 2026
abf32aa
Remove stale files from old branch base that no longer exist on main
MelvinBot Mar 19, 2026
4c25d82
Add Chronos display name override in PersonalDetailsUtils
MelvinBot Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/CONST/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2452,6 +2452,7 @@ const CONST = {
},

CONCIERGE_DISPLAY_NAME: 'Concierge',
CHRONOS_DISPLAY_NAME: 'Chronos',
CONCIERGE_GREETING_ACTION_ID: 'concierge-side-panel-greeting',

INTEGRATION_ENTITY_MAP_TYPES: {
Expand Down
4 changes: 4 additions & 0 deletions src/libs/PersonalDetailsUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
let personalDetails: Array<PersonalDetails | null> = [];
let allPersonalDetails: OnyxEntry<PersonalDetailsList> = {};
let emailToPersonalDetailsCache: Record<string, PersonalDetails> = {};
Onyx.connect({

Check warning on line 26 in src/libs/PersonalDetailsUtils.ts

View workflow job for this annotation

GitHub Actions / Changed files ESLint check 

Onyx.connect() is deprecated. Use useOnyx() hook instead and pass the data as parameters to a pure function
key: ONYXKEYS.PERSONAL_DETAILS_LIST,
callback: (val) => {
personalDetails = Object.values(val ?? {});
Expand All @@ -40,7 +40,7 @@
let hiddenTranslation = '';
let youTranslation = '';

Onyx.connect({

Check warning on line 43 in src/libs/PersonalDetailsUtils.ts

View workflow job for this annotation

GitHub Actions / Changed files ESLint check 

Onyx.connect() is deprecated. Use useOnyx() hook instead and pass the data as parameters to a pure function
key: ONYXKEYS.ARE_TRANSLATIONS_LOADING,
callback: (value) => {
if (value ?? true) {
Expand Down Expand Up @@ -89,6 +89,10 @@
displayName = CONST.CONCIERGE_DISPLAY_NAME;
}

if (passedPersonalDetails?.accountID === CONST.ACCOUNT_ID.CHRONOS) {
displayName = CONST.CHRONOS_DISPLAY_NAME;
}

if (displayName) {
return displayName;
}
Expand Down
3 changes: 3 additions & 0 deletions src/libs/ReportNameUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,7 @@ import {
} from './ReportActionsUtils';
// eslint-disable-next-line import/no-cycle
import {
chatIncludesChronos,
formatReportLastMessageText,
getDisplayNameForParticipant,
getMoneyRequestSpendBreakdown,
Expand Down Expand Up @@ -915,6 +916,8 @@ function computeReportName({

if (isConciergeChatReport(report)) {
formattedName = CONST.CONCIERGE_DISPLAY_NAME;
} else if (chatIncludesChronos(report)) {
formattedName = CONST.CHRONOS_DISPLAY_NAME;
}

const isArchivedNonExpense = isArchivedNonExpenseReport(report, !!privateIsArchivedValue);
Expand Down
2 changes: 2 additions & 0 deletions src/libs/ReportUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1051,7 +1051,7 @@
};

let conciergeReportIDOnyxConnect: OnyxEntry<string>;
Onyx.connect({

Check warning on line 1054 in src/libs/ReportUtils.ts

View workflow job for this annotation

GitHub Actions / Changed files ESLint check 

Onyx.connect() is deprecated. Use useOnyx() hook instead and pass the data as parameters to a pure function
key: ONYXKEYS.CONCIERGE_REPORT_ID,
callback: (value) => {
conciergeReportIDOnyxConnect = value;
Expand All @@ -1059,7 +1059,7 @@
});

const defaultAvatarBuildingIconTestID = 'SvgDefaultAvatarBuilding Icon';
Onyx.connect({

Check warning on line 1062 in src/libs/ReportUtils.ts

View workflow job for this annotation

GitHub Actions / Changed files ESLint check 

Onyx.connect() is deprecated. Use useOnyx() hook instead and pass the data as parameters to a pure function
key: ONYXKEYS.SESSION,
callback: (value) => {
// When signed out, val is undefined
Expand All @@ -1077,7 +1077,7 @@
let allPersonalDetails: OnyxEntry<PersonalDetailsList>;
let allPersonalDetailLogins: string[];
let currentUserPersonalDetails: OnyxEntry<PersonalDetails>;
Onyx.connect({

Check warning on line 1080 in src/libs/ReportUtils.ts

View workflow job for this annotation

GitHub Actions / Changed files ESLint check 

Onyx.connect() is deprecated. Use useOnyx() hook instead and pass the data as parameters to a pure function
key: ONYXKEYS.PERSONAL_DETAILS_LIST,
callback: (value) => {
if (currentUserAccountID) {
Expand All @@ -1089,7 +1089,7 @@
});

let allReportsDraft: OnyxCollection<Report>;
Onyx.connect({

Check warning on line 1092 in src/libs/ReportUtils.ts

View workflow job for this annotation

GitHub Actions / Changed files ESLint check 

Onyx.connect() is deprecated. Use useOnyx() hook instead and pass the data as parameters to a pure function
key: ONYXKEYS.COLLECTION.REPORT_DRAFT,
waitForCollectionCallback: true,
callback: (value) => (allReportsDraft = value),
Expand All @@ -1097,7 +1097,7 @@

let allPolicies: OnyxCollection<Policy>;
let policiesArray: Policy[] = [];
Onyx.connect({

Check warning on line 1100 in src/libs/ReportUtils.ts

View workflow job for this annotation

GitHub Actions / Changed files ESLint check 

Onyx.connect() is deprecated. Use useOnyx() hook instead and pass the data as parameters to a pure function
key: ONYXKEYS.COLLECTION.POLICY,
waitForCollectionCallback: true,
callback: (value) => {
Expand All @@ -1107,7 +1107,7 @@
});

let allPolicyDrafts: OnyxCollection<Policy>;
Onyx.connect({

Check warning on line 1110 in src/libs/ReportUtils.ts

View workflow job for this annotation

GitHub Actions / Changed files ESLint check 

Onyx.connect() is deprecated. Use useOnyx() hook instead and pass the data as parameters to a pure function
key: ONYXKEYS.COLLECTION.POLICY_DRAFTS,
waitForCollectionCallback: true,
callback: (value) => (allPolicyDrafts = value),
Expand All @@ -1115,7 +1115,7 @@

let allReports: OnyxCollection<Report>;
let reportsByPolicyID: ReportByPolicyMap;
Onyx.connect({

Check warning on line 1118 in src/libs/ReportUtils.ts

View workflow job for this annotation

GitHub Actions / Changed files ESLint check 

Onyx.connect() is deprecated. Use useOnyx() hook instead and pass the data as parameters to a pure function
key: ONYXKEYS.COLLECTION.REPORT,
waitForCollectionCallback: true,
callback: (value) => {
Expand Down Expand Up @@ -1151,7 +1151,7 @@
});

let betaConfiguration: OnyxEntry<BetaConfiguration> = {};
Onyx.connect({

Check warning on line 1154 in src/libs/ReportUtils.ts

View workflow job for this annotation

GitHub Actions / Changed files ESLint check 

Onyx.connect() is deprecated. Use useOnyx() hook instead and pass the data as parameters to a pure function
key: ONYXKEYS.BETA_CONFIGURATION,
callback: (value) => (betaConfiguration = value ?? {}),
});
Expand Down Expand Up @@ -5987,6 +5987,8 @@

if (isConciergeChatReport(report, conciergeReportID)) {
formattedName = CONST.CONCIERGE_DISPLAY_NAME;
} else if (chatIncludesChronos(report)) {
formattedName = CONST.CHRONOS_DISPLAY_NAME;
}

if (formattedName) {
Expand Down
Loading