Add caching for images with authentication on web by VickyStash · Pull Request #84409 · Expensify/App

VickyStash · 2026-03-06T13:55:44Z

Explanation of Change

Adds a useCachedImageSource hook that uses the browser Cache API to persistently cache images fetched with auth headers on web.
When a source has headers, the hook fetches the image, stores the response in a named cache (auth-images), and returns a blob URL without headers - bypassing expo-image's default fetch-per-render behavior. On subsequent mounts, the cached response is served instantly. Images without headers are passed through unchanged, as the browser's native HTTP cache already handles them.

Fixed Issues

$ #83112
PROPOSAL: N/A

Tests

Verify that no errors appear in the JS console

Open the app
Open the chat with expenses with receipts images
Make sure they are loaded
Go back to inbox/any other page
Turn off the internet connection (for real, not simulation)
Return to the chat from step 2. See the receipts images that were loaded previously are displayed.
Open the browser DevTools -> Application -> Cache storage -> auth-images. See, there is a list of cached images. Log out, see the list is cleared out.

Offline tests

Same, as Test steps

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

Same, as Test steps

PR Author Checklist

Screenshots/Videos

Android: mWeb Chrome

android_web.mp4

iOS: mWeb Safari

ios_web.mov

MacOS: Chrome / Safari

pr.mp4

web2.mp4

codecov · 2026-03-06T14:03:53Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/CONST/index.ts	`93.54% <ø> (ø)`
src/components/Image/BaseImage.tsx	`0.00% <0.00%> (ø)`
src/hooks/useCachedImageSource.ts	`92.59% <92.59%> (ø)`
src/libs/actions/Session/clearCache/index.ts	`0.00% <0.00%> (ø)`
... and 88 files with indirect coverage changes

github-actions · 2026-03-06T23:55:05Z

🚧 @Julesssss has triggered a test Expensify/App build. You can view the workflow run here.

m-natarajan · 2026-03-07T10:34:57Z

Not repro, Windows 11 / Chrome, v9.3.31-4 PR:84409

07.03.2026_16.38.23_REC.mp4

VickyStash · 2026-03-11T10:47:53Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ee2b8aea71

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/hooks/useCachedImageSource.ts

melvin-bot · 2026-03-11T13:18:43Z

@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ee2b8aea71

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/hooks/useCachedImageSource.ts

joekaufmanexpensify · 2026-03-11T19:08:51Z

No product review needed

Julesssss · 2026-03-11T22:53:11Z

Ready for C+ review, @abdulrahuman5196

Julesssss · 2026-03-12T18:20:22Z

Ready for C+ review, @abdulrahuman5196

Switching to @ShridharGoel

ShridharGoel · 2026-03-12T20:10:22Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

Screen.Recording.2026-03-13.at.2.57.14.AM.mov

iOS: HybridApp

iOS: mWeb Safari

Screen.Recording.2026-03-13.at.2.50.26.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2026-03-13.at.2.32.54.AM.mov

Screen.Recording.2026-03-13.at.2.29.55.AM.mov

src/hooks/useCachedImageSource.ts

ShridharGoel

Just one comment

Also, is it feasible to add tests for this?

ShridharGoel · 2026-03-12T21:22:08Z

There's a quick flicker when switching between images.

Screen.Recording.2026-03-13.at.2.50.26.AM.mov

VickyStash · 2026-03-13T14:33:20Z

@ShridharGoel I've imroved the error check (d091a81) and added tests (4a54622).

As for the flickering, I've investigated it and overall the flickering happens cause we have additional preview for the transaction thread, I need to think how to handle it to not break anything.

ShridharGoel · 2026-03-13T14:55:09Z

So should we handle the flickering here only or as a different task?

Julesssss · 2026-03-13T16:41:11Z

So should we handle the flickering here only or as a different task?

As for the flickering, I've investigated it and overall the flickering happens cause we have additional preview for the transaction thread, I need to think how to handle it to not break anything.

I'm happy to push that to a follow up task, but lets leave that choice to @VickyStash

github-actions · 2026-03-13T16:41:12Z

🚧 @Julesssss has triggered a test Expensify/App build. You can view the workflow run here.

VickyStash · 2026-03-13T16:44:42Z

I'm okay with handling it in a follow-up too!

github-actions · 2026-03-13T16:46:06Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #84409.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-4a54622-59ef620-3cc896fc4855ef5ba40036734a4bc5345cddb27f/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-4a54622-59ef620-fc9867cb543d5054331d0806038591fe7b07c26c/index.html

Web 🕸️
https://84409.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-03-13T18:16:29Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-03-13T19:20:26Z

🚧 @Julesssss has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-03-13T19:25:04Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #84409.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-96f84af-2ebebc3-4e2936ca25e694ccc24a61569fd90136e96a6d56/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-96f84af-2ebebc3-bd254ac439d9fbcd7b1118ccc3e02909f3818951/index.html

Web 🕸️
https://84409.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-03-16T10:31:31Z

🚀 Deployed to staging by https://github.com/Julesssss in version: 9.3.38-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

IuliiaHerets · 2026-03-16T17:10:51Z

Hi @VickyStash. QA team failed this PR on iOS with an original issue

1773662850776.84409-iOS.mp4

VickyStash · 2026-03-16T17:21:28Z

Hi @VickyStash. QA team failed this PR on iOS with an #83112

This PR updated web only. The native cache was added in this PR, and was deployed to prod a couple of weeks ago. I've just check ios prod app and there cache worked for me.
@IuliiaHerets Does the issue happen to you on staging only or on prod too?

IuliiaHerets · 2026-03-16T17:52:46Z

@VickyStash not repro on prod
In this case, I believe, we need to create a new issue, right?

84409-iOS-Prod.mp4

OSBotify · 2026-03-17T11:27:37Z

🚀 Deployed to production by https://github.com/cristipaval in version: 9.3.38-4 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

VickyStash · 2026-03-17T13:20:47Z

@VickyStash not repro on prod
In this case, I believe, we need to create a new issue, right?

I can't reproduce it on main (dev) either. @IuliiaHerets Have you followed any special steps?

IuliiaHerets · 2026-03-17T15:09:25Z

@VickyStash not repro now, seems it was a temporary issue

ScreenRecording_03-16-2026.19-22-35_1.MP4

Add caching for images with authentication on web

d51a022

melvin-bot bot assigned VickyStash Mar 6, 2026

VickyStash mentioned this pull request Mar 6, 2026

Fix web image caching authentication issues with expo-image #83112

Open

Julesssss self-requested a review March 6, 2026 22:42

This comment has been minimized.

Sign in to view

Julesssss mentioned this pull request Mar 7, 2026

[Image][$1000] Improve NewDot image uploading experience, add large file support #9402

Open

VickyStash added 3 commits March 11, 2026 10:39

Clear auth-images cache on logout

8ed16c5

Merge branch 'main' into VickyStash/feature/83112-cache-auth-images

903dce5

Clear auth-images cache if quota exceeded

ee2b8ae

chatgpt-codex-connector bot reviewed Mar 11, 2026

View reviewed changes

src/hooks/useCachedImageSource.ts Show resolved Hide resolved

VickyStash marked this pull request as ready for review March 11, 2026 13:18

VickyStash requested review from a team as code owners March 11, 2026 13:18

melvin-bot bot requested review from abdulrahuman5196 and removed request for a team March 11, 2026 13:18

melvin-bot bot requested review from joekaufmanexpensify and removed request for a team March 11, 2026 13:18

chatgpt-codex-connector bot reviewed Mar 11, 2026

View reviewed changes

src/hooks/useCachedImageSource.ts Show resolved Hide resolved

joekaufmanexpensify removed their request for review March 11, 2026 19:08

Julesssss mentioned this pull request Mar 11, 2026

Improve image uploading experience 2/2 #84964

Open

Julesssss requested review from ShridharGoel and removed request for abdulrahuman5196 March 12, 2026 18:19

ShridharGoel reviewed Mar 12, 2026

View reviewed changes

src/hooks/useCachedImageSource.ts Outdated Show resolved Hide resolved

ShridharGoel approved these changes Mar 12, 2026

View reviewed changes

VickyStash added 3 commits March 13, 2026 11:04

Merge branch 'main' into VickyStash/feature/83112-cache-auth-images

7412b7c

Improve the error check

d091a81

Add useCachedImageSource jest tests

4a54622

Julesssss approved these changes Mar 13, 2026

View reviewed changes

Julesssss merged commit 96f84af into Expensify:main Mar 13, 2026
31 checks passed

OSBotify mentioned this pull request Mar 16, 2026

Deploy Checklist: New Expensify 2026-03-16 #85347

Closed

74 tasks

Conversation

VickyStash commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Mar 6, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Mar 6, 2026

Uh oh!

This comment has been minimized.

m-natarajan commented Mar 7, 2026

Uh oh!

VickyStash commented Mar 11, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

melvin-bot bot commented Mar 11, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

joekaufmanexpensify commented Mar 11, 2026

Uh oh!

Julesssss commented Mar 11, 2026

Uh oh!

Julesssss commented Mar 12, 2026

Uh oh!

ShridharGoel commented Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

ShridharGoel left a comment

Choose a reason for hiding this comment

Uh oh!

ShridharGoel commented Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

VickyStash commented Mar 13, 2026

Uh oh!

ShridharGoel commented Mar 13, 2026

Uh oh!

Julesssss commented Mar 13, 2026

Uh oh!

github-actions bot commented Mar 13, 2026

Uh oh!

VickyStash commented Mar 13, 2026

Uh oh!

github-actions bot commented Mar 13, 2026

Uh oh!

Uh oh!

OSBotify commented Mar 13, 2026

Uh oh!

github-actions bot commented Mar 13, 2026

Uh oh!

github-actions bot commented Mar 13, 2026

Uh oh!

OSBotify commented Mar 16, 2026

Uh oh!

IuliiaHerets commented Mar 16, 2026

Uh oh!

VickyStash commented Mar 16, 2026

Uh oh!

IuliiaHerets commented Mar 16, 2026

Uh oh!

OSBotify commented Mar 17, 2026

VickyStash commented Mar 6, 2026 •

edited

Loading

codecov bot commented Mar 6, 2026 •

edited by github-actions bot

Loading

ShridharGoel commented Mar 12, 2026 •

edited

Loading

ShridharGoel commented Mar 12, 2026 •

edited

Loading