[HOLD on https://github.com/Expensify/App/pull/84423] Multi file upload support (v2)

[chrispader]

@parasharrajat @mountiny

Explanation of Change

This PR is a follow-up after #68551 has been reverted in #83956

Updates the native react-native patch which impements onPaste callback on TextInput, to allow pasting multiple files into the input.

Updates the composer implementation to handle multiple files that were drag'n'dropped. This allows the user to drop multiple files into the composer at once, which will then be displayed in an attachment gallery preview.

Even though there is a limitation on iOS where multiple files in the clipboard are not passed to the input onPasteFile callback, i still adapted the implementation to allow for potentially more clipboard items.

react-native-live-markdown PR: Expensify/react-native-live-markdown#753

react-native-live-markdown version bump PR: #83041

Fixed Issues

$ #53493
$ #59443
PROPOSAL:

Tests

• Verify that no errors appear in the JS console

Drag'n'Drop

1. Open the app and go to a report
2. Drag'n'drop multiple attachments into the dual drop zone.
3. Make sure that all attachments are displayed in the "Send attachments" model/screen and that they are displayed in the carousel.
4. Test different file types and make sure validation and are correct.

Paste from clipboard

1. Open the app and go to a report
2. Copy multiple files/images into the clipboard
3. Paste the files into the composer
4. Make sure that all attachments are displayed in the "Send attachments" model/screen and that they are displayed in the carousel.
5. Test different file types and make sure validation and are correct.

Offline tests

None needed.

QA Steps

• Verify that no errors appear in the JS console

Same as in Tests.

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

XRecorder_20260218_02.mp4

iOS: Native

Simulator.Screen.Recording.-.iPhone.17.Pro.-.2026-02-18.at.20.27.14.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-02-18.at.13.26.19.mov

Screen.Recording.2026-02-18.at.13.25.47.mov

MacOS: Desktop

[github-actions]

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

[chrispader]

@mountiny could you please trigger some ad-hoc builds on this PR? This is the follow-up for #68551 after it has been reverted in #83956.

Android builds should be fixed now, both locally and in CI.

[melvin-bot]

@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[codecov]

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
...report/ReportActionCompose/ReportActionCompose.tsx	64.68% <15.78%> (-3.83%)	⬇️
...omponents/Composer/implementation/index.native.tsx	48.21% <0.00%> (-9.24%)	⬇️
src/components/Composer/implementation/index.tsx	0.00% <0.00%> (ø)
... and 122 files with indirect coverage changes

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: eb4eba1573

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[github-actions]

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

[mountiny]

Kicked off a build and this action too https://github.com/Expensify/App/actions/runs/22778476616

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #84423.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-82a8436-ff7dc59-0e16265ff110f7cbf682988870920166e395d8e4/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-82a8436-ff7dc59-abaa609c98f696e3a4ae0ec08e88775c00064680/index.html

Web 🕸️
https://84423.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[joekaufmanexpensify]

Good for product

[parasharrajat]

Screenshots

🔲 iOS / native

🔲 iOS / Safari

🔲 MacOS / Chrome

🔲 Android / Chrome

🔲 Android / native

[parasharrajat]

On Android, when I select multiple attachments, the app only show preview for 2.

07.03.2026_18.53.07_REC.mp4

[parasharrajat]

BUG: Android: First time trying to add an attachment does not do anything.

08.03.2026_14.26.07_REC.mp4

[chrispader]

BUG: Android: First time trying to add an attachment does not do anything.

For me, sometimes the first attachment upload does not work, and then another time subsequent uploads do not work.

@parasharrajat i can reproduce some issues with uploading attachments on main and in prod that are going to be fixed in #70740. Let's try to get this PR merged first and then let's address the issues you mentioned up here. Could you please finish your review there? 🙌🏼

Screen.Recording.2026-03-09.at.12.08.36.mov

On Android, when I select multiple attachments, the app only show preview for 2.

I cannot reliably reproduce this issue at the moment, but it might also be fixed by the other PR.

[parasharrajat]

Sure. Make sense.

[parasharrajat]

Let me complete this review here first. Then I will move to that PR. I am intentionally waiting on this PR before I finalize this #70740.

[chrispader]

Let me complete this review here first. Then I will move to that PR. I am intentionally waiting on this PR before I finalize this #70740.

@parasharrajat we'll need to merge the other way around. Some of the issues you reported in this PR are reproducible on main and will be fixed by #84423. Therefore i think we should hold this PR.

[parasharrajat]

OK, I will get on other PR then. You tagged the same PR for hold status.

[chrispader]

OK, I will get on other PR then.

perfect thanks!

You tagged the same PR for hold status.

Ahh thank you