chore: [Performance] Optimize useAdvancedSearchFilters (~18ms per render) by TaduJR · Pull Request #84505 · Expensify/App

TaduJR · 2026-03-08T06:31:04Z

Explanation of Change

The useAdvancedSearchFilters hook was running 7 separate Object.values(policies) iterations inline per render without selector caching

Structural optimizations (Onyx selectors prevent re-renders):

policyDerivedSelector: Replaces isFeatureEnabledInPolicies (4 calls), the report field check, the non-personal policy filter, and the tax rate existence check with a single pass over policies with early-exit
flags. Returns only primitives so Onyx's deepEqual comparison is trivially cheap, preventing re-renders when policy data changes but derived values don't.
taxRatesSelector: Caches getAllTaxRates() result via Onyx's deepEqual, avoiding inline recomputation every render.
hasTagsSelector: Returns a boolean with early exit on first tag found, replacing the .filter().map(getTagNamesFromTagsLists).flat() chain.
availablePolicyCategoriesSelector: Uses .some() instead of .filter().length > 0 for category existence checks.
filterCardsHiddenFromSearch: Moved from inline call to Onyx selector parameter, enabling deepEqual caching at the subscription level.

Consumer deduplication:

AdvancedSearchFilters.tsx had duplicate POLICY and CARD_LIST Onyx subscriptions (both in the hook and the consumer). Removed duplicates the hook now returns taxRates, searchCards, and policies directly.

Algorithmic improvements:

7 separate policy iterations → 1 single pass with early-exit flags
nonPersonalPolicyCategoryIds array + Set allocation → hasNonPersonalPolicies boolean flag + direct O(1) policy lookup per category key
getAllTaxRates inline every render → hasAnyTaxRates boolean check in single pass + taxRatesSelector cached via deepEqual
.filter().length > 0 → .some() (2 instances)

Performance (Reassure, 50K policies):

Metric	`main` (baseline)	PR (current)	Change
Duration	136.5 ms	36.0 ms	-100.5 ms (-73.6%)

Fixed Issues

$ #82423
PROPOSAL: #82423 (comment)

Tests

Navigate to the Search page and click the Filters button
Verify the filters panel opens showing Expense type filters with "General" and "Expenses" sections
Change the Type filter to Chat verify only chat-relevant filters appear (Type, From, To, In, Keywords, Date, Is, Has)
Change the Type filter to Expense Report verify report-specific filters appear (Title, Total, Report ID, etc.)
Change back to Expense type
Select values for a few filters (e.g., Date, Category, Tag) verify selected values display correctly as filter titles
Click View results verify search results reflect the applied filters
Navigate back to Filters verify previously selected values are preserved
Click Reset filters verify all filters are cleared

Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2026-03-11.at.11.46.04.in.the.morning.mov

Android: mWeb Chrome

iOS: Native

iOS-Native.mp4

iOS: mWeb Safari

iOS-Safari.mp4

MacOS: Chrome / Safari

Mac-Chrome.mp4

…g in policyDerivedSelector

melvin-bot · 2026-03-08T06:31:10Z

@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2026-03-08T06:37:41Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/pages/Search/AdvancedSearchFilters.tsx	`0.00% <0.00%> (ø)`
src/hooks/useAdvancedSearchFilters.ts	`96.42% <95.55%> (+10.71%)`	⬆️
... and 11 files with indirect coverage changes

src/hooks/useAdvancedSearchFilters.ts

luacmartins · 2026-03-09T15:15:58Z

@aimane-chnaif please prioritize reviewing this PR when you're online!

aimane-chnaif · 2026-03-09T15:17:50Z

reviewing today

luacmartins · 2026-03-09T15:45:59Z

@TaduJR conflicts

…rmance-Optimize-useAdvancedSearchFilters-18msper-render # Conflicts: # src/hooks/useAdvancedSearchFilters.ts

joekaufmanexpensify · 2026-03-09T18:42:29Z

No product review needed

luacmartins · 2026-03-09T18:43:40Z

All yours @aimane-chnaif

aimane-chnaif · 2026-03-09T19:31:16Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-03-11.at.5.21.31.pm.mov

aimane-chnaif · 2026-03-09T19:33:17Z

@TaduJR We should have Tests steps to confirm our changes don't introduce any bugs.

chatgpt-codex-connector · 2026-03-09T19:56:42Z

Codex Review: Didn't find any major issues. 👍

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

TaduJR · 2026-03-09T19:59:20Z

@TaduJR We should have Tests steps to confirm our changes don't introduce any bugs.

Ok

aimane-chnaif · 2026-03-10T15:02:44Z

@TaduJR how's test cases going?

TaduJR · 2026-03-10T16:55:43Z

@TaduJR how's test cases going?

Good, @aimane-chnaif

I will finish all by EOD

…rmance-Optimize-useAdvancedSearchFilters-18msper-render

TaduJR · 2026-03-11T08:49:40Z

@TaduJR how's test cases going?

Done @aimane-chnaif

OSBotify · 2026-03-11T17:35:56Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

chatgpt-codex-connector · 2026-03-11T17:47:41Z

Codex Review: Didn't find any major issues. Nice work!

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

github-actions · 2026-03-11T18:07:24Z

🚧 @luacmartins has triggered a test Expensify/App build. You can view the workflow run here.

…mize-useAdvancedSearchFilters-18msper-render chore: [Performance] Optimize useAdvancedSearchFilters (~18ms per render)

github-actions · 2026-03-11T18:15:06Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #84505.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-bc25ff6-47a1081-f435c44e450bd36b0041a0df043d01e3ee044215/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-bc25ff6-47a1081-4ce67aad99cbbbe7b3f252186ee4456a0557656b/index.html

Web 🕸️
https://84505.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-03-11T20:05:41Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.3.36-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-03-12T22:50:23Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.3.36-10 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

TaduJR added 3 commits March 8, 2026 09:11

fix: [Performance] Optimize useAdvancedSearchFilters (~18ms per render)

f4a684e

refactor: replace nonPersonalPolicyCategoryIds array with boolean fla…

4b7b890

…g in policyDerivedSelector

fix: guard against undefined policy in non-personal category check

6153905

TaduJR requested review from a team as code owners March 8, 2026 06:31

melvin-bot bot assigned TaduJR Mar 8, 2026

melvin-bot bot requested review from aimane-chnaif and joekaufmanexpensify and removed request for a team March 8, 2026 06:31

melvin-bot bot removed the request for review from a team March 8, 2026 06:31

github-actions bot reviewed Mar 8, 2026

View reviewed changes

src/hooks/useAdvancedSearchFilters.ts Outdated Show resolved Hide resolved

fix: remove redundant taxRatesSelector Onyx subscription

f39399a

TaduJR added 2 commits March 9, 2026 21:01

Merge branch 'main' of https://github.com/TaduJR/App into chore-Perfo…

9be2080

…rmance-Optimize-useAdvancedSearchFilters-18msper-render # Conflicts: # src/hooks/useAdvancedSearchFilters.ts

fix: use advancedSearchPoliciesSelector for policy subscription

2d5cab7

joekaufmanexpensify removed their request for review March 9, 2026 18:42

Merge branch 'main' of https://github.com/TaduJR/App into chore-Perfo…

73a7ebb

…rmance-Optimize-useAdvancedSearchFilters-18msper-render

TaduJR changed the title ~~[No-QA] chore: [Performance] Optimize useAdvancedSearchFilters (~18ms per render)~~ chore: [Performance] Optimize useAdvancedSearchFilters (~18ms per render) Mar 11, 2026

luacmartins approved these changes Mar 11, 2026

View reviewed changes

aimane-chnaif approved these changes Mar 11, 2026

View reviewed changes

melvin-bot bot requested a review from luacmartins March 11, 2026 17:25

luacmartins approved these changes Mar 11, 2026

View reviewed changes

luacmartins merged commit bc25ff6 into Expensify:main Mar 11, 2026
35 checks passed

OSBotify mentioned this pull request Mar 11, 2026

Deploy Checklist: New Expensify 2026-03-11 #84953

Closed

melvin-bot bot mentioned this pull request Mar 12, 2026

[Due for payment 2026-03-19] [$250] [Performance] Optimize useAdvancedSearchFilters (~18ms per render) #82423

Open

Conversation

TaduJR commented Mar 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Mar 8, 2026

Uh oh!

codecov bot commented Mar 8, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

luacmartins commented Mar 9, 2026

Uh oh!

aimane-chnaif commented Mar 9, 2026

Uh oh!

luacmartins commented Mar 9, 2026

Uh oh!

joekaufmanexpensify commented Mar 9, 2026

Uh oh!

luacmartins commented Mar 9, 2026

Uh oh!

aimane-chnaif commented Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

aimane-chnaif commented Mar 9, 2026

Uh oh!

chatgpt-codex-connector bot commented Mar 9, 2026

Uh oh!

TaduJR commented Mar 9, 2026

Uh oh!

aimane-chnaif commented Mar 10, 2026

Uh oh!

TaduJR commented Mar 10, 2026

Uh oh!

TaduJR commented Mar 11, 2026

Uh oh!

Uh oh!

OSBotify commented Mar 11, 2026

Uh oh!

chatgpt-codex-connector bot commented Mar 11, 2026

Uh oh!

github-actions bot commented Mar 11, 2026

Uh oh!

github-actions bot commented Mar 11, 2026

Uh oh!

OSBotify commented Mar 11, 2026

Uh oh!

OSBotify commented Mar 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

TaduJR commented Mar 8, 2026 •

edited

Loading

codecov bot commented Mar 8, 2026 •

edited by github-actions bot

Loading

aimane-chnaif commented Mar 9, 2026 •

edited

Loading