[WIP] [HOLD on Onyx https://github.com/Expensify/react-native-onyx/pull/749] chore: Bump Onyx to version 3.0.46 to fix memory leaks and other issues in NitroSQLite and Nitro

[chrispader]

@mountiny

Explanation of Change

Bumps react-native-onyx to version 3.0.46 (not yet released) which includes updates to NitroSQLite and Nitro Modules. The latest version of NitroSQLite includes a fix for a memory leak issue in Nitro Modules. There are also other improvements made in NitroSQLite, that are explained in Expensify/react-native-onyx#749. (Details in recent release notes since version 9.2.0)

The memory leak issue on Android has been reported by @mateuuszzzzz in the linked issue. Comments:

• [Due for payment 2025-10-31] [Due for payment 2025-10-27] Audit Memory Leaks #63979 (comment)
• [Due for payment 2025-10-31] [Due for payment 2025-10-27] Audit Memory Leaks #63979 (comment)

Fixed Issues

$ #63979
PROPOSAL:

MOBILE-EXPENSIFY: https://github.com/Expensify/Mobile-Expensify/pull/13882

Tests

• Verify that no errors appear in the JS console

Perform general tests which involve data being set to storage.

Offline tests

None needed.

QA Steps

• Verify that no errors appear in the JS console

1. Open the app
2. Create a new chat
3. Write some messages in the chat
4. Go to Settings -> Preferences
5. Change the theme
6. Update the account name
7. Potentially do other steps that cause data being written to storage

Make sure that there are not errors or warnings reported in the console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

[github-actions]

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

[melvin-bot]

@deetergp Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[github-actions]

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #84517 Mobile-Expensify PR Expensify/Mobile-Expensify#13882.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-434118b-d582487-347bd1564e27e159f9ad3e33bfefa5cf98e2e186/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-434118b-d582487-022063977891691b8e2956531e3b9dc4db4c860d/index.html

Web 🕸️
https://84517.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[mountiny]

Requested a QA https://expensify.slack.com/archives/C09V78U42D8/p1773162657506409

[jponikarchuk]

Notification - No notification is displayed when receiving message in chats

---

Version Number: 84519
Reproducible in staging?: No
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/TR-8393/folder/13176910/41237475/1242721847?sort=%2Bidentifier
Issue reported by: Applause Internal Team
Device used: Android 13, iOS

Action Performed:

1. Sign in to Ad Hoc app with account A
2. With another account (Account B in another device), send a message to Account A

Expected Result:

Chat with account B is marked as unread (bold) and Notification is sent in the device

Actual Result:

Chat is marked as bold but no notification is sent in the device

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Bug7098479_1773111576663.expensifial_account.mp4

[jponikarchuk]

Unread state doesn't display on the app icon

---

Version Number: 9.3.33-1 PR:84517 Ad-Hoc
Reproducible in staging?: No
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/folder/13176925/test-cases/41237603
Issue reported by: Applause Internal Team
Device used: Xiaomi Poco F5 / Android 13

Action Performed:

1. Sign in to Ad Hoc app with account A
2. With another account (Account B in another device), send a message to Account A
3. Check the Unread status on the Expensify app icon

Expected Result:

Unread state should display on the app icon

Actual Result:

Unread state doesn't display on the app icon

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Bug7098479_1773111576663.expensifial_account.mp4

[chrispader]

@jponikarchuk looking at the above two issues, this seems unrelated to the changes made in this PR. Both notifications and app banners/indicators depend on permissions and how the app was installed and set up.

Could you please verify if re-installing the app with proper permissions fixes these issues?

[jponikarchuk]

Both issues are still reproducible when re-installing the app with proper permissions fixes

Screen_Recording_20260311_142810.mp4

[IuliiaHerets]

@mountiny Regression is completed

Logged issues

1. Notification - No notification is displayed when receiving message in chats
2. Unread state doesn't display on the app icon

[heyjennahay]

Product review not required