Skip to content

Fix focus not landing on first item when search query is cleared#84597

Merged
marcochavezf merged 5 commits intomainfrom
claude-fixSearchFocusOnQueryClear
Mar 13, 2026
Merged

Fix focus not landing on first item when search query is cleared#84597
marcochavezf merged 5 commits intomainfrom
claude-fixSearchFocusOnQueryClear

Conversation

@MelvinBot
Copy link
Contributor

@MelvinBot MelvinBot commented Mar 9, 2026

Explanation of Change

When the search query is cleared (user deletes all text in the search box), the query-change useEffect was calling updateAndScrollToFocusedIndex(0, true), which set focusedIndex to 0. But with the query empty, searchQueryItem disappears and sections rebuild with titled sections ("Recent Searches", "Recent Chats"). The useFlattenedSections hook inserts section headers as the first items in the flattened list, and these headers are disabled/non-focusable. So focusedIndex=0 pointed at a disabled header, and no item appeared visually focused.

The fix: when the query transitions to empty, instead of blindly focusing index 0, reset hasSetInitialFocusRef.current = false. This allows the existing initial focus effect (which already has correct header-skipping logic) to re-fire in the same render cycle and set focus on the first actual focusable item.

Fixed Issues

$ #83929
PROPOSAL: #83929 (comment)

Tests

  1. Open the Home page
  2. Open search (click magnifying glass or press Ctrl+K / Cmd+K)
  3. Type a query that returns no results (e.g., "zzzzxyzzzz")
  4. Select all text and delete it
  5. Verify the first item in the list is focused/highlighted (should be the first recent chat, not a section header)
  6. Open search again, type a partial query that returns results (e.g., "con")
  7. Verify focus is on the search query item at index 0
  • Verify that no errors appear in the JS console

Offline tests

N/A — This is a focus management fix that doesn't involve network requests.

QA Steps

  1. Open the Home page
  2. Open search (click magnifying glass or press Ctrl+K / Cmd+K)
  3. Type a query that returns no results (e.g., "zzzzxyzzzz")
  4. Select all text and delete it
  5. Verify the first item in the list is focused/highlighted (should be the first recent chat, not a section header)
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Web: Chrome

Tested on Chrome — after clearing the search query, focus correctly lands on the first recent chat item (skipping the "Recent chats" section header).

Android: Native

N/A — focus behavior is desktop only (shouldUseNarrowLayout guard)

Android: mWeb Chrome

N/A — focus behavior is desktop only

iOS: Native

N/A — focus behavior is desktop only

iOS: mWeb Safari

N/A — focus behavior is desktop only

MacOS: Chrome / Safari

Tested on Chrome — after clearing the search query, focus correctly lands on the first recent chat item (skipping the "Recent chats" section header).

- [x] I verified that similar component doesn't exist in the codebase - [x] I verified that all props are defined accurately and each prop has a `/** comment above it */` - [x] I verified that each file is named correctly - [x] I verified that each component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone - [x] I verified that the only data being stored in component state is data necessary for rendering and nothing else - [x] In component if we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes - [x] For Class Components, any internal methods passed to components event handlers are bound to `this` properly so there are no scoping issues (i.e. for `onClick={this.submit}` the method `this.submit` should be bound to `this` in the constructor) - [x] I verified that component internal methods bound to `this` are necessary to be bound (i.e. avoid `this.submit = this.submit.bind(this);` if `this.submit` is never passed to a component event handler like `onClick`) - [x] I verified that all JSX used for rendering exists in the render method - [x] I verified that each component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

When the search query is cleared, the query-change effect was setting
focusedIndex to 0, which landed on a disabled section header instead
of the first focusable item. Reset hasSetInitialFocusRef so the
initial focus effect can re-fire with its header-skipping logic.

Co-authored-by: Roji Philip <rojiphil@users.noreply.github.com>
@MelvinBot
Copy link
Contributor Author

The failing typecheck check is unrelated to this PR's code changes — it's a transient GitHub Actions infrastructure failure.

Analysis: The actions/checkout step failed 3 times with a TLS error (GnuTLS recv error (-24): Decryption has failed) during git fetch. The typecheck itself never actually executed. This is a known intermittent GitHub infrastructure issue.

Evidence: The error logs show only git fetch failures, no TypeScript errors. All other checks (ESLint, builds, prettier, spellcheck) passed successfully.

Fix: Please re-run the failed typecheck workflow. No code changes are needed.

@codecov
Copy link

codecov bot commented Mar 9, 2026

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
...ListWithSections/BaseSelectionListWithSections.tsx 74.68% <0.00%> (-0.65%) ⬇️
src/components/Search/SearchAutocompleteList.tsx 62.50% <0.00%> (+10.98%) ⬆️
... and 41 files with indirect coverage changes

@rojiphil
Copy link
Contributor

rojiphil commented Mar 9, 2026

@MelvinBot I just tested and the Recent searches items are missing. Please add a test case to confirm that Recent searches are also displayed for given test steps.

Verify that the "Recent searches" section header appears when the
search query is empty and recent searches exist in Onyx.

Co-authored-by: Roji Philip <rojiphil@users.noreply.github.com>
@MelvinBot
Copy link
Contributor Author

Added a test case in tests/unit/SearchAutocompleteListTest.tsx that confirms the "Recent searches" section header is displayed when the search query is empty and recent searches exist in Onyx.

The test:

  1. Seeds Onyx with recent search entries (ONYXKEYS.RECENT_SEARCHES)
  2. Renders the SearchRouter component with pre-initialized options
  3. Flushes all pending React/Onyx updates
  4. Asserts that the "Recent searches" text is visible

Pushed in b3127a2.

- Type jest.requireActual with generic parameter to avoid no-unsafe-assignment
  and no-unsafe-member-access errors
- Use computed property names for timestamp keys to satisfy naming-convention rule

Co-authored-by: Roji Philip <rojiphil@users.noreply.github.com>
@MelvinBot
Copy link
Contributor Author

Fixed the failing ESLint check. The test file had 5 lint errors:

  • no-unsafe-assignment / no-unsafe-member-access (lines 41, 45): jest.requireActual returns any — fixed by adding a generic type parameter jest.requireActual<{default: React.ComponentType}>(...)
  • naming-convention (lines 172-173): Timestamp-format string keys ('2024-01-01T00:00:00') violated naming rules — fixed by using computed property names with const variables

@rojiphil
Copy link
Contributor

rojiphil commented Mar 9, 2026

@MelvinBot Sorry. I just verified that the sections does include the recent searches and its items. However, the recent searches are not rendered in the component. Why is it so?

@rojiphil
Copy link
Contributor

rojiphil commented Mar 9, 2026

@MelvinBot Please respond to the comment here

@MelvinBot
Copy link
Contributor Author

I traced the full rendering pipeline from sections data through to the UI. Here's what I found:

The data path is structurally correct:

  1. SearchAutocompleteList.tsx:380-381 — "Recent searches" section is pushed to sections[] when !autocompleteQueryValue && recentSearchesData.length > 0
  2. useFlattenedSections.ts:52-94 — The hook iterates all sections and creates both header items (for titled sections) and row items. It does not filter or skip any data.
  3. BaseSelectionListWithSections.tsx — Passes the flattened data to FlashList, which calls renderItem for each item
  4. SearchRouterItem — Checks isSearchQueryItem(item) (looks for searchItemType property). Since recent search items have searchItemType: SEARCH, they correctly route to SearchQueryListItem
  5. SearchQueryListItem — Unconditionally renders a BaseListItem with icon + text content

So why might items not appear visually?

The most likely explanation is FlashList virtualization. FlashList only renders items that are in or near the visible viewport. The component has shouldScrollToFocusedIndex={!isInitialRender} (line 496), and the initial focus effect at lines 423-446 scrolls to firstRecentReportKey (a "Recent chats" item). If the "Recent searches" section is above the scroll position, FlashList won't mount those items in the DOM.

Could you clarify what you're observing?

  • Platform: Web (Chrome/Safari) or native (iOS/Android)?
  • Visibility: Do you see the "Recent searches" section header but not its items? Or is the entire section (header + items) missing from the visible area?
  • Scrolling: If you scroll up from the focused item, do the "Recent searches" items become visible?
  • Inspection method: Are you checking via React DevTools component tree, browser DOM inspector, or visual inspection of the UI?

This would help me determine whether it's a FlashList viewport/measurement issue or something deeper in the rendering logic.

@rojiphil
Copy link
Contributor

rojiphil commented Mar 9, 2026

@MelvinBot This is via visual inspection of UI in web chrome. The entire section (header + items) missing from the visible area for Recent Searches. For Recent chats, I do not see the section header but see the items. Hope this helps.

When updateAndScrollToFocusedIndex was called with shouldScroll=false,
the direct scrollToIndex call was skipped but the onFocusedIndexChange
callback in useArrowKeyFocusManager still triggered a scroll. This caused
the list to scroll to the focused item (first recent chat), hiding the
"Recent searches" section and "Recent chats" header above the viewport.

Add a suppressNextFocusScrollRef that prevents the onFocusedIndexChange
callback from scrolling when shouldScroll=false is explicitly passed.
Also verify recent search items (not just section header) in test.

Co-authored-by: Roji Philip <rojiphil@users.noreply.github.com>
@MelvinBot
Copy link
Contributor Author

Thanks for the clarification — I found the root cause and pushed a fix in 1c080bc.

Root cause: When updateAndScrollToFocusedIndex(flatIndex, false) was called after clearing the query, the shouldScroll = false parameter only prevented the direct scrollToIndex call. However, setFocusedIndex still triggered the onFocusedIndexChange callback in useArrowKeyFocusManager, which checked shouldScrollToFocusedIndex (which is true after initial render) and scrolled to the focused item anyway. This caused the list to scroll to the first recent chat, pushing the entire "Recent searches" section and the "Recent chats" header above the viewport.

Fix: Added a suppressNextFocusScrollRef in BaseSelectionListWithSections that prevents the onFocusedIndexChange callback from scrolling when shouldScroll = false is explicitly passed to updateAndScrollToFocusedIndex. This makes the shouldScroll parameter work as intended — setting focus without scrolling.

Verified in browser: After clearing the query, "Recent searches" section (header + items) is now visible at the top, "Recent chats" header is visible, and focus is correctly on the first recent chat item.

Also updated the test to verify that recent search items themselves (not just the section header) are rendered.

- Add eslint-disable comments for @typescript-eslint/no-unsafe-assignment
  on jest.requireActual which returns any
- Avoid @typescript-eslint/naming-convention violation by building
  recentSearches object imperatively instead of using timestamp literals
  as object literal property keys

Co-authored-by: Roji Philip <rojiphil@users.noreply.github.com>
@MelvinBot
Copy link
Contributor Author

Fixed the failing ESLint check. The errors were in tests/unit/SearchAutocompleteListTest.tsx:

  1. @typescript-eslint/no-unsafe-assignment (lines 41, 45): jest.requireActual returns any despite the generic type parameter — added eslint-disable comments
  2. @typescript-eslint/naming-convention (lines 172–173): Timestamp strings like 2024-01-01T00:00:00 used as object literal property keys don't match camelCase/UPPER_CASE/PascalCase — restructured to build the object imperatively instead

The previous TypeScript check failure was an unrelated CI infrastructure issue (GnuTLS network error during git fetch).

@rojiphil
Copy link
Contributor

rojiphil commented Mar 9, 2026

Awesome @MelvinBot. Please mark the PR as ready for review

@MelvinBot MelvinBot marked this pull request as ready for review March 9, 2026 19:15
@MelvinBot MelvinBot requested a review from a team as a code owner March 9, 2026 19:16
@MelvinBot
Copy link
Contributor Author

This PR has been marked as ready for review as requested.

@melvin-bot melvin-bot bot requested review from rojiphil and removed request for a team March 9, 2026 19:16
@melvin-bot
Copy link

melvin-bot bot commented Mar 9, 2026

@rojiphil Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot requested review from JmillsExpensify and removed request for a team March 9, 2026 19:16
@rojiphil
Copy link
Contributor

rojiphil commented Mar 9, 2026

@MelvinBot Please resolve the failure of PR Author Checklist

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c7eac8ae3b

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment on lines +255 to +259
if (autocompleteQueryValue === '') {
// When query is cleared, reset the initial focus guard so the initial focus
// effect can re-fire and correctly focus the first focusable item (skipping section headers).
hasSetInitialFocusRef.current = false;
} else {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep list scrolled to top when query is cleared

When autocompleteQueryValue becomes empty, this branch only flips hasSetInitialFocusRef and no longer calls updateAndScrollToFocusedIndex(..., true), so the list can stay at a previously scrolled position while focus is moved to an item near the top by the initial-focus effect (updateAndScrollToFocusedIndex(flatIndex, false) later in the same component). In the common case where a user scrolls down search results and then clears the query, the highlighted item is off-screen, which makes keyboard focus appear lost again.

Useful? React with 👍 / 👎.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flipping hasSetInitialFocusRef will trigger the existing initial focus effect which will call updateAndScrollToFocusedIndex. So, this seems to be a non-issue.

Comment on lines +191 to +193
if (!shouldScroll) {
suppressNextFocusScrollRef.current = true;
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Reset suppressed-scroll state on no-op focus updates

Setting suppressNextFocusScrollRef.current = true before setFocusedIndex(index) assumes onFocusedIndexChange will always run next, but useArrowKeyFocusManager skips that callback when the index is unchanged. In that case the suppress flag leaks into the next real focus change and cancels scrolling unexpectedly (e.g., after a no-scroll update to the same index, the next ArrowDown changes focus but does not scroll).

Useful? React with 👍 / 👎.

@rojiphil
Copy link
Contributor

rojiphil commented Mar 9, 2026

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
84597-android-hybrid-001.mp4
Android: mWeb Chrome
84597-mweb-chrome-001.mp4
iOS: HybridApp
84597-ios-hybrid-001.mp4
iOS: mWeb Safari
84597-mweb-safari-001.mp4
MacOS: Chrome / Safari
84597-web-chrome-001.mp4

Copy link
Contributor

@rojiphil rojiphil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marcochavezf Changes LGTM and works well too.
All yours. Thanks.

@melvin-bot melvin-bot bot requested a review from marcochavezf March 9, 2026 20:08
@rojiphil
Copy link
Contributor

rojiphil commented Mar 9, 2026

@MelvinBot Please address the comment here

@MelvinBot
Copy link
Contributor Author

Resolved the PR Author Checklist failure — all 10 dynamically-added component checklist items have been checked, and the malformed trailing section has been cleaned up. The checklist check should pass on the next run.

Copy link
Contributor

@JmillsExpensify JmillsExpensify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change makes sense to me. Product approved.

Copy link
Contributor

@marcochavezf marcochavezf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM!

@rojiphil
Copy link
Contributor

@marcochavezf I think there is no pending task here other than merging with main

@marcochavezf marcochavezf merged commit 6fac4d6 into main Mar 13, 2026
32 of 35 checks passed
@marcochavezf marcochavezf deleted the claude-fixSearchFocusOnQueryClear branch March 13, 2026 17:03
@github-actions
Copy link
Contributor

🚧 @marcochavezf has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/marcochavezf in version: 9.3.38-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/cristipaval in version: 9.3.38-4 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants