[ECUK In-App 3DS] Add Passkeys/WebAuthn support for multifactor biometric authentication by dariusz-biela · Pull Request #84610 · Expensify/App

dariusz-biela · 2026-03-09T16:37:19Z

Explanation of Change

This PR adds Passkeys/WebAuthn as a new authentication method for in-app 3DS card transaction authorization on Web/mWeb, alongside the existing NativeBiometrics (iOS/Android). A platform-specific useBiometrics() hook abstracts both methods behind a shared UseBiometricsReturn interface so the MFA context is unaware of the underlying technology. The Biometrics/ module is refactored into NativeBiometrics/, Passkeys/, and shared/ directories. Passkeys are currently enabled only in the BiometricsTest scenario. Localization and tests are updated accordingly.

Detailed breakdown

usePasskeys hook — Manages the full Passkeys lifecycle (registration and authorization) by bridging low-level WebAuthn browser APIs with the MultifactorAuthenticationContext. Handles frontend ↔ backend credential exchange including challenge request/response flows.
WebAuthn helpers — Passkeys/WebAuthn.ts provides ArrayBuffer ↔ base64url conversions, builds PublicKeyCredentialCreationOptions/RequestOptions, and wraps navigator.credentials.create/get. A separate Passkeys/helpers.ts module maps common WebAuthn DOMException errors to internal error codes.
Shared biometrics abstraction — Extracts common types (UseBiometricsReturn, RegisterResult, AuthorizeResult, AuthorizeParams) and a useServerCredentials hook into biometrics/shared/ so that both useNativeBiometrics and usePasskeys share the same contract with the MFA context.
Platform-specific useBiometrics split — biometrics/useBiometrics/index.ts (web) re-exports usePasskeys, while index.native.ts re-exports useNativeBiometrics, so the MultifactorAuthenticationContext calls a single useBiometrics() hook and the platform decides which implementation runs.
MultifactorAuthenticationContext extension — Wires in the new useBiometrics() abstraction. Device eligibility is now checked in two steps: (2a) doesDeviceSupportAuthenticationMethod() verifies platform support, and (2b) the scenario's allowedAuthenticationMethods array is checked against deviceVerificationType. Prompt navigation now uses a PROMPT_TYPE_MAP to pick the correct prompt type (biometrics vs passkeys).
Scenario configuration — Extends the BiometricsTest scenario's allowedAuthenticationMethods from [BIOMETRICS] to [BIOMETRICS, PASSKEYS]. Other scenarios remain unchanged, so Passkeys are currently only available in the test flow.
NativeBiometrics refactor — Renames the Biometrics/ directory to NativeBiometrics/ and extracts native-specific types, helpers (Expo error decoding), and VALUES into dedicated files. Shared types and challenge types are moved to shared/. A new barrel file (MultifactorAuthentication/VALUES.ts) merges shared + NativeBiometrics + Passkeys values. The unused Observer.ts and MultifactorAuthenticationCallbacks are removed.
Registration flow change — keyInfo construction (previously in processing.ts via createKeyInfoObject) is now performed inside each hook (useNativeBiometrics / usePasskeys), and processRegistration receives the ready-made keyInfo object directly.
Prompt content updates — PromptContent.tsx now supports both Lottie animations and SVG illustrations (animation prop renamed to illustration). Passkeys use a new SVG asset (simple-illustration__encryption-passkeys.svg); native biometrics continue using the existing Lottie fingerprint animation.
Field renames — localPublicKey → localCredentialID, getLocalPublicKey → getLocalCredentialID, doesDeviceSupportBiometrics → doesDeviceSupportAuthenticationMethod, resetKeysForAccount → deleteLocalKeysForAccount across hooks, pages, selectors, and tests.
3DS navigation simplification — useNavigateTo3DSAuthorizationChallenge replaces the per-method switch-case with a single doesDeviceSupportAuthenticationMethod() && allowedAuthenticationMethods.includes(deviceVerificationType) check, removing the previous TODO comment about passkey support.
Type safety improvements — userVerification narrowed from string to UserVerificationRequirement, pubKeyCredParams.type narrowed from string to PublicKeyCredentialType, AuthTypeInfo.code made optional (passkeys don't use SecureStore codes). Added COSE_ALGORITHM constants (EDDSA, ES256, RS256) to CONST.
Selector changes — Removed hasBiometricsRegisteredSelector and isAccountLoadingSelector from selectors/Account.ts; added mfaCredentialIDsSelector used by the new useServerCredentials hook.
Localization — Adds Passkey-related user-facing strings (verifyYourself.passkeys, enableQuickVerification.passkeys, authType.passkey) across all supported languages.
Tests — Adds unit tests for processRegistration/processScenarioAction (processing.test.ts), NativeBiometrics Expo error decoding (NativeBiometrics/helpers.test.ts), and shared parseHttpRequest (shared/helpers.test.ts). Updates existing test suites for renamed fields and import paths. Removes obsolete Observer.test.ts and old Biometrics/helpers.test.ts.

Fixed Issues

$ #79464
$ #79467
$ #79469
PROPOSAL:

Tests

Prerequisites: The backend is not yet ready — testing requires the Auth and Web-Expensify PRs: https://github.com/Expensify/Auth/pull/19657
https://github.com/Expensify/Web-Expensify/pull/51463
https://github.com/Expensify/Auth/pull/20520

Passkeys registration (Web / mWeb):

Open Expensify App on Web (Chrome/Safari)
Navigate to Settings → Troubleshoot
Click on the "Test" button next to the "Passkeys (Not registered)" text
Click on the "Test" button in the RHP view
Fill the magic code input
Click on the "Got it" button
Authenticate using your browser's passkey/WebAuthn prompt (e.g. Touch ID, Windows Hello, security key)
Verify that the Authentication was successful
Verify that the registered label is now displayed

Passkeys authorization (Web / mWeb): 10. Repeat steps 3 and 4 11. Verify that the validate code step is no longer required 12. Authenticate using the passkey prompt 13. Verify that the Authentication was successful

Failure scenarios (Web / mWeb): 14. Cancel the passkey prompt during registration (step 7) — verify the Authentication failed 15. Cancel the passkey prompt during authorization (step 12) — verify the Authentication failed 16. Exit the flow using the back button or by clicking the overlay — verify a confirmation modal is displayed 17. Enter a wrong validate code during registration — verify an error text is displayed and the magic code input is shown again to allow re-entry

NativeBiometrics regression (iOS / Android native): 18. Open Expensify App on a native mobile device 19. Navigate to Settings → Troubleshoot 20. Click on the "Test" button next to the "Biometrics (Not registered)" text 21. Click on the "Test" button in the RHP view 22. Fill the magic code input 23. Click on the "Got it" button 24. Authenticate using device credentials or biometry (Face ID / Touch ID / fingerprint) 25. Verify that the Authentication was successful 26. Verify that the registered label is now displayed 27. Repeat steps 20 and 21 28. Verify that validate code is no longer required 29. Authenticate using device biometrics 30. Verify that the Authentication was successful

Verify that no errors appear in the JS console

Offline tests

N/A, D - Full Page Blocking UI Pattern for this project.

QA Steps

Same as tests

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Extract biometrics logic from Context/useNativeBiometrics into a dedicated biometrics/ module with platform-specific implementations (useBiometrics.ts for native, useBiometrics.web.ts for web). Add passkey stub implementation, WebAuthn error handling, and include PASSKEYS in allowed 3DS auth methods.

Implement WebAuthn-based passkey registration and authentication as a new MFA method alongside existing biometrics. Add passkey scenario configuration, translations, and SecureStore integration.

Strengthen source types in RegistrationChallenge and AuthenticationChallenge to use PublicKeyCredentialType and UserVerificationRequirement. Replace PublicKeyCredential casts with instanceof type guard. Derive SupportedTransport from CONST.PASSKEY_TRANSPORT with runtime guard for type narrowing.

Replace as casts for AuthenticatorAttestationResponse and AuthenticatorAssertionResponse with instanceof type guards. Use isSupportedTransport guard for getTransports() filtering.

Private keys should not leak beyond the registration function. For native biometrics the key is stored in SecureStore internally, for passkeys it never leaves the authenticator. No consumer of RegisterResult ever reads privateKey.

These debug logs were development artifacts that could leak sensitive authentication data (credential IDs, challenge content, backend responses) to the browser console in production.

Passkeys don't use SecureStore at all — the PASSKEY entry was misplaced. Define PASSKEY_AUTH_TYPE in WebAuthn.ts, make AuthTypeInfo.code optional (only relevant for native biometrics), and update derived types to include passkey via union.

melvin-bot · 2026-03-09T16:37:27Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

codecov · 2026-03-09T16:50:27Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/CONST/index.ts	`93.60% <ø> (ø)`
...tication/biometrics/shared/useServerCredentials.ts	`100.00% <100.00%> (ø)`
...orAuthentication/biometrics/useNativeBiometrics.ts	`100.00% <100.00%> (ø)`
...ion/components/AuthenticationMethodDescription.tsx	`50.00% <ø> (ø)`
...tication/config/scenarios/DefaultUserInterface.tsx	`100.00% <ø> (ø)`
...ultifactorAuthentication/config/scenarios/names.ts	`100.00% <ø> (ø)`
...uthentication/observability/trackMFAFlowOutcome.ts	`0.00% <ø> (ø)`
src/components/TestToolMenu.tsx	`90.32% <100.00%> (ø)`
src/hooks/useBiometricRegistrationStatus.ts	`100.00% <100.00%> (ø)`
...orAuthentication/NativeBiometrics/ED25519/index.ts	`100.00% <100.00%> (ø)`
... and 22 more
... and 7 files with indirect coverage changes

Reconcile server-known credential IDs with local Onyx credentials and pass the result as excludeCredentials to navigator.credentials.create, preventing the same authenticator from being registered twice.

…eTypes.ts These types (SignedChallenge, RegistrationChallenge, AuthenticationChallenge, etc.) are algorithm-agnostic and shared by both ED25519 (native biometrics) and ES256 (passkeys) flows. Moving them to a neutral location removes the misleading coupling to the ED25519 module.

Separate platform-specific logic into dedicated modules: - NativeBiometrics: Expo SecureStore, ED25519, native key management - Passkeys: WebAuthn API, passkey credential helpers - shared: challenge types, observers, HTTP helpers, common types Update all imports across source and test files.

JakubKorytko

some NITs, overall LGTM

tests/unit/libs/MultifactorAuthentication/shared/helpers.test.ts

src/libs/MultifactorAuthentication/VALUES.ts

src/libs/MultifactorAuthentication/shared/types.ts

src/libs/MultifactorAuthentication/Passkeys/WebAuthn.ts

src/libs/MultifactorAuthentication/Passkeys/helpers.ts

src/components/MultifactorAuthentication/Context/Main.tsx

src/components/MultifactorAuthentication/biometrics/shared/types.ts

src/components/MultifactorAuthentication/biometrics/usePasskeys.ts

… tests Remove unnecessary KeyStore mock, add tests for processPasskeyRegistration and processScenarioAction to cover the full processing module.

- Rename biometrics/common/ to biometrics/shared/ for consistency - Use spread in VALUES.ts barrel file - Rename MultifactorAuthenticationKeyInfo to NativeBiometricsKeyInfo - Replace `as` with type guard in Passkeys/helpers.ts - Remove redundant credentials.length check in usePasskeys - Rename (p) to (param) in WebAuthn.ts - Split shared/helpers.test.ts into NativeBiometrics/ and shared/ dirs - Unify processRegistration and processPasskeyRegistration: hooks now build keyInfo internally, processing.ts has one shared function

…s/passkeys-mfa # Conflicts: # src/components/MultifactorAuthentication/Context/Main.tsx # src/components/MultifactorAuthentication/biometrics/useNativeBiometrics.ts # src/libs/MultifactorAuthentication/shared/VALUES.ts

…tion Expose a platform-specific constant (BIOMETRICS on native, PASSKEYS on web) so consumers can check whether the scenario allows the current device's verification type, replacing the redundant switch-case fallthrough.

…r wrapper React Compiler handles memoization automatically, so useMemo and the module-level selector function are unnecessary.

Replace magic number -8 with CONST.COSE_ALGORITHM.EDDSA in types and runtime code. Add ES256 and RS256 constants for passkey use.

…directly

… responses

DylanDylann · 2026-03-17T11:27:52Z

@dariusz-biela TroubleshootMultifactorAuthentication Command is failing, it looks like it might be related to the authenticationMethod param.

Screen.Recording.2026-03-17.at.17.26.14.mov

dariusz-biela · 2026-03-17T11:32:31Z

@dariusz-biela TroubleshootMultifactorAuthentication Command is failing, it looks like it might be related to the authenticationMethod param.

@DylanDylann

This is because the backend team hasn't yet merged the changes for passkeys on their end. Unfortunately, we'll have to wait until this goes live in production before we can run manual tests in this PR.

Tests
Prerequisites: The backend is not yet ready — testing requires the Auth PR: https://github.com/Expensify/Auth/pull/19657

DylanDylann · 2026-03-17T11:37:16Z

@codex review

DylanDylann · 2026-03-17T11:22:29Z

src/libs/MultifactorAuthentication/Passkeys/WebAuthn.ts

+}
+
+/** Builds WebAuthn credential creation options from a backend registration challenge. */
+function buildPublicKeyCredentialCreationOptions(challenge: RegistrationChallenge, excludeCredentials: PublicKeyCredentialDescriptor[]): PublicKeyCredentialCreationOptions {


Let’s use buildAllowedCredentialDescriptors in this function instead of passing excludeCredentials, and then export it.

DylanDylann · 2026-03-17T11:34:18Z

src/libs/MultifactorAuthentication/Passkeys/helpers.ts

+/**
+ * Helper utilities for passkey/WebAuthn error decoding.
+ */
+import type {MultifactorAuthenticationReason} from '@libs/MultifactorAuthentication/shared/types';
+import VALUES from '@libs/MultifactorAuthentication/VALUES';


Why don't we put these functions in src/libs/MultifactorAuthentication/Passkeys/WebAuthn.ts? I don't see any reason to separate them into a new file

src/libs/MultifactorAuthentication/NativeBiometrics/types.ts

DylanDylann · 2026-03-17T11:50:04Z

src/components/MultifactorAuthentication/biometrics/usePasskeys.ts

+        try {
+            credential = await createPasskeyCredential(publicKeyOptions);
+        } catch (error) {
+            onResult({


NAB: Should we add await before onResult?

chatgpt-codex-connector · 2026-03-17T12:03:51Z

Codex Review: Something went wrong. Try again later by commenting “@codex review”.

Failed to set up container

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

…rics types

…thn.ts

…CreationOptions

…andling

…s/passkeys-mfa # Conflicts: # src/selectors/Account.ts

DylanDylann · 2026-03-18T07:07:03Z

The changes look fine to me. Waiting for the BE update to test

rafecolton · 2026-03-18T23:13:16Z

I tested this and it worked well! A couple of quirks - I think both are expected, but LMK if you don't think so.

When I used the QR code and passkeys & autofill were not enabled on my iPhone, I got a failure - it didn't wait for me to set it up. (I think this is expected.)
When I selected iCloud Keychain, I was prompted for my computer's password but no biometrics. I think this is ok because it's still using possession (the device), and knowledge (the password).

Screen.Recording.2026-03-18.at.3.30.20.PM.mov

rafecolton

Really nice job! This is so slick and works really well, and I love the way you did the abstraction

src/components/MultifactorAuthentication/biometrics/useNativeBiometrics.ts

src/libs/MultifactorAuthentication/Passkeys/VALUES.ts

chuckdries · 2026-03-19T00:03:15Z

Some test runs

macOS Chrome: cancelling the system passkey prompt shows failure screen ✅

passkey.rejected.mp4

macOS Chrome: If the user cancels the system passkey prompt, then runs through the test scenario again, the magic code page dumps them straight to a failure screen instead of prompting them again 🔴

Repro

Reject the passkey prompt as shown in the test case above
Immediately try the test scenario again without reloading the page

passkey.does.not.prompt.after.rejected.registration.attempt.mp4

macOS Chrome: happy path test scenario works ✅

passkey.success.after.reload.mp4

macOS Safari: biometrics test scenario simply does not work 🔴

passkey.registration.fails.in.safari.mp4

Error message An unknown WebAuthn error occurred

rafecolton · 2026-03-19T01:51:39Z

macOS Chrome: If the user cancels the system passkey prompt, then runs through the test scenario again, the magic code page dumps them straight to a failure screen instead of prompting them again 🔴

I was not able to reproduce this - it worked just fine for me. I wonder if this is caused by poor handling of magic code rate limiting - can you check the API responses? Here is it working for me:

Screen.Recording.2026-03-18.at.6.42.42.PM.mov

macOS Safari: biometrics test scenario simply does not work 🔴

This I was able to reproduce. Asked here if we should fix now, as a follow-up, or not at all. Though if you can fix it quickly @dariusz-biela before the discussion concludes, feel free!

rafecolton · 2026-03-19T01:52:27Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

N/A

Android: mWeb Chrome

iOS: HybridApp

N/A

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-03-18.at.6.42.42.PM.mov

github-actions · 2026-03-19T02:04:33Z

🚧 @rafecolton has triggered a test Expensify/App build. You can view the workflow run here.

rafecolton · 2026-03-19T02:04:54Z

Final TODOs before this can be merged:

Wait for Auth changes to be deployed
Test on mobile web on ad-hoc build
Tag design for feedback
Sort out Safari issues

github-actions · 2026-03-19T02:09:23Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #84610.

Android 🤖	iOS 🍎
⏩ SKIPPED ⏩	⏩ SKIPPED ⏩
The build for Android was skipped	The build for iOS was skipped

Web 🕸️
https://84610.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

chuckdries · 2026-03-19T02:25:30Z

I can no longer reproduce the cancel-then-fail behavior I saw in chrome. Also, I can confirm this works flawlessly in Firefox

chuckdries · 2026-03-19T02:48:10Z

Mobile web test results

iOS Safari: fail

Same as desktop safari

passkey.failure.ios.safari.mp4

Android Chrome: success ✅

Turns out you need to make sure your emulator is "Google Play" (not just Google APIs) and sign in to a Google account to use passkeys at all

passkeys.work.android.mp4

rafecolton · 2026-03-19T06:30:06Z

Thanks Chuck. If it's broken on mobile safari too, then I think we should hold off merging this until it's fixed. The Auth PR is merged and should go out tomorrow, so that should make testing easier

…riptive messages to device checks

dariusz-biela added 8 commits March 6, 2026 16:10

Add passkey authentication support for MFA

18f0cb7

Implement WebAuthn-based passkey registration and authentication as a new MFA method alongside existing biometrics. Add passkey scenario configuration, translations, and SecureStore integration.

Add as const to PROMPT_NAMES for literal type inference

2852952

Remove type assertions from usePasskeys.ts

41f1caa

Replace as casts for AuthenticatorAttestationResponse and AuthenticatorAssertionResponse with instanceof type guards. Use isSupportedTransport guard for getTransports() filtering.

Remove privateKey from BaseRegisterResult

2c2f281

Private keys should not leak beyond the registration function. For native biometrics the key is stored in SecureStore internally, for passkeys it never leaves the authenticator. No consumer of RegisterResult ever reads privateKey.

Remove console.debug calls from MFA components

f4c0494

These debug logs were development artifacts that could leak sensitive authentication data (credential IDs, challenge content, backend responses) to the browser console in production.

melvin-bot bot assigned dariusz-biela Mar 9, 2026

dariusz-biela added 4 commits March 10, 2026 11:01

Remove useCallback from usePasskeys — React Compiler handles memoization

2bf98b4

Pass excludeCredentials to passkey registration to prevent duplicates

fdd40fe

Reconcile server-known credential IDs with local Onyx credentials and pass the result as excludeCredentials to navigator.credentials.create, preventing the same authenticator from being registered twice.

JakubKorytko approved these changes Mar 11, 2026

View reviewed changes

dariusz-biela added 3 commits March 11, 2026 13:42

Rename helpers.test.ts to processing.test.ts and add passkey/scenario…

2541cca

… tests Remove unnecessary KeyStore mock, add tests for processPasskeyRegistration and processScenarioAction to cover the full processing module.

dariusz-biela force-pushed the dariusz-biela/feat/3ds/passkeys-mfa branch from 18da419 to 8171acc Compare March 11, 2026 21:23

dariusz-biela added 7 commits March 12, 2026 14:53

Simplify useServerCredentials — remove manual memoization and selecto…

8e2846e

…r wrapper React Compiler handles memoization automatically, so useMemo and the module-level selector function are unnecessary.

Extract COSE algorithm identifiers into CONST.COSE_ALGORITHM

9e5d340

Replace magic number -8 with CONST.COSE_ALGORITHM.EDDSA in types and runtime code. Add ES256 and RS256 constants for passkey use.

Remove redundant getLocalCredentials helper — inline null coalescing …

d82dfb5

…directly

Replace thrown errors with onResult callbacks for unexpected WebAuthn…

69022cd

… responses

Add EDDSA to cspell dictionary

2b7dbe3

Add WEBAUTHN.REGISTRATION_REQUIRED reason and use it in usePasskeys

1c5c930

Fix RevokePage test: rename localPublicKey to localCredentialID in mock

8e30110

DylanDylann reviewed Mar 17, 2026

View reviewed changes

dariusz-biela added 5 commits March 17, 2026 14:00

Import Base64URLString type from @src/utils/Base64URL in NativeBiomet…

f3c7b0d

…rics types

Move decodeWebAuthnError from Passkeys/helpers.ts into Passkeys/WebAu…

2e8e3b5

…thn.ts

Use buildAllowedCredentialDescriptors inside buildPublicKeyCredential…

18bcfb3

…CreationOptions

Add await before onResult calls in usePasskeys for consistent async h…

eab1219

…andling

Merge remote-tracking branch 'origin/main' into dariusz-biela/feat/3d…

986fd5b

…s/passkeys-mfa # Conflicts: # src/selectors/Account.ts

chuckdries mentioned this pull request Mar 18, 2026

[ECUK PIN Management] [FE] Enable Passkeys in Scenario config for SetPIN, ChangePIN, RevealPIN #85684

Open

rafecolton approved these changes Mar 18, 2026

View reviewed changes

src/components/MultifactorAuthentication/biometrics/useNativeBiometrics.ts Show resolved Hide resolved

src/libs/MultifactorAuthentication/Passkeys/VALUES.ts Show resolved Hide resolved

rafecolton previously approved these changes Mar 19, 2026

View reviewed changes

rafecolton added Design and removed Design labels Mar 19, 2026

Use UNSUPPORTED_DEVICE reason for disallowed auth method and add desc…

98686fe

…riptive messages to device checks

dariusz-biela dismissed rafecolton’s stale review via 98686fe March 19, 2026 14:43

Conversation

dariusz-biela commented Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Mar 9, 2026

Uh oh!

codecov bot commented Mar 9, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

JakubKorytko left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DylanDylann commented Mar 17, 2026

Uh oh!

dariusz-biela commented Mar 17, 2026

Uh oh!

DylanDylann commented Mar 17, 2026

Uh oh!

DylanDylann Mar 17, 2026

Choose a reason for hiding this comment

Uh oh!

DylanDylann Mar 17, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

DylanDylann Mar 17, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot commented Mar 17, 2026

Uh oh!

DylanDylann commented Mar 18, 2026

Uh oh!

rafecolton commented Mar 18, 2026

Uh oh!

rafecolton left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

chuckdries commented Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rafecolton commented Mar 19, 2026

Uh oh!

rafecolton commented Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

github-actions bot commented Mar 19, 2026

Uh oh!

rafecolton commented Mar 19, 2026

Uh oh!

github-actions bot commented Mar 19, 2026

Uh oh!

chuckdries commented Mar 19, 2026

Uh oh!

chuckdries commented Mar 19, 2026

Uh oh!

rafecolton commented Mar 19, 2026

Uh oh!

Reviewers

Assignees

Labels

dariusz-biela commented Mar 9, 2026 •

edited

Loading

codecov bot commented Mar 9, 2026 •

edited by github-actions bot

Loading

chuckdries commented Mar 19, 2026 •

edited

Loading

rafecolton commented Mar 19, 2026 •

edited

Loading