[GPS] Fix distance unit not translated on dynamic island#84615
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: View the translation diffdiff --git a/src/languages/it.ts b/src/languages/it.ts
index a2437452..a1ee16f5 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -362,7 +362,7 @@ const translations: TranslationDeepObject<typeof en> = {
per: 'for',
mi: 'miglio',
km: 'chilometro',
- milesAbbreviated: 'mi',
+ milesAbbreviated: 'me',
kilometersAbbreviated: 'km',
copied: 'Copiato!',
someone: 'Qualcuno',
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index f265584e..f2c8af64 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -362,8 +362,8 @@ const translations: TranslationDeepObject<typeof en> = {
per: 'あたり',
mi: 'マイル',
km: 'キロメートル',
- milesAbbreviated: 'マイル',
- kilometersAbbreviated: 'キロ',
+ milesAbbreviated: 'mi',
+ kilometersAbbreviated: 'km',
copied: 'コピーしました！',
someone: '誰か',
total: '合計',
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index 5ac15722..9a71a829 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -362,7 +362,7 @@ const translations: TranslationDeepObject<typeof en> = {
per: 'per',
mi: 'mijl',
km: 'kilometer',
- milesAbbreviated: 'mi',
+ milesAbbreviated: 'mijl',
kilometersAbbreviated: 'km',
copied: 'Gekopieerd!',
someone: 'Iemand',
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index d0d43774..4b7122e2 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -362,7 +362,7 @@ const translations: TranslationDeepObject<typeof en> = {
per: '每',
mi: '英里',
km: '千米',
- milesAbbreviated: '英里',
+ milesAbbreviated: '我',
kilometersAbbreviated: '千米',
copied: '已复制！',
someone: '某人',
Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
|
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6b2818d65e
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
src/pages/iou/request/step/IOURequestStepDistanceGPS/GPSNotifications/index.android.ts
Show resolved
Hide resolved
melvin-bot
bot
requested review from
aimane-chnaif
and removed request for
a team
|
@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
melvin-bot
bot
requested review from
heyjennahay
and removed request for
a team
|
Eslint job has been failing for everyone for a while now, so I guess there was a PR merged to main with too many eslint warnings |
|
@dukenv0307 this is ready FYI |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3ffe48d6b8
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
src/components/GPSTripStateChecker/useUpdateGpsNotification/index.ios.ts
Outdated
Show resolved
Hide resolved
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppScreen.Recording.2026-03-11.at.10.11.54.moviOS: mWeb SafariMacOS: Chrome / Safari |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 @AndrewGable has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/AndrewGable in version: 9.3.36-0 🚀
|
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.3.36-10 🚀
|
4 participants
Explanation of Change
Adding abbreviations for
milesandkilometersfor all languages and making sure that they're used for GPS Live Activity. Making sure that when preferred language changes the GPS Live Activity gets updadtedFixed Issues
$ #84554
PROPOSAL: N/A
MOBILE-EXPENSIFY: https://github.com/Expensify/Mobile-Expensify/pull/13884
Tests
Offline tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
iOS: Native
Screen.Recording.2026-03-10.at.11.00.51.mov