[No QA] Fix infinite Sentry spans caused by app state transitions by sosek108 · Pull Request #84736 · Expensify/App

sosek108 · 2026-03-10T12:07:15Z

Explanation of Change

Sentry spans were being created and tracked even when the app was in background or inactive state, causing them to never close properly and pollute traces with falsely long durations.

Two fixes:

activeSpans.ts: startSpan now checks AppState.currentState before creating a tracked span. If the app is not active, it creates a span, immediately marks it as cancelled, and ends it — so nothing lingers in the active spans map.
App.ts: When the app returns to foreground (inactive/background → active), cancelAllSpans() is called to clean up any stale spans that may have been opened before the guard was in place or during edge-case transitions.

Fixed Issues

$ #79653
PROPOSAL:

Tests

open any report
open app in second window
hide 1 window
on second window delete the report
go back to first report and validate in console that span related to report is cancelled
go to Sentry dashboard and validate if related span has canceled value

Offline tests

N/A

QA Steps

Same as tests

N/A

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

…s on foreground

melvin-bot · 2026-03-10T12:20:29Z

@ShridharGoel Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2026-03-10T12:28:33Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/libs/Navigation/Navigation.ts	`57.49% <100.00%> (-0.44%)`	⬇️
src/Expensify.tsx	`88.13% <66.66%> (-0.66%)`	⬇️
src/libs/telemetry/activeSpans.ts	`78.00% <50.00%> (-1.17%)`	⬇️
src/libs/actions/App.ts	`46.94% <0.00%> (-0.37%)`	⬇️
... and 190 files with indirect coverage changes

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: dc618e543a

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

src/libs/telemetry/activeSpans.ts

ShridharGoel · 2026-03-10T16:37:45Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

sosek108 · 2026-03-11T09:53:59Z

@codex review

chatgpt-codex-connector · 2026-03-11T10:14:47Z

Codex Review: Something went wrong. Try again later by commenting “@codex review”.

We were unable to download your code in a timely manner.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

rlinoz · 2026-03-11T10:51:05Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d162045fbe

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-03-11T11:17:09Z

src/libs/telemetry/activeSpans.ts

+    if ((AppState.currentState ?? CONST.APP_STATE.ACTIVE) !== CONST.APP_STATE.ACTIVE) {
+        return;


Preserve startup span when app launches from background

Returning early for any non-active app state drops spans entirely instead of closing them, which regresses startup telemetry for launch paths where React Native starts in background/inactive (the comment in src/libs/actions/App.ts already notes startup can be background). In those sessions, startSpan(CONST.TELEMETRY.SPAN_APP_STARTUP, ...) in src/setup/telemetry/index.native.ts no longer creates a span, so endSpan(CONST.TELEMETRY.SPAN_APP_STARTUP) in Expensify.onSplashHide cannot record startup duration at all; this silently removes data from performance traces rather than producing a canceled/finished span.

Useful? React with 👍 / 👎.

We want to discard all spans created in background. This is desired behavior

Yeah let's just test that we are still getting ManualAppStartup spans. I will run an adhoc build.

github-actions · 2026-03-11T11:26:08Z

🚧 @rlinoz has triggered a test Expensify/App build. You can view the workflow run here.

sosek108 · 2026-03-11T11:49:58Z

I did confirm that ManualAppStartup spans are created:

sosek108 · 2026-03-11T11:52:14Z

Browser:

rlinoz · 2026-03-11T18:00:31Z

not an emergency, I had already approved and Melvin re-requested my review and I didn't see it 🫠

OSBotify · 2026-03-11T18:08:19Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-03-11T18:44:04Z

🚧 @rlinoz has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-03-11T18:50:22Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #84736.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-7717c61-47a1081-f435c44e450bd36b0041a0df043d01e3ee044215/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-7717c61-47a1081-4ce67aad99cbbbe7b3f252186ee4456a0557656b/index.html

Web 🕸️
https://84736.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-03-11T20:06:35Z

🚀 Deployed to staging by https://github.com/rlinoz in version: 9.3.36-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-03-12T22:51:17Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.3.36-10 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Skip span creation when app is inactive/background, cancel stale span…

a123d02

…s on foreground

melvin-bot bot assigned sosek108 Mar 10, 2026

sosek108 added 2 commits March 10, 2026 13:11

skip spans

cb46f96

navigation fix - span can be undefined

dc618e5

sosek108 marked this pull request as ready for review March 10, 2026 12:20

sosek108 requested review from a team as code owners March 10, 2026 12:20

melvin-bot bot requested review from ShridharGoel and removed request for a team March 10, 2026 12:20

melvin-bot bot requested review from heyjennahay and removed request for a team March 10, 2026 12:20

sosek108 changed the title ~~Fix infinite Sentry spans caused by app state transitions~~ [No QA] Fix infinite Sentry spans caused by app state transitions Mar 10, 2026

sosek108 mentioned this pull request Mar 10, 2026

[Due for payment 2026-03-19] [Due for payment 2026-02-27] Sentry spans taking hours/days before they are closed or cancelled #79653

Open

adhorodyski approved these changes Mar 10, 2026

View reviewed changes

chatgpt-codex-connector bot reviewed Mar 10, 2026

View reviewed changes

src/libs/telemetry/activeSpans.ts Outdated Show resolved Hide resolved

sosek108 added 2 commits March 11, 2026 10:43

fixed the undefined AppState

20a9e50

fixed the undefined AppState

d162045

rlinoz approved these changes Mar 11, 2026

View reviewed changes

chatgpt-codex-connector bot reviewed Mar 11, 2026

View reviewed changes

This comment has been minimized.

Sign in to view

ShridharGoel approved these changes Mar 11, 2026

View reviewed changes

melvin-bot bot requested a review from rlinoz March 11, 2026 17:39

rlinoz merged commit 7717c61 into Expensify:main Mar 11, 2026
29 of 34 checks passed

OSBotify mentioned this pull request Mar 11, 2026

Deploy Checklist: New Expensify 2026-03-11 #84953

Closed

		if ((AppState.currentState ?? CONST.APP_STATE.ACTIVE) !== CONST.APP_STATE.ACTIVE) {
		return;

Conversation

sosek108 commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Mar 10, 2026

Uh oh!

codecov bot commented Mar 10, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

ShridharGoel commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

sosek108 commented Mar 11, 2026

Uh oh!

chatgpt-codex-connector bot commented Mar 11, 2026

Uh oh!

rlinoz commented Mar 11, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

sosek108 Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

rlinoz Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Mar 11, 2026

Uh oh!

This comment has been minimized.

sosek108 commented Mar 11, 2026

Uh oh!

sosek108 commented Mar 11, 2026

Uh oh!

Uh oh!

rlinoz commented Mar 11, 2026

Uh oh!

OSBotify commented Mar 11, 2026

Uh oh!

github-actions bot commented Mar 11, 2026

Uh oh!

github-actions bot commented Mar 11, 2026

Uh oh!

OSBotify commented Mar 11, 2026

Uh oh!

OSBotify commented Mar 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

sosek108 commented Mar 10, 2026 •

edited

Loading

codecov bot commented Mar 10, 2026 •

edited by github-actions bot

Loading

ShridharGoel commented Mar 10, 2026 •

edited

Loading