82322: The real return reason is only show in Expensify Classic when a report payment bounces by abbasifaizan70 · Pull Request #84823 · Expensify/App

abbasifaizan70 · 2026-03-10T23:53:02Z

Explanation of Change

Updated New Expensify to show the actual ACH bounce returnReason in report actions (couldn't process the payment: {returnReason}) instead of always showing a generic bank-account issue message.
When returnReason is missing, it now falls back to couldn't process the payment due to an incorrect routing/account number or closed account, with new translation keys added consistently across locales.

Fixed Issues

$ #82322
PROPOSAL: #82322 (comment)

Tests

Verify that no errors appear in the JS console

Precondition:
Have an approved reimbursable report on a workspace with a CorPay reimbursement account set on it. Have a deposit account set that is not USD.

Amend your deposit account so the name doesn't match your account details
After approval, have the VBA admin pay the report
Wait for the bounce back
See the reportAction show the return reason in Expensify Classic but not in New Expensify
The return reason should show for in both platforms. It should read: couldn't process the payment: $returnReason When no returnReason is available, it should default to the same return reason we send via email in https://github.com/Expensify/Web-Expensify/blob/main/lib/Notification/ACHCreditBounce.php which is: couldn't process the payment due to an incorrect routing/account number or closed account

Offline tests

QA Steps

Verify that no errors appear in the JS console
same as tests.

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

melvin-bot · 2026-03-10T23:53:08Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

codecov · 2026-03-11T02:10:29Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/libs/ReportActionsUtils.ts	`54.55% <0.00%> (+11.89%)`	⬆️
... and 564 files with indirect coverage changes

melvin-bot · 2026-03-11T18:50:03Z

@suneox Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

suneox · 2026-03-12T14:04:03Z

@abbasifaizan70 You need to complete all author checklist At Screenshots/Videos section you can mock data to show message or comment reason

For language translation we need to complete and get confirmation as a checklist item

I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

You can apply this translation patch by existing generate tool

84823.patch

mountiny · 2026-03-12T20:35:47Z

@twisterdotcom We could create adhoc here and test via supportal if you have some account with the report actions

abbasifaizan70 · 2026-03-12T22:50:52Z

I could not fully reproduce this flow locally because it depends on external CorPay + VBA reimbursement processing and an async ACH bounce callback from the payment processor. Local/dev environments do not provide a controllable real bounce event with returnReason parity to production flows.

@suneox @mountiny

twisterdotcom · 2026-03-12T23:04:39Z

My real account has these report actions on yeah: ID: R00SM0kFitop (Long ID: 6191040852169979)

[
...
  {
    "action": "REIMBURSEMENTACHBOUNCE",
    "created": "2026-03-04 21:08:20.310",
    "accountEmail": "concierge@expensify.com",
    "accountID": "8392101",
    "message": {
      "actionableForAccountIDs": [
        5356024
      ],
      "amount": 1000,
      "cancellationReason": "CANCEL_REASON_CREDIT_BOUNCE",
      "currency": "GBP",
      "expenseReportID": 6191040852169979,
      "lastModified": "2026-03-04 21:08:20.310",
      "returnReason": "ANNM Account Name does Not Match"
    }
  }
]

joekaufmanexpensify

Great change!

abbasifaizan70 · 2026-03-13T21:20:57Z

@suneox updates translations and added a comment on why we cannot test it locally. Can u take a look? Thanks

suneox · 2026-03-14T10:19:00Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

I cannot simulate that case.

Android: mWeb Chrome

I cannot simulate that case.

iOS: HybridApp

I cannot simulate that case.

iOS: mWeb Safari

I cannot simulate that case.

MacOS: Chrome / Safari

I cannot simulate that case.

suneox

Since we haven't set up data for this case, but based on the schema and api response, the change set LGTM

src/libs/ReportActionsUtils.ts

…nto 82322

abbasifaizan70 · 2026-03-17T21:36:51Z

@mountiny added test cases. Thanks

mountiny

Thank you

github-actions · 2026-03-17T22:02:16Z

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-03-17T22:04:25Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-03-17T22:12:13Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #84823.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-b12722f-84e475f-77d09b73609720c3600ee9a5e3eae06352e51080/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-b12722f-84e475f-504ddab03ed9b6fbb0e6cb65555a77d56cfbdb77/index.html

Web 🕸️
https://84823.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

twisterdotcom · 2026-03-17T23:52:51Z

Nice!

I think this is fine, and we should eventually add an "Explain" option to these which can link what we need. cc @marcaaron how would I go about requesting that next?

OSBotify · 2026-03-18T13:29:51Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.3.40-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

kavimuru · 2026-03-18T13:36:58Z

@abbasifaizan70 @joekaufmanexpensify

I think QA team can't meet this precondition, could this be verified internally?

Precondition:
Have an approved reimbursable report on a workspace with a CorPay reimbursement account set on it. Have a deposit account set that is not USD.

OSBotify · 2026-03-18T14:05:52Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.3.40-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

82322: WIP

1439a32

melvin-bot bot assigned abbasifaizan70 Mar 10, 2026

abbasifaizan70 mentioned this pull request Mar 10, 2026

[$250] The real return reason is only show in Expensify Classic when a report payment bounces #82322

Open

7 tasks

Fixed eslint issus

adc95a6

abbasifaizan70 marked this pull request as ready for review March 11, 2026 18:49

abbasifaizan70 requested review from a team as code owners March 11, 2026 18:49

melvin-bot bot requested review from suneox and removed request for a team March 11, 2026 18:50

melvin-bot bot requested review from joekaufmanexpensify and removed request for a team March 11, 2026 18:51

Updated translations

65ecdbc

abbasifaizan70 changed the title ~~82322: WIP~~ 82322: The real return reason is only show in Expensify Classic when a report payment bounces Mar 12, 2026

Merge branch 'Expensify:main' into 82322

8e0e9d4

joekaufmanexpensify previously approved these changes Mar 13, 2026

View reviewed changes

suneox approved these changes Mar 14, 2026

View reviewed changes

melvin-bot bot requested a review from mountiny March 14, 2026 10:20

mountiny requested changes Mar 15, 2026

View reviewed changes

src/libs/ReportActionsUtils.ts Show resolved Hide resolved

abbasifaizan70 added 2 commits March 18, 2026 02:13

Added test cases

7ff635e

Merge branch '82322' of https://github.com/abbasifaizan70/Expensify i…

8b92c5e

…nto 82322

abbasifaizan70 dismissed joekaufmanexpensify’s stale review via 8b92c5e March 17, 2026 21:14

Fixed typescript issues

06dc3d7

mountiny approved these changes Mar 17, 2026

View reviewed changes

mountiny merged commit b12722f into Expensify:main Mar 17, 2026
30 checks passed

OSBotify mentioned this pull request Mar 18, 2026

Deploy Checklist: New Expensify 2026-03-18 #85646

Open

84 tasks

Conversation

abbasifaizan70 commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Mar 10, 2026

Uh oh!

codecov bot commented Mar 11, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot bot commented Mar 11, 2026

Uh oh!

suneox commented Mar 12, 2026

Uh oh!

mountiny commented Mar 12, 2026

Uh oh!

abbasifaizan70 commented Mar 12, 2026

Uh oh!

twisterdotcom commented Mar 12, 2026

Uh oh!

joekaufmanexpensify left a comment

Choose a reason for hiding this comment

Uh oh!

abbasifaizan70 commented Mar 13, 2026

Uh oh!

suneox commented Mar 14, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

suneox left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

abbasifaizan70 commented Mar 17, 2026

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Mar 17, 2026

Uh oh!

OSBotify commented Mar 17, 2026

Uh oh!

github-actions bot commented Mar 17, 2026

Uh oh!

twisterdotcom commented Mar 17, 2026

Uh oh!

OSBotify commented Mar 18, 2026

Uh oh!

kavimuru commented Mar 18, 2026

Uh oh!

OSBotify commented Mar 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

abbasifaizan70 commented Mar 10, 2026 •

edited

Loading

codecov bot commented Mar 11, 2026 •

edited by github-actions bot

Loading