[No QA] Delete outdated and placeholder docs replaced by new integration errors docs set #84831
Conversation
…ntegrations error docs
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@greg-schroeder Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
HelpDot Documentation ReviewOverall AssessmentThis PR performs a large-scale cleanup by deleting 50 outdated and placeholder troubleshooting documentation files across 7 accounting integrations (Accelo, Certinia, NetSuite, QuickBooks Desktop, QuickBooks Online, Sage Intacct, Xero) for both Expensify Classic and New Expensify. It replaces them with redirects pointing to the new integration error docs hub structure. The approach is sound -- the old monolithic troubleshooting articles and "under construction" placeholder pages are being consolidated into the new per-error-code documentation structure that already exists in the repository. The redirects.csv changes are well-organized: 80 old redirect targets pointing to now-deleted files are updated to point to the new Troubleshooting hub pages, and 51 new redirects are added for the deleted files themselves and their sub-pages. Scores Summary
Key FindingsPotential broken redirect -- Accelo Troubleshooting hub does not exist: However, unlike the other integrations (Certinia, NetSuite, QBO, QBD, Sage Intacct, Xero), there is no
6 placeholder Overview.md files are not being deleted: Expensify Classic (2 missed):
New Expensify (4 missed): These all contain the same placeholder text: "This section is under construction. Content will be added in a follow-up PR." If the intent is to remove all placeholder Overview.md files, these should be deleted and redirected as well. Positive aspects:
Recommendations
Files Reviewed
Note: This PR is purely a deletion/redirect PR with no new prose content, so readability and style scores reflect the quality and consistency of the redirect mappings rather than written documentation. |
| https://help.expensify.com/articles/expensify-classic/connections/certinia/Troubleshooting/Authentication-and-Login-errors/Overview,https://help.expensify.com/expensify-classic/hubs/connections/certinia/Troubleshooting | ||
| https://help.expensify.com/articles/expensify-classic/connections/netsuite/Troubleshooting/Connection-errors/Overview,https://help.expensify.com/expensify-classic/hubs/connections/netsuite/Troubleshooting | ||
| https://help.expensify.com/articles/expensify-classic/connections/netsuite/Troubleshooting/Authentication-and-Login-errors/Overview,https://help.expensify.com/expensify-classic/hubs/connections/netsuite/Troubleshooting | ||
| https://help.expensify.com/articles/expensify-classic/connections/quickbooks-online/Troubleshooting/Sync-Errors/Overview,https://help.expensify.com/expensify-classic/hubs/connections/quickbooks-online/Troubleshooting |
There was a problem hiding this comment.
Missing redirect: The file docs/articles/expensify-classic/connections/quickbooks-online/Troubleshooting/Export-Errors/Overview.md is being deleted in this PR but has no corresponding redirect entry. All other Expensify Classic QBO Troubleshooting sub-pages (Sync-Errors, Connection-errors, Authentication-and-Login-errors) have redirects, but Export-Errors is missing.
Please add a line like:
https://help.expensify.com/articles/expensify-classic/connections/quickbooks-online/Troubleshooting/Export-Errors/Overview,https://help.expensify.com/expensify-classic/hubs/connections/quickbooks-online/Troubleshooting
The destination hub page docs/expensify-classic/hubs/connections/quickbooks-online/Troubleshooting/Export-Errors.html exists, so alternatively the redirect could point directly to that more specific page.
|
@MelvinBot how can I resolve the build error |
|
The build is failing because of a malformed entry in The problematic line: It should be: Two things to fix:
All the other Export-Errors/Overview redirects you added follow this pattern correctly — this one just needs the same treatment. |
|
A preview of your ExpensifyHelp changes have been deployed to https://1fd05d38.helpdot.pages.dev ⚡️ Updated articles: |
|
🚀 Deployed to staging by https://github.com/CortneyOfstad in version: 9.3.36-0 🚀
|
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.3.36-10 🚀
|
Master project issue https://github.com/Expensify/Expensify/issues/469226
cc: @CortneyOfstad