Skip to content

[No QA] Delete outdated and placeholder docs replaced by new integration errors docs set #84831

Merged
CortneyOfstad merged 4 commits intomainfrom
helpsite-delete-outdated-error-docs
Mar 11, 2026
Merged

[No QA] Delete outdated and placeholder docs replaced by new integration errors docs set #84831
CortneyOfstad merged 4 commits intomainfrom
helpsite-delete-outdated-error-docs

Conversation

@stephanieelliott
Copy link
Contributor

@stephanieelliott stephanieelliott self-assigned this Mar 11, 2026
@stephanieelliott stephanieelliott requested a review from a team as a code owner March 11, 2026 01:16
@melvin-bot
Copy link

melvin-bot bot commented Mar 11, 2026

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @greg-schroeder

@melvin-bot melvin-bot bot requested review from greg-schroeder and removed request for a team March 11, 2026 01:16
@melvin-bot
Copy link

melvin-bot bot commented Mar 11, 2026

@greg-schroeder Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@github-actions
Copy link
Contributor

HelpDot Documentation Review

Overall Assessment

This PR performs a large-scale cleanup by deleting 50 outdated and placeholder troubleshooting documentation files across 7 accounting integrations (Accelo, Certinia, NetSuite, QuickBooks Desktop, QuickBooks Online, Sage Intacct, Xero) for both Expensify Classic and New Expensify. It replaces them with redirects pointing to the new integration error docs hub structure. The approach is sound -- the old monolithic troubleshooting articles and "under construction" placeholder pages are being consolidated into the new per-error-code documentation structure that already exists in the repository.

The redirects.csv changes are well-organized: 80 old redirect targets pointing to now-deleted files are updated to point to the new Troubleshooting hub pages, and 51 new redirects are added for the deleted files themselves and their sub-pages.

Scores Summary

  • Readability: 9/10 - Not directly applicable since this is a deletion/redirect PR, but the redirect structure is clean and logical. The URL patterns are consistent and self-explanatory.
  • AI Readiness: 8/10 - The new Troubleshooting hub URLs follow a consistent, descriptive hierarchy (e.g., /expensify-classic/hubs/connections/netsuite/Troubleshooting). One concern: the Accelo redirect destination does not appear to have a corresponding Troubleshooting hub page, which would hurt discoverability.
  • Style Compliance: 9/10 - The redirect mappings consistently follow the established pattern of routing from old article paths to new hub paths. Integration naming is consistent throughout.

Key Findings

Potential broken redirect -- Accelo Troubleshooting hub does not exist:
The PR adds this redirect (line ~254 of the new additions):

https://help.expensify.com/articles/expensify-classic/connections/accelo/Accelo-Troubleshooting,https://help.expensify.com/expensify-classic/hubs/connections/accelo/Troubleshooting

However, unlike the other integrations (Certinia, NetSuite, QBO, QBD, Sage Intacct, Xero), there is no Troubleshooting.html hub page under docs/expensify-classic/hubs/connections/accelo/. Only accelo.html exists at that level. This redirect will likely result in a 404 page. Consider either:

  • Creating the accelo/Troubleshooting.html hub page, or
  • Redirecting to https://help.expensify.com/expensify-classic/hubs/connections/accelo instead

6 placeholder Overview.md files are not being deleted:
The PR deletes 38 out of 44 identical placeholder "under construction" Overview.md files. The following 6 remain and should likely be included in this cleanup:

Expensify Classic (2 missed):

  1. docs/articles/expensify-classic/connections/certinia/Troubleshooting/Export-Errors/Overview.md
  2. docs/articles/expensify-classic/connections/quickbooks-online/Troubleshooting/Connection-errors/Overview.md

New Expensify (4 missed):
3. docs/articles/new-expensify/connections/quickbooks-online/Troubleshooting/Export-Errors/Overview.md
4. docs/articles/new-expensify/connections/sage-intacct/Troubleshooting/Authentication-and-Login-errors/Overview.md
5. docs/articles/new-expensify/connections/sage-intacct/Troubleshooting/Connection-errors/Overview.md
6. docs/articles/new-expensify/connections/xero/Troubleshooting/Connection-errors/Overview.md

These all contain the same placeholder text: "This section is under construction. Content will be added in a follow-up PR." If the intent is to remove all placeholder Overview.md files, these should be deleted and redirected as well.

Positive aspects:

  • The redirect coverage is thorough -- community forum URLs, old article paths, and placeholder sub-page paths are all accounted for
  • The redirect destination URLs are consistent and well-structured across all integrations
  • The new per-error-code docs structure (e.g., ONL088-Export-Error.md, INT043-Export-Error.md) already exists in the repository, confirming these deletions are safe
  • No remaining internal documentation cross-references to the deleted files were found in other .md files

Recommendations

  1. [Must fix] Verify the Accelo Troubleshooting redirect destination. Either create the missing accelo/Troubleshooting.html hub page or update the redirect to point to an existing page (such as the Accelo hub itself).
  2. [Should fix] Delete the 6 remaining placeholder "under construction" Overview.md files and add corresponding redirect entries for them, to complete the cleanup started in this PR.
  3. [Nice to have] Consider adding redirect entries for the 6 missed placeholder files even if they are not deleted in this PR, so users reaching those pages get routed to the correct Troubleshooting hub.

Files Reviewed

  • docs/redirects.csv (+131/-80) - Updated redirect mappings from old troubleshooting article paths to new Troubleshooting hub paths. Redirect targets verified to exist (except Accelo, see above).
  • 50 deleted files - 12 main troubleshooting articles (Accelo, Certinia, NetSuite, QBD, QBO, Sage Intacct, Xero across Classic and New Expensify) and 38 placeholder Overview.md files. All deletions are appropriate -- content has been superseded by the new per-error-code documentation structure.

Note: This PR is purely a deletion/redirect PR with no new prose content, so readability and style scores reflect the quality and consistency of the redirect mappings rather than written documentation.

https://help.expensify.com/articles/expensify-classic/connections/certinia/Troubleshooting/Authentication-and-Login-errors/Overview,https://help.expensify.com/expensify-classic/hubs/connections/certinia/Troubleshooting
https://help.expensify.com/articles/expensify-classic/connections/netsuite/Troubleshooting/Connection-errors/Overview,https://help.expensify.com/expensify-classic/hubs/connections/netsuite/Troubleshooting
https://help.expensify.com/articles/expensify-classic/connections/netsuite/Troubleshooting/Authentication-and-Login-errors/Overview,https://help.expensify.com/expensify-classic/hubs/connections/netsuite/Troubleshooting
https://help.expensify.com/articles/expensify-classic/connections/quickbooks-online/Troubleshooting/Sync-Errors/Overview,https://help.expensify.com/expensify-classic/hubs/connections/quickbooks-online/Troubleshooting
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing redirect: The file docs/articles/expensify-classic/connections/quickbooks-online/Troubleshooting/Export-Errors/Overview.md is being deleted in this PR but has no corresponding redirect entry. All other Expensify Classic QBO Troubleshooting sub-pages (Sync-Errors, Connection-errors, Authentication-and-Login-errors) have redirects, but Export-Errors is missing.

Please add a line like:

https://help.expensify.com/articles/expensify-classic/connections/quickbooks-online/Troubleshooting/Export-Errors/Overview,https://help.expensify.com/expensify-classic/hubs/connections/quickbooks-online/Troubleshooting

The destination hub page docs/expensify-classic/hubs/connections/quickbooks-online/Troubleshooting/Export-Errors.html exists, so alternatively the redirect could point directly to that more specific page.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@stephanieelliott
Copy link
Contributor Author

@MelvinBot how can I resolve the build error

@MelvinBot
Copy link
Contributor

The build is failing because of a malformed entry in docs/redirects.csv. The last redirect you added uses a relative file path instead of a full URL as the source.

The problematic line:

docs/articles/expensify-classic/connections/quickbooks-online/Troubleshooting/Export-Errors/Overview.md,https://help.expensify.com/expensify-classic/hubs/connections/quickbooks-online/Troubleshooting

It should be:

https://help.expensify.com/articles/expensify-classic/connections/quickbooks-online/Troubleshooting/Export-Errors/Overview,https://help.expensify.com/expensify-classic/hubs/connections/quickbooks-online/Troubleshooting

Two things to fix:

  1. The source URL needs to start with https://help.expensify.com/ (not a relative docs/ path)
  2. Remove the .md extension from the source URL

All the other Export-Errors/Overview redirects you added follow this pattern correctly — this one just needs the same treatment.

@github-actions github-actions bot changed the title Delete outdated and placeholder docs replaced by new integration errors docs set [No QA] Delete outdated and placeholder docs replaced by new integration errors docs set Mar 11, 2026
@OSBotify
Copy link
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://1fd05d38.helpdot.pages.dev ⚡️

Updated articles:

@stephanieelliott stephanieelliott removed the request for review from greg-schroeder March 11, 2026 02:19
@CortneyOfstad CortneyOfstad merged commit 579b499 into main Mar 11, 2026
13 checks passed
@CortneyOfstad CortneyOfstad deleted the helpsite-delete-outdated-error-docs branch March 11, 2026 11:56
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/CortneyOfstad in version: 9.3.36-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/luacmartins in version: 9.3.36-10 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants