Pass settings.json to AI reviewer GitHub Action#84854
Draft
kacper-mikolajczak wants to merge 1 commit intoExpensify:mainfrom
Draft
Pass settings.json to AI reviewer GitHub Action#84854kacper-mikolajczak wants to merge 1 commit intoExpensify:mainfrom
kacper-mikolajczak wants to merge 1 commit intoExpensify:mainfrom
Conversation
Move tool permissions from inline --allowedTools in claude_args to .claude/settings.json and pass the settings file via the action's settings input. This keeps repo-level Claude config in one place and ensures the reviewer respects project settings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
The AI code reviewer GitHub Action previously specified tool permissions inline via
--allowedToolsinclaude_args. This duplicated what can be centrally managed in.claude/settings.json.This PR:
Task,Glob,Grep,Read, scopedBashpatterns, andmcp__github_inline_comment__create_inline_comment) to.claude/settings.jsonpermissions.allow.claude/settings.jsonto both claude-code-action steps via thesettingsinput--allowedToolsflags fromclaude_argsThis keeps tool permissions in a single source of truth and ensures the reviewer respects all repo-level Claude configuration (hooks, plugins, permissions).
Fixed Issues
$ #83480
PROPOSAL:
Tests
src/files - verify the code review Claude Action runs and posts inline comments as beforedocs/files - verify the docs review Claude Action runs correctlyOffline tests
N/A - changes don't affect offline behavior. This only modifies CI workflow configuration.
QA Steps
Same as Tests above (steps 1-3). Requires a PR to trigger the workflow.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari