[No QA] Update Set-Up-and-Manage-the-Expensify-Card.md#84862
[No QA] Update Set-Up-and-Manage-the-Expensify-Card.md#84862twisterdotcom merged 4 commits intomainfrom
Conversation
Add Single-use card type, optional expiration dates, and updated limit type descriptions to the Expensify Card documentation. Co-authored-by: Zany Renney <zanyrenney@users.noreply.github.com>
docs/articles/new-expensify/expensify-card/Set-Up-and-Manage-the-Expensify-Card.md
Outdated
Show resolved
Hide resolved
docs/articles/new-expensify/expensify-card/Set-Up-and-Manage-the-Expensify-Card.md
Show resolved
Hide resolved
docs/articles/new-expensify/expensify-card/Set-Up-and-Manage-the-Expensify-Card.md
Show resolved
Hide resolved
docs/articles/new-expensify/expensify-card/Set-Up-and-Manage-the-Expensify-Card.md
Show resolved
Hide resolved
HelpDot Documentation ReviewOverall AssessmentThis PR updates the Expensify Card documentation to reflect two new features: Single-use virtual cards and optional expiration dates for virtual cards. The changes are well-scoped, covering the feature list, step-by-step instructions, the Monitor and Manage Cards section, and new FAQ entries. The additions are generally clear and consistent with the existing document structure. Scores Summary
Key FindingsPositive aspects:
Issues to address:
Recommendations
Files Reviewed
Note: This review covers only the proposed changes in the diff, not the unchanged portions of the document. |
|
A preview of your ExpensifyHelp changes have been deployed to https://head.helpdot.pages.dev ⚡️ Updated articles: |
|
@stephanieelliott Please can I get your help on the images? I have them in another file but not sure if the process has changed or improved in the upload sitch so if you have a way to bulk do these with the borader helpsite updates, that would be amazing! https://github.com/Expensify/Expensify/issues/600202 |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
@zanyrenney we just need the .png files from design to get these added! If you want, we just can merge this now and then I can come back to add the images when design shares them. Either way though, happy to add the images for you. I do have some quick shortcuts for doing it. I approved the PR - you should be able to merge it if you'd like |
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@inimaga @twisterdotcom One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@zanyrenney added images! FYI you con't be able to see them on the dev preview page but if you want to review, the images on the page should match their file names |
|
Won't let me merge @stephanieelliott but thanks so much re the images! |
|
@twisterdotcom looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
|
🚀 Deployed to staging by https://github.com/twisterdotcom in version: 9.3.38-0 🚀
|
|
🚀 Deployed to production by https://github.com/cristipaval in version: 9.3.38-4 🚀
|
We have rolled out additional features to the Expensify Card for Single use and expire by cards, so let's update our Set up and manage cards page for this.
This recreates the changes from PR #82437, which was reverted.
Explanation of Change
Updates the Expensify Card documentation to reflect new features:
Fixed Issues
https://github.com/Expensify/Expensify/issues/567835
Tests
Offline tests
N/A - documentation only
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
N/A - documentation-only change