Skip to content

[No QA] Update Set-Up-and-Manage-the-Expensify-Card.md#84862

Merged
twisterdotcom merged 4 commits intomainfrom
claude-updateExpensifyCardDocs
Mar 13, 2026
Merged

[No QA] Update Set-Up-and-Manage-the-Expensify-Card.md#84862
twisterdotcom merged 4 commits intomainfrom
claude-updateExpensifyCardDocs

Conversation

@MelvinBot
Copy link
Contributor

We have rolled out additional features to the Expensify Card for Single use and expire by cards, so let's update our Set up and manage cards page for this.

This recreates the changes from PR #82437, which was reverted.

Explanation of Change

Updates the Expensify Card documentation to reflect new features:

  • Added Single-use virtual card limit type
  • Added optional expiration dates for virtual cards
  • Updated limit type descriptions (Smart, Monthly, Fixed) for clarity
  • Added FAQ entries for Single-use cards and expiration behavior
  • Added automatic deactivation notes for Single-use and expired cards

Fixed Issues

https://github.com/Expensify/Expensify/issues/567835

Tests

  • Verify that no errors appear in the JS console

Offline tests

N/A - documentation only

QA Steps

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

N/A - documentation-only change

Add Single-use card type, optional expiration dates, and updated limit
type descriptions to the Expensify Card documentation.

Co-authored-by: Zany Renney <zanyrenney@users.noreply.github.com>
@github-actions
Copy link
Contributor

HelpDot Documentation Review

Overall Assessment

This PR updates the Expensify Card documentation to reflect two new features: Single-use virtual cards and optional expiration dates for virtual cards. The changes are well-scoped, covering the feature list, step-by-step instructions, the Monitor and Manage Cards section, and new FAQ entries. The additions are generally clear and consistent with the existing document structure.

Scores Summary

  • Readability: 7/10 - The new content is mostly clear and scannable, but the nested sub-step under step 7 (expiration date details) introduces structural complexity that may confuse readers. The two standalone sentences added to the Monitor and Manage Cards section feel detached from the surrounding content.
  • AI Readiness: 8/10 - The new FAQ headings are descriptive and contain full feature names (What is a Single-use Expensify Card?), which is good for AI retrieval. YAML metadata was not updated to reflect the new features (no mention of single-use, expiration, or related keywords), which is a missed opportunity.
  • Style Compliance: 7/10 - The additions generally follow existing conventions. However, there are terminology and formatting inconsistencies that should be addressed.

Key Findings

Positive aspects:

  • The new FAQ entries are well-structured, self-contained, and answer exactly what the heading promises.
  • The limit type descriptions were improved for clarity (e.g., Monthly limit: Limit renews monthly is cleaner than the previous Capped monthly spend).
  • The Single-use card is clearly marked as (virtual only) in the step-by-step instructions, which is helpful.

Issues to address:

  1. Inconsistent terminology between authorization and transaction: The FAQ answer for What is a Single-use Expensify Card says after its first successful authorization, while the deactivation note in the Monitor section says completes its first successful transaction, and the limit type description says Expires after one transaction. These should use consistent language throughout.

  2. Step 7 formatting complexity: The expiration date sub-step mixes bullet points, a When enabled label, more bullets, and then an If no expiration sentence. This creates a deeply nested structure that may render inconsistently in Markdown and is harder to scan. Consider restructuring this as a simpler note or callout below the numbered steps.

  3. Deactivation notes placement: The two sentences about automatic deactivation (If a Single-use card completes its first successful transaction... and If a card reaches its expiration date...) appear after the image blocks in the Monitor section without a heading or visual grouping. They feel orphaned. Consider adding a sub-heading like Automatic deactivation or incorporating these into a bulleted list within the existing section flow.

  4. YAML keywords not updated: The keywords frontmatter still reads [New Expensify, Expensify Card setup, manage virtual card, card limits, Expensify Visa, card settings, Workspace Admin]. Adding terms like single-use card, card expiration, and virtual card expiration would improve discoverability for both search and AI retrieval.

  5. Fixed limit description change may reduce clarity: The old description One-time cap, card closes when reached was more explicit about the consequence. The new Spend until the limit is reached omits the fact that the card deactivates, which was useful information. Consider adding that detail back, e.g., Spend until the limit is reached, then the card deactivates.

  6. Minor style note: The feature bullet Individual Smart, Monthly, Fixed, or Single-use spend limits capitalizes all limit type names. While this matches how they appear as bold labels in the steps, elsewhere in the document (e.g., FAQ) they appear in mixed case. Ensure consistency in capitalization of feature names.

Recommendations

  1. High priority: Standardize the terminology for Single-use card deactivation triggers. Pick either authorization or transaction and use it consistently across the limit type description, the Monitor section note, and the FAQ answer.
  2. High priority: Update the YAML keywords array to include single-use card and card expiration for improved discoverability.
  3. Medium priority: Consider restructuring the expiration date sub-step (step 7) into a cleaner format -- perhaps a separate note block or a brief paragraph after the numbered list, rather than deeply nested bullets within a numbered step.
  4. Medium priority: Give the two deactivation sentences in the Monitor section a clearer visual anchor (a sub-heading or integration into the existing bullet list).
  5. Low priority: Restore the deactivation detail to the Fixed limit description for completeness.

Files Reviewed

  • docs/articles/new-expensify/expensify-card/Set-Up-and-Manage-the-Expensify-Card.md (+26/-5) -- Updates to feature list, Step 3 instructions, Monitor section, and two new FAQ entries for Single-use cards and expiration behavior.

Note: This review covers only the proposed changes in the diff, not the unchanged portions of the document.

@OSBotify
Copy link
Contributor

OSBotify commented Mar 11, 2026

A preview of your ExpensifyHelp changes have been deployed to https://head.helpdot.pages.dev ⚡️

Updated articles:

@zanyrenney
Copy link
Contributor

zanyrenney commented Mar 11, 2026

@stephanieelliott Please can I get your help on the images? I have them in another file but not sure if the process has changed or improved in the upload sitch so if you have a way to bulk do these with the borader helpsite updates, that would be amazing! https://github.com/Expensify/Expensify/issues/600202

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@stephanieelliott
Copy link
Contributor

@zanyrenney we just need the .png files from design to get these added! If you want, we just can merge this now and then I can come back to add the images when design shares them. Either way though, happy to add the images for you. I do have some quick shortcuts for doing it.

I approved the PR - you should be able to merge it if you'd like

@stephanieelliott stephanieelliott requested review from a team as code owners March 13, 2026 02:33
@melvin-bot melvin-bot bot requested review from joekaufmanexpensify and removed request for a team March 13, 2026 02:33
@melvin-bot
Copy link

melvin-bot bot commented Mar 13, 2026

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @twisterdotcom

@melvin-bot melvin-bot bot requested review from inimaga and twisterdotcom March 13, 2026 02:33
@melvin-bot
Copy link

melvin-bot bot commented Mar 13, 2026

@inimaga @twisterdotcom One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot removed the request for review from a team March 13, 2026 02:33
@stephanieelliott
Copy link
Contributor

@zanyrenney added images! FYI you con't be able to see them on the dev preview page but if you want to review, the images on the page should match their file names

@stephanieelliott stephanieelliott removed the request for review from joekaufmanexpensify March 13, 2026 03:01
@zanyrenney
Copy link
Contributor

Won't let me merge @stephanieelliott but thanks so much re the images!

@twisterdotcom twisterdotcom self-requested a review March 13, 2026 15:21
@twisterdotcom twisterdotcom merged commit ba5b420 into main Mar 13, 2026
13 of 15 checks passed
@twisterdotcom twisterdotcom deleted the claude-updateExpensifyCardDocs branch March 13, 2026 15:21
@melvin-bot melvin-bot bot added the Emergency label Mar 13, 2026
@melvin-bot
Copy link

melvin-bot bot commented Mar 13, 2026

@twisterdotcom looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/twisterdotcom in version: 9.3.38-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/cristipaval in version: 9.3.38-4 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants