Revert "83598: Remove TestDrive from sign-up flow"#85140
Merged
Conversation
melvin-bot
bot
requested review from
JmillsExpensify and
chuckdries
and removed request for
a team
|
@chuckdries Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
francoisl
approved these changes
Mar 12, 2026
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 94ffdf60b0
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| return true; | ||
| } | ||
|
|
||
| if (action.type === 'RESET' && action.payload) { |
There was a problem hiding this comment.
isNavigatingToTestDriveModal() only checks RESET payloads, but in-app Navigation.navigate(ROUTES.TEST_DRIVE_MODAL_ROOT.route) calls are dispatched as PUSH for static routes (see src/libs/Navigation/helpers/linkTo/index.ts, where NAVIGATE is rewritten to PUSH). In that common path, this guard will not recognize that the app is navigating to the modal, so the "dismissed modal" redirect logic is skipped and users can reopen a modal that should be blocked after dismissal.
Useful? React with 👍 / 👎.
Comment on lines
+118
to
+119
| if (onboardingInitialPath.includes(ROUTES.TEST_DRIVE_MODAL_ROOT.route)) { | ||
| return `/${ROUTES.TEST_DRIVE_MODAL_ROOT.route}`; |
There was a problem hiding this comment.
The new includes() check treats any path containing onboarding/test-drive as the modal route, which also matches ROUTES.TEST_DRIVE_DEMO_ROOT (onboarding/test-drive/demo). When onboardingInitialPath is the demo URL, this now rewrites it to /onboarding/test-drive, so users resuming that path are sent to the modal instead of the demo.
Useful? React with 👍 / 👎.
Contributor
|
🚧 @Valforte has triggered a test Expensify/App build. You can view the workflow run here. |
Contributor
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
Contributor
|
@Valforte please link the fixed issue in the future so we can better track blockers. I added it to the OP this time. |
OSBotify
pushed a commit
that referenced
this pull request
Mar 13, 2026
Revert "83598: Remove TestDrive from sign-up flow" (cherry picked from commit 1787f76) (cherry-picked to staging by luacmartins)
87 tasks
Contributor
|
🚀 Cherry-picked to staging by https://github.com/luacmartins in version: 9.3.37-1 🚀
|
51 tasks
Contributor
|
🚀 Deployed to production by https://github.com/cristipaval in version: 9.3.37-10 🚀
|
Contributor
|
🚀 Cherry-picked to staging by https://github.com/luacmartins in version: 9.3.38-0 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #83750
Fixed issues
$ #85162
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari