[No QA] Fix jest tests - job7 and job8 by MelvinBot · Pull Request #85147 · Expensify/App

MelvinBot · 2026-03-12T22:56:41Z

Explanation of Change

The __mocks__/react-native-permissions.ts mock file was importing RESULTS from react-native-permissions/dist/commonjs/permissions, but that sub-module only exports PERMISSIONS — not RESULTS. RESULTS is defined in a separate module (dist/commonjs/results), so it was always undefined at runtime in the mock.

This caused the flaky IOURequestStepConfirmationPageTest failure (TypeError: Cannot read properties of undefined (reading 'GRANTED')) that has been affecting multiple unrelated PRs on main.

Additionally, the mock's check() and request() functions returned plain strings instead of Promises, which doesn't match the real react-native-permissions API contract. This caused getLocationPermission().then(...) to crash with (...).then is not a function when the code path was hit.

This PR:

Defines RESULTS inline in the mock (with correct values and as const for type safety), avoiding the broken import
Wraps check() and request() return values in Promise.resolve() to match the real API

Fixed Issues

$ #85142
$ #85136
$ #85128
$ #85060

Tests

Run npx jest tests/ui/components/IOURequestStepConfirmationPageTest.tsx --no-cache
Verify all 13 tests pass, including "should route unreported distance expense to requestMoney and skip createDistanceRequest" which was previously failing
Run npx jest tests/ui/IOURequestStepScanTest.tsx tests/ui/NewChatPageTest.tsx tests/ui/AssignCardFeed.tsx --no-cache
Verify all tests in those files still pass (they also use the permissions mock)
Run npx eslint __mocks__/react-native-permissions.ts
Verify no lint errors (previously had 10 @typescript-eslint/no-unsafe-member-access errors due to undefined RESULTS)

Verify that no errors appear in the JS console

Offline tests

N/A — this change only affects test mocks, not runtime behavior.

QA Steps

[No QA] — this is a test infrastructure fix only. No production code is changed.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

N/A — test mock change only

Android: mWeb Chrome

N/A — test mock change only

iOS: Native

N/A — test mock change only

iOS: mWeb Safari

N/A — test mock change only

MacOS: Chrome / Safari

N/A — test mock change only

…romises The mock imported RESULTS from react-native-permissions/dist/commonjs/permissions, but that module only exports PERMISSIONS. RESULTS lives in a separate module (dist/commonjs/results), so it was always undefined at runtime. Additionally, the mock check() and request() functions returned plain strings instead of Promises, which doesn't match the real API contract and caused getLocationPermission().then() to fail. This fixes the flaky IOURequestStepConfirmationPageTest failure that has been affecting multiple unrelated PRs on main. Co-authored-by: Marc Glasser <marcaaron@users.noreply.github.com>

Add setNavigationActionToMicrotaskQueue to the Navigation mock (consistent with all other test files) and await batched updates after the button press so the async createTransaction → requestMoney call chain completes before the assertion runs. Co-authored-by: Marc Glasser <marcaaron@users.noreply.github.com>

MelvinBot · 2026-03-12T23:30:04Z

Fixed the failing test (job 7) check. Two issues in IOURequestStepConfirmationPageTest.tsx:

Missing setNavigationActionToMicrotaskQueue in Navigation mock — Jest resolves the iOS platform variant of navigateAfterInteraction, which calls Navigation.setNavigationActionToMicrotaskQueue(callback). The mock didn't include this function, causing TypeError: setNavigationActionToMicrotaskQueue is not a function. Added setNavigationActionToMicrotaskQueue: jest.fn((callback) => callback()) to match the pattern used in 16+ other test files.
Missing await after button press — The "unreported distance expense" test pressed the "Create expense" button and immediately asserted that IOU.requestMoney was called. However, the button press triggers React state updates that need to settle before the createTransaction → requestMoney call chain completes. Added await waitForBatchedUpdatesWithAct() after fireEvent.press() so the assertion runs after all updates have flushed.

All 13 tests in the file now pass.

melvin-bot · 2026-03-13T11:16:40Z

@ShridharGoel Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

MonilBhavsar · 2026-03-13T11:16:46Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

__mocks__/react-native-permissions.ts

…stead of defining inline Co-authored-by: Monil Bhavsar <MonilBhavsar@users.noreply.github.com>

melvin-bot · 2026-03-13T11:30:16Z

@eh2077 @rlinoz One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

rlinoz · 2026-03-13T11:34:45Z

Thanks for the PR, typecheck is failing though

The import from 'react-native-permissions/dist/commonjs/results' has no type declaration file, causing TS7016. Define the RESULTS object inline with 'as const' instead, which matches the runtime values and provides proper type safety. Co-authored-by: Monil Bhavsar <MonilBhavsar@users.noreply.github.com>

MelvinBot · 2026-03-13T11:38:26Z

Fixed the failing typecheck: The import of RESULTS from react-native-permissions/dist/commonjs/results had no type declaration file (TS7016). Replaced it with an inline as const object definition that provides the same values with proper type safety.

rlinoz · 2026-03-13T11:45:49Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

MonilBhavsar · 2026-03-13T11:53:28Z

Oh, jest8 is also broken 🤦

…MockAndLintThreshold Co-authored-by: Monil Bhavsar <MonilBhavsar@users.noreply.github.com>

Co-authored-by: Monil Bhavsar <MonilBhavsar@users.noreply.github.com>

MelvinBot · 2026-03-13T13:28:02Z

Fixed the failing Changed files ESLint check: removed unused waitForBatchedUpdates import in tests/ui/SessionTest.tsx (only waitForBatchedUpdatesWithAct is used in that file).

OSBotify · 2026-03-13T13:54:42Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-03-13T13:58:48Z

🚧 @rlinoz has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-03-13T14:03:11Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #85147.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-bbab135-59ef620-12bb30575c9076ae5ffd6804a4fc50300c00ef64/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-bbab135-59ef620-651f36cb8962680bd5bfcdbf24cbc22463a8c56c/index.html

Web 🕸️
https://85147.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-03-16T10:33:04Z

🚀 Deployed to staging by https://github.com/rlinoz in version: 9.3.38-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-03-17T11:29:10Z

🚀 Deployed to production by https://github.com/cristipaval in version: 9.3.38-4 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot assigned marcaaron Mar 12, 2026

MelvinBot requested a review from a team March 12, 2026 22:56

MelvinBot mentioned this pull request Mar 12, 2026

[Due for payment 2026-03-24] Investigate workflow job failing on main: test / test (job 7) #85142

Open

MonilBhavsar marked this pull request as ready for review March 13, 2026 11:16

melvin-bot bot requested review from ShridharGoel and removed request for a team March 13, 2026 11:16

MonilBhavsar reviewed Mar 13, 2026

View reviewed changes

__mocks__/react-native-permissions.ts Show resolved Hide resolved

MonilBhavsar self-assigned this Mar 13, 2026

Import RESULTS from react-native-permissions/dist/commonjs/results in…

efd10c8

…stead of defining inline Co-authored-by: Monil Bhavsar <MonilBhavsar@users.noreply.github.com>

MelvinBot requested a review from a team as a code owner March 13, 2026 11:30

melvin-bot bot requested review from eh2077 and rlinoz March 13, 2026 11:30

melvin-bot bot removed the request for review from a team March 13, 2026 11:30

MonilBhavsar previously approved these changes Mar 13, 2026

View reviewed changes

MelvinBot dismissed MonilBhavsar’s stale review via 56fb0a0 March 13, 2026 11:38

rlinoz removed request for ShridharGoel and eh2077 March 13, 2026 11:45

rlinoz previously approved these changes Mar 13, 2026

View reviewed changes

This comment was marked as outdated.

Sign in to view

MarioExpensify previously approved these changes Mar 13, 2026

View reviewed changes

Wait for render before asserting

4f689c6

MonilBhavsar dismissed stale reviews from MarioExpensify and rlinoz via 4f689c6 March 13, 2026 13:24

Merge remote-tracking branch 'origin/main' into claude-fixPermissions…

bb419b0

…MockAndLintThreshold Co-authored-by: Monil Bhavsar <MonilBhavsar@users.noreply.github.com>

This comment was marked as outdated.

Sign in to view

Fix: remove unused waitForBatchedUpdates import in SessionTest

3e18337

Co-authored-by: Monil Bhavsar <MonilBhavsar@users.noreply.github.com>

This comment was marked as outdated.

Sign in to view

MonilBhavsar changed the title ~~Fix react-native-permissions mock to resolve flaky test failures on main~~ Fix jest tests - job7 and job8 Mar 13, 2026

rlinoz approved these changes Mar 13, 2026

View reviewed changes

MarioExpensify approved these changes Mar 13, 2026

View reviewed changes

rlinoz merged commit bbab135 into main Mar 13, 2026
31 of 32 checks passed

rlinoz deleted the claude-fixPermissionsMockAndLintThreshold branch March 13, 2026 13:46

rlinoz mentioned this pull request Mar 13, 2026

[Due for payment 2026-03-24] Investigate workflow job failing on main: test / test (job 7) #85060

Closed

MonilBhavsar changed the title ~~Fix jest tests - job7 and job8~~ [No QA] Fix jest tests - job7 and job8 Mar 13, 2026

inimaga mentioned this pull request Mar 13, 2026

Pass userBillingGracePeriods to shouldRestrictUserBillableActions in ReportChangeWorkspacePage #85028

Merged

52 tasks

MelvinBot mentioned this pull request Mar 13, 2026

Investigate workflow job failing on main: test / test (job 7) #85235

Closed

tgolen mentioned this pull request Mar 13, 2026

[Due for payment 2026-03-25] Investigate workflow job failing on main: test / test (job 7) #85243

Open

huult mentioned this pull request Mar 16, 2026

[No QA] Fix flaky IOURequestStepConfirmationPageTest by mocking getCurrentPosition #85316

Open

53 tasks

OSBotify mentioned this pull request Mar 16, 2026

Deploy Checklist: New Expensify 2026-03-16 #85347

Closed

74 tasks

This was referenced Mar 17, 2026

[Due for payment 2026-03-24] Investigate workflow job failing on main: test / test (job 7) #85136

Closed

[Due for payment 2026-03-24] Investigate workflow job failing on main: test / test (job 7) #85128

Open

Conversation

MelvinBot commented Mar 12, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

MelvinBot commented Mar 12, 2026

Uh oh!

melvin-bot bot commented Mar 13, 2026

Uh oh!

MonilBhavsar commented Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

melvin-bot bot commented Mar 13, 2026

Uh oh!

rlinoz commented Mar 13, 2026

Uh oh!

MelvinBot commented Mar 13, 2026

Uh oh!

rlinoz commented Mar 13, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

MonilBhavsar commented Mar 13, 2026

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

MelvinBot commented Mar 13, 2026

Uh oh!

This comment was marked as outdated.

Uh oh!

OSBotify commented Mar 13, 2026

Uh oh!

github-actions bot commented Mar 13, 2026

Uh oh!

github-actions bot commented Mar 13, 2026

Uh oh!

OSBotify commented Mar 16, 2026

Uh oh!

OSBotify commented Mar 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

MonilBhavsar commented Mar 13, 2026 •

edited

Loading