[No QA] Update reviewer bot to reference helpsite governance files #85172
[No QA] Update reviewer bot to reference helpsite governance files #85172mjasikowski merged 7 commits intomainfrom
Conversation
|
A preview of your ExpensifyHelp changes have been deployed to https://25e8292d.helpdot.pages.dev ⚡️ Updated articles: |
HelpDot Documentation ReviewOverall AssessmentThis PR has two distinct parts: (1) updates to the reviewer bot agents and workflow configuration to reference centralized governance files, and (2) a new test article ( Scores Summary (fake-article.md only)
Key FindingsGovernance file violations in fake-article.md (by category): Heading violations (HELP_AUTHORING_GUIDELINES.md Section 2):
Metadata violations (HELP_AUTHORING_GUIDELINES.md Section 3, TEMPLATE.md):
Terminology violations (HELPSITE_NAMING_CONVENTIONS.md):
UI referencing violations (HELPSITE_NAMING_CONVENTIONS.md):
Navigation violations (HELPSITE_NAMING_CONVENTIONS.md - Prohibited Language):
Cross-linking violations (HELP_AUTHORING_GUIDELINES.md Section 7):
Positive aspects of the agent/workflow changes:
Recommendations
Files Reviewed
Note: Scoring applies only to the documentation content in fake-article.md. The agent configuration and workflow changes are well-structured and do not require scoring. |
|
Removing test comment - please ignore |
|
(test comment - please disregard) |
HelpDot Inline Review:
|
Remove adjustments made for testing
|
@mjasikowski Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/mjasikowski in version: 9.3.38-0 🚀
|
|
🚀 Deployed to production by https://github.com/cristipaval in version: 9.3.38-4 🚀
|
Explanation of Change
Update helpdot reviewer prompt to replace the static rules and point to help site governance files instead.
I tested these changes on a fake file to confirm this works, see this comment for results: #85172 (comment)
Fixed Issues
$ none
PROPOSAL:
Tests
###headings and includespolicyfor example)I tested this already on this branch to confirm it works correctly: #85172 (comment)
Offline tests
N/A
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos