migrate REPORT_SETTINGS_NOTIFICATION_PREFERENCES by huult · Pull Request #85308 · Expensify/App

huult · 2026-03-15T16:18:12Z

Explanation of Change

Fixed Issues

$ #83368
PROPOSAL:

Tests

Same QA step

Verify that no errors appear in the JS console

Offline tests

QA Steps

Case 1:

Open the Expensify app.
Open a room chat or create a new room (FAB → Start Chat → Room tab → Save).
Tap the room header to open the room details.
Open Settings → Tap Notify me about new messages.
Verify that the Notification preferences setting opens correctly and that navigating back works normally.

Case 2:

Open the Expensify app.
Create an expense with another user (User A creates an expense with User B).
Tap the room header to open the room details.
Open Settings → Tap Notify me about new messages.
Verify that the Notification preferences setting opens correctly and that navigating back works normally.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

melvin-bot · 2026-03-15T16:18:19Z

@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 98ee341e22

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-03-15T16:29:44Z

src/pages/ProfilePage.tsx

                                title={notificationPreference}
                                description={translate('notificationPreferencesPage.label')}
-                                onPress={() => Navigation.navigate(ROUTES.REPORT_SETTINGS_NOTIFICATION_PREFERENCES.getRoute(report.reportID, navigateBackTo))}
+                                onPress={() => Navigation.navigate(createDynamicRoute(DYNAMIC_ROUTES.NOTIFICATION_PREFERENCES.path))}


Open notification preferences via report-settings route

This now appends notification-preferences to the current ProfilePage URL, so from a profile route (a/:accountID) it generates a/<accountID>/notification-preferences. That path is not registered for the notification-preferences screen (it is configured under report settings), so tapping this menu item from ProfilePage lands on an unresolved route instead of opening the report notification preference UI.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-03-15T16:29:44Z

src/pages/settings/Report/DynamicNotificationPreferencePage.tsx

            keyForList: preference,
            isSelected: preference === currentNotificationPreference,
        }));
+    const backPath = useDynamicBackPath(DYNAMIC_ROUTES.ADDRESS_COUNTRY.path);


Use the notification suffix when deriving back path

This page derives backPath with ADDRESS_COUNTRY.path (country) instead of the page’s own notification-preferences suffix. useDynamicBackPath() only removes the suffix when it matches the current URL tail, so on this screen it returns the current path unchanged; as a result, Navigation.goBack(backPath) targets the same route and the back action (including after selecting an option) fails to leave the screen.

Useful? React with 👍 / 👎.

codecov · 2026-03-15T16:48:42Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/SCREENS.ts	`100.00% <ø> (ø)`
src/libs/Navigation/linkingConfig/config.ts	`76.92% <ø> (ø)`
src/pages/ProfilePage.tsx	`0.00% <ø> (ø)`
src/pages/inbox/report/withReportOrNotFound.tsx	`97.05% <ø> (ø)`
...tings/Report/DynamicNotificationPreferencePage.tsx	`0.00% <ø> (ø)`
src/pages/settings/Report/ReportSettingsPage.tsx	`0.00% <ø> (ø)`
src/ROUTES.ts	`15.70% <0.00%> (ø)`
...gation/AppNavigator/ModalStackNavigators/index.tsx	`6.95% <0.00%> (ø)`
... and 10 files with indirect coverage changes

…T_SETTINGS_NOTIFICATION_PREFERENCES

huult · 2026-03-16T01:42:02Z

Screen.Recording.2026-03-16.at.08.40.44.mov

@collectioneur I encountered this issue. I think it’s the same as the one we discussed previously. I just wanted to inform you so you’re aware.
This issue occurs because we don’t include the report ID in the parameters. When we navigate to DynamicNotificationPreferencePage, the withReportOrNotFound check runs and shows the Not Found page.

JmillsExpensify

Part of an existing initiative. LGTM.

collectioneur · 2026-03-16T15:15:15Z

@huult The PR for parameter propagation has already hit staging, so everything should be working now 👍

…T_SETTINGS_NOTIFICATION_PREFERENCES

huult · 2026-03-27T01:34:18Z

@mananjadhav This PR is ready for review

mananjadhav · 2026-03-29T18:37:18Z

@huult Can you resolve the conflicts please?

mananjadhav · 2026-03-29T19:18:11Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android-bt-notif.mov

Android: mWeb Chrome

mweb-chrome-bt-notify.mov

iOS: HybridApp

iOS: mWeb Safari

mweb-safari-bt-notif.mov

MacOS: Chrome / Safari

web-bt-notif.mov

mananjadhav

Issues with my iOS remote build but tested on all platforms. Good to merge when the conflicts are resolved.

…T_SETTINGS_NOTIFICATION_PREFERENCES

huult · 2026-03-30T01:39:39Z

@huult Can you resolve the conflicts please?

@mananjadhav Resolved!

…T_SETTINGS_NOTIFICATION_PREFERENCES

github-actions · 2026-04-07T08:12:31Z

🚧 @mjasikowski has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-04-07T08:16:56Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #85308.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-2c5fc05-9989e33-a98ffdfe333746a87bc0772e3839ec9c1ea26da1/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-2c5fc05-9989e33-51ed0e6adc837b8e64e39c31982ee161ec245899/index.html

Web 🕸️
https://85308.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-04-07T08:22:21Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-04-08T00:18:30Z

🚀 Deployed to staging by https://github.com/mjasikowski in version: 9.3.54-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-04-08T00:20:43Z

No help site changes are required for this PR.

This is a purely internal navigation refactor — it migrates the REPORT_SETTINGS_NOTIFICATION_PREFERENCES route to use the dynamic route pattern (renaming NotificationPreferencePage → DynamicNotificationPreferencePage and updating route definitions). No user-facing features, labels, settings names, or behavior changed.

mitarachim · 2026-04-08T00:53:49Z

Deploy Blocker #87302 was identified to be related to this PR.

migrate REPORT_SETTINGS_NOTIFICATION_PREFERENCES

98ee341

huult requested review from a team as code owners March 15, 2026 16:18

melvin-bot bot assigned huult Mar 15, 2026

melvin-bot bot requested review from JmillsExpensify and mananjadhav and removed request for a team March 15, 2026 16:18

chatgpt-codex-connector bot reviewed Mar 15, 2026

View reviewed changes

huult added 2 commits March 16, 2026 07:45

Merge remote-tracking branch 'upstream/main' into 83368-migrate-REPOR…

1b6c864

…T_SETTINGS_NOTIFICATION_PREFERENCES

update route path

851c6b4

JmillsExpensify previously approved these changes Mar 16, 2026

View reviewed changes

Merge remote-tracking branch 'upstream/main' into 83368-migrate-REPOR…

f1e24d2

…T_SETTINGS_NOTIFICATION_PREFERENCES

huult dismissed JmillsExpensify’s stale review via f1e24d2 March 20, 2026 02:12

huult added 2 commits March 23, 2026 10:46

Merge remote-tracking branch 'upstream/main' into 83368-migrate-REPOR…

8bc2ed3

…T_SETTINGS_NOTIFICATION_PREFERENCES

synced on main

698b9e7

mananjadhav reviewed Mar 29, 2026

View reviewed changes

Merge remote-tracking branch 'upstream/main' into 83368-migrate-REPOR…

73c2c9e

…T_SETTINGS_NOTIFICATION_PREFERENCES

huult added 2 commits April 1, 2026 08:55

Merge remote-tracking branch 'upstream/main' into 83368-migrate-REPOR…

df30fc7

…T_SETTINGS_NOTIFICATION_PREFERENCES

Merge remote-tracking branch 'upstream/main' into 83368-migrate-REPOR…

e52df77

…T_SETTINGS_NOTIFICATION_PREFERENCES

mananjadhav approved these changes Apr 3, 2026

View reviewed changes

melvin-bot bot requested a review from mjasikowski April 3, 2026 20:18

mjasikowski approved these changes Apr 7, 2026

View reviewed changes

mjasikowski merged commit 2c5fc05 into Expensify:main Apr 7, 2026
32 checks passed

OSBotify mentioned this pull request Apr 7, 2026

Deploy Checklist: New Expensify 2026-04-07 #87294

Open

65 tasks

mitarachim mentioned this pull request Apr 8, 2026

Chat - "Notify me about new messages" opens not here page #87302

Open

7 tasks

mitarachim mentioned this pull request Apr 8, 2026

[BT-131] Migrate Reports - Core (Part 3) #83368

Open

5 tasks

Conversation

huult commented Mar 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Mar 15, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Mar 15, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot Mar 15, 2026

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Mar 15, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

huult commented Mar 16, 2026

Uh oh!

JmillsExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

collectioneur commented Mar 16, 2026

Uh oh!

huult commented Mar 27, 2026

Uh oh!

mananjadhav commented Mar 29, 2026

Uh oh!

mananjadhav commented Mar 29, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

mananjadhav left a comment

Choose a reason for hiding this comment

Uh oh!

huult commented Mar 30, 2026

Uh oh!

Uh oh!

github-actions bot commented Apr 7, 2026

Uh oh!

github-actions bot commented Apr 7, 2026

Uh oh!

OSBotify commented Apr 7, 2026

Uh oh!

OSBotify commented Apr 8, 2026

Uh oh!

MelvinBot commented Apr 8, 2026

Uh oh!

mitarachim commented Apr 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

huult commented Mar 15, 2026 •

edited

Loading

codecov bot commented Mar 15, 2026 •

edited by github-actions bot

Loading