Add useIsInSidePanel context hook to replace prop drilling by adhorodyski · Pull Request #85355 · Expensify/App

adhorodyski · 2026-03-16T10:41:57Z

Explanation of Change

Introduces a useIsInSidePanel React context hook to replace isInSidePanel prop drilling throughout the report screen hierarchy.

A new IsInSidePanelContext is created in src/hooks/useIsInSidePanel.ts and its provider is added to SidePanelReport in src/components/SidePanel/SidePanelReport/index.tsx. Any component rendered inside the side panel can now call useIsInSidePanel() directly instead of receiving isInSidePanel as a prop passed down through intermediate components.

The existing isInSidePanel prop is kept intact for backward compatibility. A follow-up PR will migrate consumers to use the hook and remove the prop.

This is PR 1 of a series decomposing ReportScreen. Part of #84971.

Fixed Issues

$ #84895
PROPOSAL:

Tests

Go to Search > Open a report
Open the expense in the report
Verify everything looks correct (both in and outside of the side panel should yield the same correct layout rendering)

Offline tests

N/A

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Introduce an IsInSidePanelContext and useIsInSidePanel hook that allows descendants to query whether they're rendered inside a side panel without prop drilling. SidePanelReport wraps its children with the provider. The existing isInSidePanel prop is kept for backward compatibility and will be removed in a follow-up PR that switches consumers to the hook. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

codecov · 2026-03-16T10:55:28Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/hooks/useIsInSidePanel.ts	`100.00% <100.00%> (ø)`
src/pages/inbox/HeaderView.tsx	`97.82% <100.00%> (ø)`
src/pages/inbox/ReportScreen.tsx	`71.05% <100.00%> (+0.06%)`	⬆️
...report/ReportActionCompose/ReportActionCompose.tsx	`68.77% <100.00%> (ø)`
src/pages/inbox/report/ReportFooter.tsx	`53.57% <ø> (ø)`
src/components/SidePanel/SidePanelReport/index.tsx	`0.00% <0.00%> (ø)`
... and 20 files with indirect coverage changes

Introduce an IsInSidePanelContext and useIsInSidePanel hook so that any descendant can query whether it is rendered inside the side panel without prop drilling through ReportScreen → HeaderView / ReportFooter → ReportActionCompose. SidePanelReport wraps its children with the context provider. All four consumers (ReportScreen, HeaderView, ReportFooter, ReportActionCompose) now call useIsInSidePanel() directly instead of receiving the prop. The Report/index.ts action-layer isInSidePanel parameter is a separate concern and is not changed by this commit. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

melvin-bot · 2026-03-16T11:12:37Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

rlinoz · 2026-03-16T12:07:34Z

Very simple, love it

rlinoz · 2026-03-16T12:09:42Z

@adhorodyski let's remove the NO QA though, I think steps could be

Go to Search > Open a report
Open the expense in the report
Verify everything looks correct

adhorodyski · 2026-03-16T12:43:06Z

updated the test steps thanks

DylanDylann · 2026-03-16T16:45:00Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-03-16.at.23.53.03.mov

Android: mWeb Chrome

Screen.Recording.2026-03-16.at.23.52.03.mov

iOS: HybridApp

Screen.Recording.2026-03-16.at.23.52.42.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-03-16.at.23.49.11.mov

DylanDylann

LGTM

github-actions · 2026-03-16T16:53:54Z

🚧 @rlinoz has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-03-16T16:58:45Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #85355.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-ca59f96-a6a9d5f-67aff241e9e59e4d00ddfc2b8c090bc34471907d/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-ca59f96-a6a9d5f-ae8cd9cb4d9c28b1b0240dd3d59fc01738f396e8/index.html

Web 🕸️
https://85355.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-03-16T17:04:30Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-03-17T11:57:08Z

🚀 Deployed to staging by https://github.com/rlinoz in version: 9.3.39-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-03-18T13:04:14Z

🚀 Deployed to production by https://github.com/cristipaval in version: 9.3.39-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

melvin-bot bot assigned adhorodyski Mar 16, 2026

adhorodyski marked this pull request as ready for review March 16, 2026 11:12

adhorodyski requested review from a team as code owners March 16, 2026 11:12

melvin-bot bot requested review from DylanDylann and removed request for a team March 16, 2026 11:12

melvin-bot bot requested review from heyjennahay and removed request for a team March 16, 2026 11:12

rlinoz approved these changes Mar 16, 2026

View reviewed changes

adhorodyski changed the title ~~[No QA] Add useIsInSidePanel context hook to replace prop drilling~~ Add useIsInSidePanel context hook to replace prop drilling Mar 16, 2026

DylanDylann approved these changes Mar 16, 2026

View reviewed changes

melvin-bot bot requested a review from rlinoz March 16, 2026 16:50

rlinoz approved these changes Mar 16, 2026

View reviewed changes

rlinoz merged commit ca59f96 into Expensify:main Mar 16, 2026
46 of 47 checks passed

OSBotify mentioned this pull request Mar 17, 2026

Deploy Checklist: New Expensify 2026-03-17 #85529

Closed

75 tasks

adhorodyski mentioned this pull request Mar 17, 2026

[HOLD] Consolidate AgentZero status into a Context #85535

Open

51 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add useIsInSidePanel context hook to replace prop drilling#85355

Add useIsInSidePanel context hook to replace prop drilling#85355
rlinoz merged 2 commits intoExpensify:mainfrom
callstack-internal:decompose/use-is-in-side-panel

adhorodyski commented Mar 16, 2026 •

edited

Loading

Uh oh!

codecov bot commented Mar 16, 2026 •

edited by github-actions bot

Loading

Uh oh!

melvin-bot bot commented Mar 16, 2026

Uh oh!

rlinoz commented Mar 16, 2026

Uh oh!

rlinoz commented Mar 16, 2026

Uh oh!

adhorodyski commented Mar 16, 2026

Uh oh!

DylanDylann commented Mar 16, 2026 •

edited

Loading

Uh oh!

DylanDylann left a comment

Uh oh!

Uh oh!

github-actions bot commented Mar 16, 2026

Uh oh!

github-actions bot commented Mar 16, 2026

Uh oh!

OSBotify commented Mar 16, 2026

Uh oh!

OSBotify commented Mar 17, 2026

Uh oh!

OSBotify commented Mar 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

adhorodyski commented Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Mar 16, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot bot commented Mar 16, 2026

Uh oh!

rlinoz commented Mar 16, 2026

Uh oh!

rlinoz commented Mar 16, 2026

Uh oh!

adhorodyski commented Mar 16, 2026

Uh oh!

DylanDylann commented Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

DylanDylann left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Mar 16, 2026

Uh oh!

github-actions bot commented Mar 16, 2026

Uh oh!

OSBotify commented Mar 16, 2026

Uh oh!

OSBotify commented Mar 17, 2026

Uh oh!

OSBotify commented Mar 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

adhorodyski commented Mar 16, 2026 •

edited

Loading

codecov bot commented Mar 16, 2026 •

edited by github-actions bot

Loading

DylanDylann commented Mar 16, 2026 •

edited

Loading