Skip to content

Prevent keyboard from appearing over splash screen on iOS app reopen#85396

Draft
MelvinBot wants to merge 1 commit intomainfrom
claude-keyboardOverSplashScreenOnReopen
Draft

Prevent keyboard from appearing over splash screen on iOS app reopen#85396
MelvinBot wants to merge 1 commit intomainfrom
claude-keyboardOverSplashScreenOnReopen

Conversation

@MelvinBot
Copy link
Copy Markdown
Contributor

@MelvinBot MelvinBot commented Mar 16, 2026

Explanation of Change

When the iOS app is reopened after being backgrounded on a screen with a focused input (DM composer or Magic Code screen), the keyboard appears on top of the system splash/transition screen before the app finishes loading. This creates a jarring visual experience, especially on slower devices.

Three changes address this:

  1. iOS-specific isWindowReadyToFocus (src/libs/isWindowReadyToFocus/index.ios.ts): Mirrors the existing Android implementation. Listens for AppState changes and creates a blocking promise when the app goes to background/inactive, which only resolves when the app transitions back to active. All code paths that already call isWindowReadyToFocus() (including focusComposerWithDelay and useAutoFocusInput) automatically gain iOS protection.

  2. Global Keyboard.dismiss() on foreground transition (src/Expensify.tsx): An iOS-only AppState listener dismisses the keyboard when the app transitions from inactive/background to active. This handles the native UIKit first responder restoration that happens independently of React-level focus calls.

  3. Gate Magic Code focus (BaseValidateCodeForm.tsx): Wraps the focusLastSelected() call inside useFocusEffect with isWindowReadyToFocus(), preventing premature keyboard display during the background-to-foreground transition on the Magic Code screen.

Fixed Issues

$ #84324
PROPOSAL: #84324 (comment)

Tests

  1. On iOS, open a DM conversation so the composer is focused and keyboard is visible

  2. Background the app (swipe up to go home)

  3. Reopen the app

  4. Verify the keyboard does NOT appear over the splash/transition screen

  5. Verify the keyboard appears only after the app finishes loading the screen

  6. On iOS, navigate to a Magic Code screen (e.g., Biometric test on Troubleshoot page)

  7. Background the app

  8. Reopen the app

  9. Verify the keyboard does NOT flash over the splash screen

  10. On iOS, reopen the app from a screen without a focused input

  11. Verify no keyboard appears at all

  12. On Android, open a DM conversation and background/reopen the app

  13. Verify the composer still refocuses correctly (no regression)

  14. On Web, verify composer focus behavior is unchanged

  • Verify that no errors appear in the JS console

Offline tests

N/A — This change only affects keyboard focus timing during background-to-foreground transitions and does not involve network operations.

QA Steps

  1. On an iOS device, open the app and navigate to a DM screen so the keyboard is showing

  2. Background the app (press Home or swipe up)

  3. Reopen the app

  4. Verify the splash/transition screen appears without the keyboard overlapping it

  5. Verify the keyboard appears only after the app has fully loaded

  6. Navigate to a Magic Code screen, background the app, then reopen

  7. Verify the keyboard does not flash over the splash screen

  8. On Android, repeat steps 1-5 and verify no regression in composer focus behavior

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

N/A — No visual changes on Android, existing behavior preserved

Android: mWeb Chrome

N/A — Changes are iOS-native only

iOS: Native

iOS-specific fix — keyboard no longer appears over splash/transition screen on app reopen

iOS: mWeb Safari

N/A — Changes are iOS-native only

MacOS: Chrome / Safari

N/A — Changes are iOS-native only

@MelvinBot @aimane-chnaif
Prevent keyboard from appearing over splash screen on iOS app reopen
d508dce 
Add iOS-specific isWindowReadyToFocus implementation that blocks focus
operations during background-to-foreground transitions, add global
Keyboard.dismiss() on iOS foreground transition, and gate Magic Code
input focus with isWindowReadyToFocus.

Co-authored-by: Aimane Chnaif <aimane-chnaif@users.noreply.github.com>
@MelvinBot MelvinBot requested a review from a team March 16, 2026 12:09
@MelvinBot MelvinBot mentioned this pull request Mar 16, 2026
Open
7 tasks
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 16, 2026 •
edited by github-actions bot
Loading

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
...ionModal/ValidateCodeForm/BaseValidateCodeForm.tsx 87.30% <100.00%> (ø)
src/Expensify.tsx 86.50% <62.50%> (-1.63%) ⬇️
src/libs/isWindowReadyToFocus/index.ios.ts 25.00% <25.00%> (ø)
... and 15 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@aimane-chnaif aimane-chnaif

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MelvinBot @aimane-chnaif