Dismiss keyboard on empty workspace Room tab to reveal Learn more button#85481
Draft
Dismiss keyboard on empty workspace Room tab to reveal Learn more button#85481
Conversation
When a user with no workspaces navigates to FAB > Start chat > Room, the keyboard from the previous tab persists on iOS because the KeyboardAvoidingView is disabled for the empty workspace state. This causes the "Learn more" button to be hidden behind the keyboard. Add a useEffect in EmptyWorkspaceView that calls Keyboard.dismiss() on mount, since there are no input fields in this state and the keyboard serves no purpose. Co-authored-by: Chavda Sachin <ChavdaSachin@users.noreply.github.com>
Contributor
Author
|
I created this PR from an upstream branch since I don't have push access to your fork. To take ownership of this branch and be able to push updates, run: Then you can close this PR and open a new one from your fork. |
7 tasks
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
When a user with no workspaces navigates to FAB > Start chat > Room, the keyboard from the previous "Chat" tab persists on iOS. Because
shouldEnableKeyboardAvoidingViewis disabled for the empty workspace state (workspaceOptions.length === 0), the layout doesn't adjust and the "Learn more" button gets pushed below the visible viewport, hidden behind the keyboard.This PR dismisses the keyboard when the
EmptyWorkspaceViewcomponent mounts by adding auseEffectthat callsKeyboard.dismiss(). Since there are no input fields in the empty workspace state, the keyboard serves no purpose and should be dismissed.Fixed Issues
$ #84526
PROPOSAL: #84526 (comment)
Tests
Offline tests
N/A — This is a keyboard dismissal fix that doesn't involve network requests.
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Web