Replace FullscreenLoadingIndicator with ActivityIndicator in PhoneNumberPage by MelvinBot · Pull Request #85515 · Expensify/App

MelvinBot · 2026-03-17T09:02:15Z

Explanation of Change

Replaces FullscreenLoadingIndicator with a View + ActivityIndicator in PhoneNumberPage.tsx.

PhoneNumberPage renders HeaderWithBackButton and FullscreenLoadingIndicator as siblings. As part of the loading indicator standardization (preparing to enable shouldUseGoBackButton by default), this would result in two back controls. Since the header already provides navigation, FullscreenLoadingIndicator is unnecessary — a plain ActivityIndicator wrapped in a styled View is sufficient.

The replacement View replicates the exact styles from FullscreenLoadingIndicator's fullScreenLoading style: componentBG background color, 0.8 opacity, and centered layout. This follows the same pattern already applied in ProfilePage.tsx.

Fixed Issues

$ #84989
PROPOSAL: #84989 (comment)

Tests

Open the app and navigate to Settings > Profile > Phone Number
Verify the loading spinner appears centered with the correct background while data loads
Once loaded, verify the phone number form displays correctly
Verify no console errors appear

Verify that no errors appear in the JS console

Offline tests

Turn off network, navigate to Settings > Profile > Phone Number
Verify the page loads from cache or shows appropriate offline state
Turn network back on and verify normal behavior resumes

QA Steps

Navigate to Settings > Profile > Phone Number
Verify the loading spinner appears centered with the correct background while data loads
Once loaded, verify the phone number form works correctly (can edit and save phone number)
Verify no visual regressions compared to previous behavior

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

…berPage PhoneNumberPage renders HeaderWithBackButton and FullscreenLoadingIndicator as siblings. When shouldUseGoBackButton becomes the default, users would see two back controls. Replace with View + ActivityIndicator to avoid the conflict while preserving the same visual appearance. Co-authored-by: Situ Chandra Shil <situchan@users.noreply.github.com>

Co-authored-by: Situ Chandra Shil <situchan@users.noreply.github.com>

MelvinBot · 2026-03-17T09:04:57Z

Fixed the failing Prettier check: the style prop on the View in PhoneNumberPage.tsx needed line-breaking to satisfy Prettier formatting rules.

codecov · 2026-03-17T09:12:13Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...ttings/Profile/PersonalDetails/PhoneNumberPage.tsx	`0.00% <ø> (ø)`
... and 6 files with indirect coverage changes

situchan · 2026-03-17T10:00:58Z

src/pages/settings/Profile/PersonalDetails/PhoneNumberPage.tsx

-                        reasonAttributes={{context: 'PhoneNumberPage', isLoadingApp} satisfies SkeletonSpanReasonAttributes}
-                    />
+                    <View
+                        style={[styles.flex1, styles.pRelative, styles.justifyContentCenter, styles.alignItemsCenter, StyleUtils.getBackgroundColorStyle(theme.componentBG), {opacity: 0.8}]}


@MelvinBot we already have defined style - fullScreenLoading. Apply same fix as #84798

<View style={[styles.flex1, styles.fullScreenLoading]}>

Applied — replaced the inline styles with styles.fullScreenLoading and removed the now-unused useStyleUtils and useTheme imports.

Co-authored-by: Situ Chandra Shil <situchan@users.noreply.github.com>

situchan · 2026-03-17T10:05:01Z

@MelvinBot mark as ready for review

MelvinBot · 2026-03-17T10:06:37Z

Marked as ready for review! ✅

melvin-bot · 2026-03-17T10:06:38Z

@situchan Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

situchan · 2026-03-17T10:18:43Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

joekaufmanexpensify

Good for product

Julesssss

Good test cases, thanks!

github-actions · 2026-03-17T23:45:06Z

🚧 @Julesssss has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-03-17T23:49:39Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #85515.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-e9cb70c-84e475f-77d09b73609720c3600ee9a5e3eae06352e51080/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-e9cb70c-84e475f-504ddab03ed9b6fbb0e6cb65555a77d56cfbdb77/index.html

Web 🕸️
https://85515.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-03-17T23:51:49Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-03-18T13:31:00Z

🚀 Deployed to staging by https://github.com/Julesssss in version: 9.3.40-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

OSBotify · 2026-03-18T14:07:01Z

🚀 Deployed to staging by https://github.com/Julesssss in version: 9.3.40-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot assigned situchan Mar 17, 2026

MelvinBot requested a review from a team March 17, 2026 09:02

MelvinBot mentioned this pull request Mar 17, 2026

[$125] Use valid loading indicator in PhoneNumberPage.tsx #84989

Open

Fix: run Prettier on PhoneNumberPage

3bcfa35

Co-authored-by: Situ Chandra Shil <situchan@users.noreply.github.com>

situchan reviewed Mar 17, 2026

View reviewed changes

Use fullScreenLoading style instead of inline styles

a1190d7

Co-authored-by: Situ Chandra Shil <situchan@users.noreply.github.com>

MelvinBot marked this pull request as ready for review March 17, 2026 10:06

MelvinBot requested a review from a team as a code owner March 17, 2026 10:06

melvin-bot bot requested a review from situchan March 17, 2026 10:06

melvin-bot bot requested review from joekaufmanexpensify and removed request for a team March 17, 2026 10:06

melvin-bot bot removed the request for review from a team March 17, 2026 10:06

situchan approved these changes Mar 17, 2026

View reviewed changes

melvin-bot bot requested a review from Julesssss March 17, 2026 10:19

joekaufmanexpensify approved these changes Mar 17, 2026

View reviewed changes

Julesssss reviewed Mar 17, 2026

View reviewed changes

Julesssss approved these changes Mar 17, 2026

View reviewed changes

Julesssss merged commit e9cb70c into main Mar 17, 2026
42 of 43 checks passed

Julesssss deleted the claude-useActivityIndicatorInPhoneNumberPage branch March 17, 2026 23:44

OSBotify mentioned this pull request Mar 18, 2026

Deploy Checklist: New Expensify 2026-03-18 #85646

Open

86 tasks

Conversation

MelvinBot commented Mar 17, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

MelvinBot commented Mar 17, 2026

Uh oh!

codecov bot commented Mar 17, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

situchan Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MelvinBot Mar 17, 2026

Choose a reason for hiding this comment

Uh oh!

situchan commented Mar 17, 2026

Uh oh!

MelvinBot commented Mar 17, 2026

Uh oh!

melvin-bot bot commented Mar 17, 2026

Uh oh!

situchan commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

joekaufmanexpensify left a comment

Choose a reason for hiding this comment

Uh oh!

Julesssss left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Mar 17, 2026

Uh oh!

github-actions bot commented Mar 17, 2026

Uh oh!

OSBotify commented Mar 17, 2026

Uh oh!

OSBotify commented Mar 18, 2026

Uh oh!

OSBotify commented Mar 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov bot commented Mar 17, 2026 •

edited by github-actions bot

Loading

situchan Mar 17, 2026 •

edited

Loading

situchan commented Mar 17, 2026 •

edited

Loading