Skip to content

[CP Staging] Revert "[Onyx audit] Migrate keys to RAM-only - part 1/2"#85555

Merged
mountiny merged 1 commit intomainfrom
revert-82309-JKobrynski/feat/80091-migrate-keys-to-ram-only-part-1
Mar 17, 2026
Merged

[CP Staging] Revert "[Onyx audit] Migrate keys to RAM-only - part 1/2"#85555
mountiny merged 1 commit intomainfrom
revert-82309-JKobrynski/feat/80091-migrate-keys-to-ram-only-part-1

Conversation

@mountiny
Copy link
Contributor

@mountiny mountiny self-assigned this Mar 17, 2026
@mountiny mountiny requested review from a team as code owners March 17, 2026 15:33
@melvin-bot melvin-bot bot requested review from joekaufmanexpensify and removed request for a team March 17, 2026 15:33
@melvin-bot melvin-bot bot requested review from youssef-lr and removed request for a team March 17, 2026 15:33
@melvin-bot
Copy link

melvin-bot bot commented Mar 17, 2026

@youssef-lr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@mountiny
Copy link
Contributor Author

Tested by running this build which was stuck on the splash screen #82309 (comment)

And running this build for pr that was merged just before #84910 which worked fine

@mountiny mountiny merged commit c78bd21 into main Mar 17, 2026
35 of 38 checks passed
@mountiny mountiny deleted the revert-82309-JKobrynski/feat/80091-migrate-keys-to-ram-only-part-1 branch March 17, 2026 15:34
@melvin-bot melvin-bot bot added the Emergency label Mar 17, 2026
@melvin-bot
Copy link

melvin-bot bot commented Mar 17, 2026

@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@github-actions
Copy link
Contributor

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

@mountiny
Copy link
Contributor Author

Straightus revertus

@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify pushed a commit that referenced this pull request Mar 17, 2026
…/80091-migrate-keys-to-ram-only-part-1

[CP Staging] Revert "[Onyx audit] Migrate keys to RAM-only - part 1/2"

(cherry picked from commit c78bd21)

(cherry-picked to staging by mountiny)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Mar 17, 2026
@codecov
Copy link

codecov bot commented Mar 17, 2026

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/CONST/index.ts 93.60% <ø> (+1.59%) ⬆️
src/DeepLinkHandler.tsx 78.12% <100.00%> (+4.54%) ⬆️
src/Expensify.tsx 88.13% <100.00%> (ø)
src/ONYXKEYS.ts 100.00% <ø> (ø)
...rc/components/Search/SearchRouter/SearchRouter.tsx 41.93% <100.00%> (+0.95%) ⬆️
src/libs/actions/App.ts 46.94% <ø> (ø)
src/libs/actions/QueuedOnyxUpdates.ts 100.00% <ø> (ø)
src/pages/NewChatPage.tsx 73.40% <100.00%> (+0.28%) ⬆️
...workspace/companyCards/assignCard/AssigneeStep.tsx 56.52% <100.00%> (+56.52%) ⬆️
src/setup/index.ts 100.00% <ø> (ø)
... and 23 more
... and 165 files with indirect coverage changes

@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.3.39-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/cristipaval in version: 9.3.39-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.3.40-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.3.40-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants