Make Concierge aware of the active report and/or selected transactions#86149
Make Concierge aware of the active report and/or selected transactions#86149youssef-lr wants to merge 31 commits intomainfrom
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
@abzokhattab Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5bd7620b44
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
I've address AI comments @abzokhattab |
|
@MelvinBot Review the PR |
|
@codex review |
|
@youssef-lr great lets also add test cases for the hooks |
PR ReviewOverall this is a clean, well-scoped change. A few items to address: Issues
Suggestions (non-blocking)
Looks good
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1fc9ec7998
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| // This condition is reached when we are either in the global Reports => Reports page, or within a single expense report having multiple transactions. | ||
| // If we have selectedReportIDs, that means we're in the Reports page, otherwise we're in the expense report RHP. | ||
| if (currentSearchQueryJSON?.type === CONST.SEARCH.DATA_TYPES.EXPENSE_REPORT) { | ||
| return selectedReportIDsForContext ? {selectedReportIDs: selectedReportIDsForContext} : {reportID: contextReportID, selectedTransactionIDs: selectedTransactionIDsForContext}; |
There was a problem hiding this comment.
Ignore stale selectedReportIDs in expense-report context
When currentSearchQueryJSON?.type is EXPENSE_REPORT, this branch always prefers selectedReportIDsForContext over the active report/transaction selection. That assumption is unsafe because selectedReports can remain populated from a previous Search selection while selectedTransactionIDs is updated elsewhere (the array update path in SearchContext does not clear selectedReports). In that state, Concierge receives old report IDs instead of the currently selected transactions/report, so bulk actions can target the wrong scope.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
selectedReports can remain populated from a previous Search selection while selectedTransactionIDs is updated elsewhere
This does not happen.
@MelvinBot create an issue and assign to me to handle this update in the backend, as the backend currently accepts IDs this way. |
|
Created https://github.com/Expensify/Expensify/issues/625067 and assigned to |
|
bump @abzokhattab |
|
i thought its still in progress since we need a backend change .. no? |
|
Ah no, we can implement the change in a follow up PR, I think we shouldn't block on it. |
|
I'm following the steps, but I'm running into an issue .. after I open the report, the Concierge help button doesn't show up. How am I supposed to open Concierge Anywhere in this case? Screen.Recording.2026-04-19.at.02.00.13.mov |
|
@abzokhattab open it before opening the RHP report |
|
bump @abzokhattab |
|
Missed your reply sorry .. will finalize the checklist today |
Explanation of Change
This PR allows Concierge Anywhere to be aware of any currently open expense report or transaction thread, as well as selected transactions inside an expense report view, and selected transactions/reports in the Reports page.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/613557
$ https://github.com/Expensify/Expensify/issues/614472
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari