Draft
Conversation
Contributor
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: View the translation diffdiff --git a/src/languages/de.ts b/src/languages/de.ts
index 2dab5e5b..9c9b2275 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -2373,6 +2373,9 @@ ${amount} für ${merchant} – ${date}`,
frozen: 'Gesperrt',
youFroze: ({date}: {date: string}) => `Du hast diese Karte am ${date} gesperrt.`,
frozenBy: ({person, date}: {person: string; date: string}) => `${person} hat diese Karte am ${date} gesperrt.`,
+ changePinATMTitle: 'Geldautomaten aufsuchen',
+ changePinATMDescription:
+ 'Verwenden Sie Ihre Karte an einem beliebigen Geldautomaten, um Ihre PIN-Änderung abzuschließen. Dies ist in Ihrer Region erforderlich. <concierge-link>Wenden Sie sich an Concierge</concierge-link>, wenn Sie Fragen haben.',
},
workflowsPage: {
workflowTitle: 'Ausgaben',
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index f1200a74..9abdbb95 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -2380,6 +2380,9 @@ ${amount} pour ${merchant} - ${date}`,
frozen: 'Gelée',
youFroze: ({date}: {date: string}) => `Vous avez gelé cette carte le ${date}.`,
frozenBy: ({person, date}: {person: string; date: string}) => `${person} a gelé cette carte le ${date}.`,
+ changePinATMTitle: 'Aller à un distributeur automatique',
+ changePinATMDescription:
+ "Utilisez votre carte à n'importe quel DAB pour terminer la modification de votre code PIN. Cela est requis dans votre région. <concierge-link>Contactez Concierge</concierge-link> si vous avez des questions.",
},
workflowsPage: {
workflowTitle: 'Dépense',
diff --git a/src/languages/it.ts b/src/languages/it.ts
index 37cd7176..4efb35a7 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -2369,6 +2369,9 @@ ${amount} per ${merchant} - ${date}`,
frozen: 'Bloccata',
youFroze: ({date}: {date: string}) => `Hai bloccato questa carta il ${date}.`,
frozenBy: ({person, date}: {person: string; date: string}) => `${person} ha bloccato questa carta il ${date}.`,
+ changePinATMTitle: 'Vai a un bancomat',
+ changePinATMDescription:
+ 'Usa la tua carta a qualsiasi bancomat per completare il cambio del PIN. Questo è obbligatorio nella tua regione. <concierge-link>Contatta Concierge</concierge-link> se hai domande.',
},
workflowsPage: {
workflowTitle: 'Spesa',
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index 8ea363a2..27a4c5eb 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -2344,6 +2344,9 @@ ${date} の ${merchant} への ${amount}`,
frozen: '凍結中',
youFroze: ({date}: {date: string}) => `${date}にこのカードを一時停止しました。`,
frozenBy: ({person, date}: {person: string; date: string}) => `${person}が${date}にこのカードを一時停止しました。`,
+ changePinATMTitle: 'ATM を利用する',
+ changePinATMDescription:
+ 'お住まいの地域では、暗証番号の変更を完了するには、任意のATMでカードをご利用いただく必要があります。ご不明な点がありましたら、<concierge-link>Concierge へお問い合わせください</concierge-link>。',
},
workflowsPage: {
workflowTitle: '支出',
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index 4978d187..5af6b863 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -2367,6 +2367,9 @@ ${amount} voor ${merchant} - ${date}`,
frozen: 'Geblokkeerd',
youFroze: ({date}: {date: string}) => `Je hebt deze kaart op ${date} geblokkeerd.`,
frozenBy: ({person, date}: {person: string; date: string}) => `${person} heeft deze kaart op ${date} geblokkeerd.`,
+ changePinATMTitle: 'Bezoek een geldautomaat',
+ changePinATMDescription:
+ 'Gebruik je kaart bij een willekeurige geldautomaat om je pincodewijziging af te ronden. Dit is verplicht in jouw regio. <concierge-link>Neem contact op met Concierge</concierge-link> als je vragen hebt.',
},
workflowsPage: {
workflowTitle: 'Uitgaven',
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index a30d0aab..26261b59 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -2363,6 +2363,9 @@ ${amount} dla ${merchant} - ${date}`,
frozen: 'Zamrożona',
youFroze: ({date}: {date: string}) => `Zamroziłeś tę kartę ${date}.`,
frozenBy: ({person, date}: {person: string; date: string}) => `${person} zamroził(a) tę kartę ${date}.`,
+ changePinATMTitle: 'Odwiedź bankomat',
+ changePinATMDescription:
+ 'Użyj swojej karty w dowolnym bankomacie, aby dokończyć zmianę PIN-u. Jest to wymagane w twoim regionie. <concierge-link>Skontaktuj się z Concierge</concierge-link>, jeśli masz jakiekolwiek pytania.',
},
workflowsPage: {
workflowTitle: 'Wydatki',
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index b919fb7a..f6e2b5a2 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -2360,6 +2360,9 @@ ${amount} para ${merchant} - ${date}`,
frozen: 'Congelado',
youFroze: ({date}: {date: string}) => `Você bloqueou este cartão em ${date}.`,
frozenBy: ({person, date}: {person: string; date: string}) => `${person} bloqueou este cartão em ${date}.`,
+ changePinATMTitle: 'Visitar um caixa eletrônico',
+ changePinATMDescription:
+ 'Use seu cartão em qualquer caixa eletrônico para concluir a alteração do seu PIN. Isso é obrigatório na sua região. <concierge-link>Fale com a Concierge</concierge-link> se tiver alguma dúvida.',
},
workflowsPage: {
workflowTitle: 'Gastos',
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index 048c91e5..08b9d2b9 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -2304,6 +2304,8 @@ ${amount}，商户：${merchant} - 日期：${date}`,
frozen: '已冻结',
youFroze: ({date}: {date: string}) => `你于${date}冻结了此卡。`,
frozenBy: ({person, date}: {person: string; date: string}) => `${person}于${date}冻结了此卡。`,
+ changePinATMTitle: '前往 ATM',
+ changePinATMDescription: '请在任意 ATM 使用您的银行卡完成 PIN 修改。这是您所在地区的必需步骤。如有任何疑问，请<concierge-link>联系 Concierge</concierge-link>。',
},
workflowsPage: {
workflowTitle: '支出',
Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
Member
Author
|
Asked here for translation validations |
melvin-bot
Bot
requested review from
DylanDylann and
trjExpensify
and removed request for
a team
|
@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
rafecolton
requested review from
chuckdries and
joekaufmanexpensify
and removed request for
trjExpensify
Contributor
|
@codex review |
DylanDylann
reviewed
Mar 24, 2026
| title="cardPage.pinChanged" | ||
| subtitle="cardPage.pinChangedDescription" | ||
| /> | ||
| ); |
Contributor
There was a problem hiding this comment.
I think we should pass isOfflinePINMarket in the payload and use payload.isOfflinePINMarket here.
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppiOS: HybridAppScreen.Recording.2026-03-24.at.23.54.38.movMacOS: Chrome / SafariScreen.Recording.2026-03-24.at.23.52.44.mov |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
Contributor
|
The code changes look good, with just one minor concern. Since I can only test this flow using Jairo’s server, I’ll test and post evidence once it’s up. |
Contributor
|
Tested well! |
Member
Author
|
Decided to close this out after further discussion |
Contributor
|
🚧 @rafecolton has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
Member
Author
|
Reopening and merging main, since we're using the ad-hoc in some testing |
Contributor
|
🚧 @rafecolton has triggered a test Expensify/App build. You can view the workflow run here. |
Contributor
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
Contributor
|
🚧 @chuckdries has triggered a test Expensify/App build. You can view the workflow run here. |
Contributor
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
Contributor
|
🚧 @rafecolton has triggered a test Expensify/App build. You can view the workflow run here. |
Contributor
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Allow UK cards to change PIN in-app, show alternate success screen directing them to an ATM.
Fixed Issues
$ #86143
PROPOSAL: N/A
Tests
Offline tests
N/A, online only
QA Steps
Same as tests. Assign to @joekaufmanexpensify for QA.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android.mov
iOS: Native
Screen.Recording.2026-03-23.at.8.04.16.PM.mov
MacOS: Chrome / Safari
Screen.Recording.2026-03-23.at.7.51.40.PM.mov