Allow submitters to select "Received reimbursement" option#86174
Allow submitters to select "Received reimbursement" option#86174nabi-ebrahimi wants to merge 16 commits intoExpensify:mainfrom
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f6b4405330
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
Joe is leading this one up |
|
@nabi-ebrahimi I want to test this on an adhoc build. I assume I need to wait for the BE PRs to be deployed to do that, yeah? |
|
@MelvinBot review |
|
🤖 PR Review CI Failures (must fix)
All three failures stem from the same root cause: missing translations. Code ReviewIssue: Delegate check after confirmation modalIn Issue: Missing test coverage
Minor: Consider guarding against zero-reimbursable reports
|
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
Add the new `iou` translation keys introduced by the received reimbursement flow to the remaining locale files: `de`, `fr`, `it`, `ja`, `nl`, `pl`, `pt-BR`, and `zh-hans`. This fixes the TypeScript failure on PR Expensify#86174 caused by locale objects missing: - `confirmPaymentReceived` - `receivedPayment` - `receivedPaymentConfirmation` - `yesIHaveReceivedPayment`
|
@Pujan92 Could you please take another look at the PR when you have a chance? I’ve addressed all the feedbacks. Thanks |
|
@nabi-ebrahimi is this ready for me to test too? |
@joekaufmanexpensify Yes it is ready for you to test. |
|
🚧 @joekaufmanexpensify has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
Testing well! One difference I noticed between OldDot and NewDot after an employee taps
The OldDot behavior doesn't make a ton of sense to me. I confirmed the report state shown in both platforms is consistent with either option used. So, I'm thinking we should go with NewDot2026-04-17_14-47-38.mp4OldDot2026-04-17_14-48-12.mp4 |
|
Yeah, I think we stick with |
|
Yep! No changes from what's already in this PR for NewDot. I posted the above to make sure everyone else is cool with this button name differing from the button name in classic. |
Explanation of Change
NewDot now includes a
Received paymentoption in the reportMoremenu for eligible submitters. When selected, it shows a confirmation modal and then uses the existing pay-elsewhere flow to mark the report as paid, while staying hidden for true bank-payment scenarios.Fixed Issues
$ #83035
PROPOSAL: #83035 (comment)
Tests
Received paymentoption.Offline tests
Same as Tests.
QA Steps
Same as Tests.
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-03-24.at.11.18.15.AM.mov
Android: mWeb Chrome
Screen.Recording.2026-03-24.at.11.23.11.AM.mov
iOS: Native
Screen.Recording.2026-03-24.at.11.32.54.AM.mov
iOS: mWeb Safari
Screen.Recording.2026-03-24.at.11.37.58.AM.mov
MacOS: Chrome / Safari
Screen.Recording.2026-03-24.at.9.43.57.AM.mov