Skip to content

[WIP][Structural Sharing] PR 1: Centralized key utilities with bidirectional indexes #86201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
fabioh8010 wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

[WIP][Structural Sharing] PR 1: Centralized key utilities with bidirectional indexes #86201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c53855b
Use newest Onyx changes
fabioh8010 Mar 24, 2026
6b4f61f
Use OnyxKeys.isCollectionKey
fabioh8010 Mar 24, 2026
e779a9a
Merge branch 'main' into feature/structural-sharing-cache-pr-1
fabioh8010 Mar 25, 2026
fc770f2
Use newest Onyx changes
fabioh8010 Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@
"react-native-localize": "^3.5.4",
"react-native-nitro-modules": "0.29.4",
"react-native-nitro-sqlite": "9.2.0",
"react-native-onyx": "3.0.51",
"react-native-onyx": "git+https://github.com/Expensify/react-native-onyx.git#13515657046bd04583078449f63f06d016e95b39",
"react-native-pager-view": "8.0.0",
"react-native-pdf": "7.0.2",
"react-native-permissions": "^5.4.0",
Expand Down
3 changes: 2 additions & 1 deletion src/libs/actions/OnyxDerived/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
* The primary purpose is to optimize performance by reducing redundant computations. More info can be found in the README.
*/
import Onyx from 'react-native-onyx';
import OnyxKeys from 'react-native-onyx/dist/OnyxKeys';
import OnyxUtils from 'react-native-onyx/dist/OnyxUtils';
import Log from '@libs/Log';
import IntlStore from '@src/languages/IntlStore';
Expand Down Expand Up @@ -87,7 +88,7 @@ function init() {
const dependencyIndex = i;
const dependencyOnyxKey = dependencies[dependencyIndex];

if (OnyxUtils.isCollectionKey(dependencyOnyxKey)) {
if (OnyxKeys.isCollectionKey(dependencyOnyxKey)) {
Onyx.connectWithoutView({
key: dependencyOnyxKey,
waitForCollectionCallback: true,
Expand Down
Loading