refactor getMovedTransactionMessage to add policy in its param by dukenv0307 · Pull Request #86237 · Expensify/App

dukenv0307 · 2026-03-24T15:48:14Z

Explanation of Change

Fixed Issues

$ #66411
PROPOSAL:

Tests

Open the Expensify app and navigate to a workspace expense report that has an expense (e.g., an open report under "Workspace A")
Long-press (mobile) or right-click (web) on an expense in the report to open the context menu
Select the option to move the expense to another report (e.g., to report under "Workspace B")
In the target report, find the "moved this expense from…" or "moved this expense to…" action item
Verify the action message displays the correct report/workspace name — e.g., "moved this expense from [Workspace A report name]" — and the name is a tappable link that navigates to the ws A

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-03-24.at.22.12.21.mov

codecov · 2026-03-24T15:57:38Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...onents/ReportActionItem/MovedTransactionAction.tsx	`100.00% <ø> (ø)`
src/libs/OptionsListUtils/index.ts	`82.66% <100.00%> (ø)`
src/libs/ReportUtils.ts	`81.23% <100.00%> (+<0.01%)`	⬆️
...report/ContextMenu/BaseReportActionContextMenu.tsx	`84.76% <100.00%> (+0.20%)`	⬆️
src/libs/SidebarUtils.ts	`80.69% <0.00%> (ø)`
...es/inbox/report/ContextMenu/ContextMenuActions.tsx	`44.12% <0.00%> (ø)`
src/libs/ReportNameUtils.ts	`83.29% <66.66%> (+0.33%)`	⬆️
... and 11 files with indirect coverage changes

melvin-bot · 2026-03-24T16:05:53Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 12d8d1a08f

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

joekaufmanexpensify · 2026-03-24T22:07:52Z

No product review needed

dukenv0307 · 2026-03-30T16:07:12Z

@DylanDylann Done

DylanDylann · 2026-03-31T03:36:47Z

@dukenv0307 I suggest adding report to the params too, then we only need to pass one policy

dukenv0307 · 2026-04-02T02:33:36Z

@DylanDylann Can you add more details? Why do we need to pass a report while we can get it from action?

App/src/libs/ReportUtils.ts

Lines 7041 to 7048 in e38712f

    
           function getMovedTransactionMessage(translate: LocalizedTranslate, action: ReportAction, conciergeReportID?: string) { 
        
               const movedTransactionOriginalMessage = getOriginalMessage(action) ?? {}; 
        
               const {toReportID, fromReportID} = movedTransactionOriginalMessage as OriginalMessageMovedTransaction; 
        
               const toReport = allReports?.[`${ONYXKEYS.COLLECTION.REPORT}${toReportID}`]; 
        
               const fromReport = allReports?.[`${ONYXKEYS.COLLECTION.REPORT}${fromReportID}`]; 
        
               const report = fromReport ?? toReport;

DylanDylann · 2026-04-02T09:15:14Z

Currently, we need to pass two policies, which seems redundant. If we determine the report earlier, we could pass only one policy.

DylanDylann · 2026-04-02T09:17:27Z

Since we’ll need to pass the report as a parameter in the future, I’d prefer to clean this up now instead of passing 2 polict object

dukenv0307 · 2026-04-06T02:06:03Z

I think it'd be overkill. If we want to pass 1 policy, that means we have to determine the report before calling getMovedTransactionMessage. As you can see, getMovedTransactionMessage is used in too many places and refactoring the report is out of this issue's scope. TBH, passing 1 more param is much better than refactoring the report in this case

DylanDylann · 2026-04-06T08:22:41Z

@dukenv0307 In the current code, we already pass fromReportPolicy and toReportPolicy, which means both reports are already computed in the component. So I thought passing the report along with the policy shouldn’t be too complex. I worry that we might miss cleaning up the policy parameters when refactoring the report parameter. So could you add a comment to remind us that we should clean the policy object when refactoring the report parameter (also note the link to that issue)

DylanDylann · 2026-04-06T08:33:13Z


    const [movedFromReport] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${getMovedReportID(lastAction, CONST.REPORT.MOVE_TYPE.FROM)}`);
    const [movedToReport] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${getMovedReportID(lastAction, CONST.REPORT.MOVE_TYPE.TO)}`);
+    const [movedFromReportPolicy] = useOnyx(`${ONYXKEYS.COLLECTION.POLICY}${movedFromReport?.policyID}`);


@dukenv0307 This is only for the dependency list ???

DylanDylann · 2026-04-06T08:44:37Z

+    const movedFromReport = isActionOfType(parentReportAction, CONST.REPORT.ACTIONS.TYPE.MOVED_TRANSACTION)
+        ? reports?.[`${ONYXKEYS.COLLECTION.REPORT}${getMovedReportID(parentReportAction, CONST.REPORT.MOVE_TYPE.FROM)}`]
+        : undefined;
+    const movedToReport = isActionOfType(parentReportAction, CONST.REPORT.ACTIONS.TYPE.MOVED_TRANSACTION)
+        ? reports?.[`${ONYXKEYS.COLLECTION.REPORT}${getMovedReportID(parentReportAction, CONST.REPORT.MOVE_TYPE.TO)}`]
+        : undefined;


we should avoid using reports going forward since they’re deprecated. Keeping this usage will increase the workload for future refactors.
But in this case, I’m fine with it to keep the scope under control

dukenv0307 · 2026-04-16T03:07:31Z

@DylanDylann can you please review this PR?

dukenv0307 · 2026-04-20T04:03:05Z

@DylanDylann Kindly bump

DylanDylann · 2026-04-20T09:37:20Z

How about #86237 (comment)?

DylanDylann · 2026-04-20T09:42:10Z

    const parentReport = reports?.[`${ONYXKEYS.COLLECTION.REPORT}${report?.parentReportID}`];
    const parentReportAction = isThread(report) ? reportActions?.[`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${report?.parentReportID}`]?.[report.parentReportActionID] : undefined;

+    const movedFromReport = isActionOfType(parentReportAction, CONST.REPORT.ACTIONS.TYPE.MOVED_TRANSACTION)


Since we’re using reports and policies from params, could you verify that they are fully passed in all usages?

Co-authored-by: DylanDylann <141406735+DylanDylann@users.noreply.github.com>

dukenv0307 · 2026-04-20T09:59:05Z

@dukenv0307 In the current code, we already pass fromReportPolicy and toReportPolicy, which means both reports are already computed in the component. So I thought passing the report along with the policy shouldn’t be too complex. I worry that we might miss cleaning up the policy parameters when refactoring the report parameter. So could you add a comment to remind us that we should clean the policy object when refactoring the report parameter (also note the link to that issue)

@DylanDylann getMovedTransactionMessage isn't just used in the component, it's used in the lib functions as well. For example, in getLastMessageTextForReport we call getMovedTransactionMessage, in createOption we call getLastMessageTextForReport, ... that means we have to update too many functions to include fromReport and toReport, which is out of this PR's scope

DylanDylann · 2026-04-21T09:15:43Z

I worry that we might miss cleaning up the policy parameters when refactoring the report parameter. So could you add a comment to remind us that we should clean the policy object when refactoring the report parameter (also note the link to that issue)

@dukenv0307

DylanDylann · 2026-04-21T09:45:53Z

+    movedFromReportPolicy?: OnyxEntry<Policy>;
+    movedToReportPolicy?: OnyxEntry<Policy>;


With this, I afraid that we will miss passing these prams

DylanDylann · 2026-04-21T09:46:08Z

+    fromMovedReportPolicy?: Policy,
+    toMovedReportPolicy?: Policy,


DylanDylann · 2026-04-21T09:47:56Z

+    movedFromReportPolicy?: OnyxEntry<Policy>;
+    movedToReportPolicy?: OnyxEntry<Policy>;


DylanDylann · 2026-04-21T09:48:46Z

+    movedFromReportPolicy?: OnyxEntry<Policy>;
+    movedToReportPolicy?: OnyxEntry<Policy>;


DylanDylann · 2026-04-21T10:29:15Z

@dukenv0307 Since we only need these new policy params when the action is MOVED_TRANSACTION, could we optimize the subscription to avoid unnecessary re-renders, maybe by using a derived key?

dukenv0307 added 3 commits March 24, 2026 22:04

refactor getMovedTransactionMessage to add policy in its param

9947af9

lint fix

a1508b2

add policy to getInvoicesChatName

12d8d1a

melvin-bot Bot assigned dukenv0307 Mar 24, 2026

dukenv0307 changed the title ~~Fix/66415 part 5~~ refactor getMovedTransactionMessage to add policy in its param Mar 24, 2026

dukenv0307 marked this pull request as ready for review March 24, 2026 16:05

dukenv0307 requested review from a team as code owners March 24, 2026 16:05

melvin-bot Bot requested review from DylanDylann and joekaufmanexpensify and removed request for a team March 24, 2026 16:05

melvin-bot Bot removed the request for review from a team March 24, 2026 16:05

chatgpt-codex-connector Bot reviewed Mar 24, 2026

View reviewed changes

Comment thread src/libs/ReportUtils.ts Outdated

joekaufmanexpensify removed their request for review March 24, 2026 22:07

dukenv0307 added 3 commits March 30, 2026 22:11

add more policy

c644168

merge main

9935aa8

lint fix

85bf8c7

DylanDylann reviewed Apr 6, 2026

View reviewed changes

dukenv0307 added 2 commits April 10, 2026 00:04

merge main

a83ae14

Merge branch 'main' into fix/66415-part-5

4f48310

lint fix

828ce65

DylanDylann reviewed Apr 20, 2026

View reviewed changes

Update src/libs/ReportUtils.ts

8dae8ed

Co-authored-by: DylanDylann <141406735+DylanDylann@users.noreply.github.com>

dukenv0307 added 3 commits April 20, 2026 16:59

ts fix

730c1ce

Merge branch 'main' into fix/66415-part-5

d5c2846

ts fix

761510b

DylanDylann reviewed Apr 21, 2026

View reviewed changes

		movedFromReportPolicy?: OnyxEntry<Policy>;
		movedToReportPolicy?: OnyxEntry<Policy>;

		fromMovedReportPolicy?: Policy,
		toMovedReportPolicy?: Policy,

Conversation

dukenv0307 commented Mar 24, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Mar 24, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented Mar 24, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

joekaufmanexpensify commented Mar 24, 2026

Uh oh!

dukenv0307 commented Mar 30, 2026

Uh oh!

DylanDylann commented Mar 31, 2026

Uh oh!

dukenv0307 commented Apr 2, 2026

Uh oh!

DylanDylann commented Apr 2, 2026

Uh oh!

DylanDylann commented Apr 2, 2026

Uh oh!

dukenv0307 commented Apr 6, 2026

Uh oh!

DylanDylann commented Apr 6, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dukenv0307 commented Apr 16, 2026

Uh oh!

dukenv0307 commented Apr 20, 2026

Uh oh!

DylanDylann commented Apr 20, 2026

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dukenv0307 commented Apr 20, 2026

Uh oh!

DylanDylann commented Apr 21, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DylanDylann commented Apr 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov Bot commented Mar 24, 2026 •

edited by github-actions Bot

Loading