[CP Staging] Allow checkbox deselection for disabled-but-selected categories in RadioListItem by MelvinBot · Pull Request #86263 · Expensify/App

MelvinBot · 2026-03-24T18:36:39Z

Explanation of Change

When a category used on an expense is deleted from workspace settings, the category appears as disabled but still selected in the category picker. BaseListItem intentionally keeps such items interactive via disabled={isDisabled && !item.isSelected} (line 167), allowing users to deselect them by clicking the row. However, PR #85852 added disabled={!!isDisabled} to the Checkbox in RadioListItem, which unconditionally disables the checkbox regardless of selection state. This creates an inconsistency where the row is clickable but the checkbox is not.

This PR aligns the Checkbox's disabled prop with BaseListItem's existing pattern: disabled={!!isDisabled && !item.isSelected}. This ensures:

Parent categories (isDisabled=true, isSelected=false): checkbox stays disabled (original fix preserved)
Deleted-but-selected categories (isDisabled=true, isSelected=true): checkbox becomes enabled so users can click it to deselect

Fixed Issues

$ #86261
PROPOSAL: #86261 (comment)

Tests

Go to a workspace chat
Create an expense with a category (e.g. "Advertising")
Go to workspace settings > Categories
Delete the category used in step 2
Go back to the workspace chat, open the report
Click on Category
Verify the deleted category appears at the top of the list with a checked checkbox
Click on the checkbox next to the deleted category
Verify the checkbox is clickable and successfully deselects the category

Verify that no errors appear in the JS console

Offline tests

N/A - This is a UI interaction fix that doesn't involve network calls.

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

N/A - UI logic change, behavior is cross-platform

Android: mWeb Chrome

N/A - UI logic change, behavior is cross-platform

iOS: Native

N/A - UI logic change, behavior is cross-platform

iOS: mWeb Safari

N/A - UI logic change, behavior is cross-platform

MacOS: Chrome / Safari

Tested on Chrome web build - deleted category checkbox is now clickable to deselect.

…stItem When a category is deleted but still selected on an expense, the row allows deselection (BaseListItem uses disabled={isDisabled && !item.isSelected}), but the checkbox was unconditionally disabled. This aligns the checkbox disabled logic with the row's existing pattern. Co-authored-by: Krishna <Krishna2323@users.noreply.github.com>

MelvinBot · 2026-03-24T18:36:54Z

I created this PR from an upstream branch since I don't have push access to your fork.

To take ownership of this branch and be able to push updates, run:

git remote add upstream https://github.com/Expensify/App.git
git fetch upstream claude-fixDisabledCheckboxForSelectedCategories
git checkout -b claude-fixDisabledCheckboxForSelectedCategories upstream/claude-fixDisabledCheckboxForSelectedCategories
git push -u origin claude-fixDisabledCheckboxForSelectedCategories

Then you can close this PR and open a new one from your fork.

Krishna2323 · 2026-03-24T18:42:53Z

@MelvinBot mark it ready for review

MelvinBot · 2026-03-24T18:44:29Z

@Krishna2323 I'm unable to mark this PR as ready for review due to permission restrictions. You can mark it ready yourself by:

Clicking the "Ready for review" button at the bottom of the PR page, or
Running: gh pr ready 86263 --repo Expensify/App

MelvinBot · 2026-03-24T18:46:04Z

The failing check (test (job 8)) is unrelated to this PR's changes.

Failing test: tests/actions/AppTest.ts — "actions/App › trigger full reconnect" expects reconnectApp to be called 1 time but it was called 0 times.

This PR only modifies: src/components/SelectionList/ListItem/RadioListItem.tsx (checkbox disabled prop logic).

Conclusion: The AppTest.ts failure is a pre-existing/flaky test unrelated to the RadioListItem change. Re-running the checks should resolve this.

Krishna2323 · 2026-03-24T18:46:16Z

@MarioExpensify could you please help? I don't have the permission to mark it ready.

Krishna2323 · 2026-03-24T18:48:23Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

Monosnap.screencast.2026-03-25.00-16-43.mp4

melvin-bot · 2026-03-24T18:53:06Z

@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Krishna2323 · 2026-03-24T18:54:03Z

Waiting for codex review. Reviewer checklist is already completed.

MarioExpensify · 2026-03-24T19:06:41Z

@codex review

chatgpt-codex-connector · 2026-03-24T19:14:31Z

Codex Review: Didn't find any major issues. More of your lovely PRs please.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Krishna2323

LGTM!

MarioExpensify

Moving forward with merge.

github-actions · 2026-03-24T19:19:15Z

🚧 @MarioExpensify has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-03-24T19:23:43Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #86263.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-5f8b8a0-2cd04ad-1382b0bf72193e54416bf222ba15cf8f611277f4/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-5f8b8a0-2cd04ad-7ada591b2d8385436f5465ba1574f2514a30dadb/index.html

Web 🕸️
https://86263.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-03-24T19:26:56Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

…rSelectedCategories [CP Staging] Allow checkbox deselection for disabled-but-selected categories in RadioListItem (cherry picked from commit 5f8b8a0) (cherry-picked to staging by francoisl)

OSBotify · 2026-03-24T23:23:44Z

🚀 Cherry-picked to staging by https://github.com/francoisl in version: 9.3.43-2 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

OSBotify · 2026-03-25T16:11:35Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.3.43-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-03-25T16:41:19Z

🚀 Cherry-picked to staging by https://github.com/francoisl in version: 9.3.44-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

OSBotify · 2026-03-25T18:53:33Z

🚀 Cherry-picked to staging by https://github.com/francoisl in version: 9.3.47-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

OSBotify · 2026-03-26T14:18:54Z

🚀 Deployed to production by https://github.com/grgia in version: 9.3.48-2 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot assigned Krishna2323 Mar 24, 2026

MelvinBot requested a review from a team March 24, 2026 18:36

MelvinBot mentioned this pull request Mar 24, 2026

[Due for payment 2026-04-02] [Due for payment 2026-04-01] Expense - Unable to click on checkbox to deselect category when selected category is not valid #86261

Closed

7 tasks

MarioExpensify marked this pull request as ready for review March 24, 2026 18:52

MarioExpensify requested a review from a team as a code owner March 24, 2026 18:52

melvin-bot bot requested review from hungvu193 and trjExpensify and removed request for a team March 24, 2026 18:53

melvin-bot bot removed the request for review from a team March 24, 2026 18:53

MarioExpensify requested review from MarioExpensify and removed request for hungvu193 and trjExpensify March 24, 2026 19:07

Krishna2323 approved these changes Mar 24, 2026

View reviewed changes

MarioExpensify changed the title ~~Allow checkbox deselection for disabled-but-selected categories in RadioListItem~~ [CP Staging] Allow checkbox deselection for disabled-but-selected categories in RadioListItem Mar 24, 2026

MarioExpensify approved these changes Mar 24, 2026

View reviewed changes

MarioExpensify merged commit 5f8b8a0 into main Mar 24, 2026
54 of 55 checks passed

MarioExpensify deleted the claude-fixDisabledCheckboxForSelectedCategories branch March 24, 2026 19:18

OSBotify added the CP Staging marks PRs that have been CP'd to staging label Mar 24, 2026

OSBotify mentioned this pull request Mar 24, 2026

Deploy Checklist: New Expensify 2026-03-24 #86199

Closed

53 tasks

Conversation

MelvinBot commented Mar 24, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

MelvinBot commented Mar 24, 2026

Uh oh!

Krishna2323 commented Mar 24, 2026

Uh oh!

MelvinBot commented Mar 24, 2026

Uh oh!

MelvinBot commented Mar 24, 2026

Uh oh!

Krishna2323 commented Mar 24, 2026

Uh oh!

Krishna2323 commented Mar 24, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Mar 24, 2026

Uh oh!

Krishna2323 commented Mar 24, 2026

Uh oh!

MarioExpensify commented Mar 24, 2026

Uh oh!

chatgpt-codex-connector bot commented Mar 24, 2026

Uh oh!

Krishna2323 left a comment

Choose a reason for hiding this comment

Uh oh!

MarioExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Mar 24, 2026

Uh oh!

github-actions bot commented Mar 24, 2026

Uh oh!

OSBotify commented Mar 24, 2026

Uh oh!

OSBotify commented Mar 24, 2026

Uh oh!

OSBotify commented Mar 25, 2026

Uh oh!

OSBotify commented Mar 25, 2026

Uh oh!

OSBotify commented Mar 25, 2026

Uh oh!

OSBotify commented Mar 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants