fix: correctly resolve mention whispers created during message edits by deetergp · Pull Request #86264 · Expensify/App

deetergp · 2026-03-24T18:39:19Z

Explanation of Change

When a message is edited to add a new @mention, the backend creates a second ACTIONABLEMENTIONWHISPER with a random ID (not following the parentID+1 convention used for whispers created on initial send). When that parent comment is deleted, the backend cascades the deletion to all linked whispers.

The backend (Auth fix for issue #86084) now stores the parent comment's reportActionID in the whisper's originalMessage JSON. This PR updates the frontend to use that field.

Without this fix: isResolvedActionableWhisper uses offset arithmetic (whisperID - 1) to find the parent of a mention whisper. For edit-created whispers with random IDs, this points to the wrong action. If that wrong action is not deleted, the function returns false and the whisper stays visible even after the backend deleted it.

With this fix: When originalMessage.reportActionID is present, use it directly to find the parent. Fall back to offset arithmetic for legacy whispers that predate this field.

Fixed Issues

$ #86084

Tests

Login to staging
Go to a workspace chat
Mention a non-member user and send the message (Concierge whisper appears)
Edit the message to add a second non-member mention (second Concierge whisper appears)
Delete the original message
Verify both Concierge whispers are removed

Offline tests

Same as tests.

QA Steps

Same as tests.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

🤖 Generated with Claude Code

When a message is edited to add a new @mention, the backend creates a second ACTIONABLEMENTIONWHISPER with a random ID (not following the parentID+1 convention). When that parent comment is deleted, the backend now stores the parent's reportActionID in the whisper's originalMessage. Update isResolvedActionableWhisper to use this stored reportActionID (when present) to find the parent, falling back to offset arithmetic for legacy whispers that predate this field. Add reportActionID to the OriginalMessageActionableMentionWhisper type accordingly. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

melvin-bot · 2026-03-24T18:39:26Z

@Krishna2323 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2026-03-24T18:39:32Z

@youssef-lr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2026-03-24T18:48:32Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/libs/ReportActionsUtils.ts	`76.67% <100.00%> (ø)`
src/libs/actions/Report/index.ts	`68.71% <87.50%> (-0.03%)`	⬇️
... and 10 files with indirect coverage changes

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 21ea5cd2ee

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

The backend stores the parent comment's reportActionID as a JSON string (to avoid precision loss when parsed by JavaScript). Update the TypeScript type and remove the String() wrapper since the value is already a string. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Krishna2323 · 2026-03-24T23:08:48Z

Will start reviewing shortly.

deetergp · 2026-03-24T23:19:33Z

You should hold off @Krishna2323 as it requires a yet-to-be-approved backend change in order to work.

JmillsExpensify

LGTM

deetergp · 2026-04-07T23:53:55Z

https://github.com/Expensify/Auth/pull/20622 has been merged and deployed, so I'm taking this one off hold.

Krishna2323 · 2026-04-08T14:39:50Z

Will start reviewing shortly

Krishna2323 · 2026-04-09T04:52:44Z

@deetergp The isResolvedActionableWhisper fix works correctly once the backend response arrives, but deleteReportComment still only checks parentID + 1 and parentID + 2 for optimistic deletion. Whispers created during edits (with random IDs) stay visible until the backend cascade syncs back.

Repro: Send a message with a mention, edit to add a second mention, delete the message. The first whisper disappears instantly, the second one lingers until the backend responds. In offline mode, the second whisper stays indefinitely.

Monosnap.screencast.2026-04-09.10-14-46.mp4

deetergp · 2026-04-10T22:36:55Z

@Krishna2323 Nice catch! Updated and verified that both are deleted in, regardless of connection status.

Krishna2323 · 2026-04-11T19:11:29Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android_hybrid.mp4

Android: mWeb Chrome

android_mWeb.mp4

iOS: HybridApp

ios_hybrid.mp4

iOS: mWeb Safari

ios_mWeb.mp4

MacOS: Chrome / Safari

web_chrome.mp4

Krishna2323

LGTM!

Krishna2323 · 2026-04-14T11:16:08Z

@youssef-lr friendly bump for final review!

@deetergp please merge main when you get a chance. Thanks!

deetergp · 2026-04-15T21:17:07Z

@youssef-lr Bump!

github-actions · 2026-04-15T21:19:22Z

🚧 @youssef-lr has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-04-15T21:24:59Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #86264.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-49c908c-d10f585-86d3f2457de6cd2aa154228b2875e190c01d12d2/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-49c908c-d10f585-766d70d1b27189c417c8b10f9312027b4df74edd/index.html

Web 🕸️
https://86264.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-04-15T21:27:42Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-04-16T03:55:20Z

🚀 Deployed to staging by https://github.com/youssef-lr in version: 9.3.60-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-04-16T03:56:43Z

I reviewed the changes in this PR. They are purely internal bug fixes to how actionable mention whispers resolve their parent actions — specifically adding a parentReportActionID field and updating lookup/deletion logic for whispers created during message edits.

These changes don't affect any user-facing behavior, UI labels, feature names, settings, or workflows. The existing help site article on mentions (Chat-Features-and-Moderation-Tools.md) describes the user-facing @mention feature, which is unaffected by this fix.

No help site documentation changes are required.

OSBotify · 2026-04-21T11:09:15Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.3.60-22 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

deetergp requested review from a team as code owners March 24, 2026 18:39

melvin-bot Bot assigned deetergp Mar 24, 2026

melvin-bot Bot requested review from Krishna2323 and removed request for a team March 24, 2026 18:39

melvin-bot Bot requested review from a team, JmillsExpensify and youssef-lr and removed request for a team March 24, 2026 18:39

chatgpt-codex-connector Bot reviewed Mar 24, 2026

View reviewed changes

Comment thread src/libs/ReportActionsUtils.ts Outdated

deetergp and others added 2 commits March 24, 2026 15:35

style: apply prettier formatting

40dc6d7

deetergp changed the title ~~fix: correctly resolve mention whispers created during message edits~~ [HOLD Auth #20622] fix: correctly resolve mention whispers created during message edits Mar 24, 2026

Rename reportActionID to parentReportActionID

c756b7e

JmillsExpensify reviewed Mar 29, 2026

View reviewed changes

deetergp changed the title ~~[HOLD Auth #20622] fix: correctly resolve mention whispers created during message edits~~ fix: correctly resolve mention whispers created during message edits Apr 7, 2026

deetergp added 2 commits April 10, 2026 11:36

Scan all actions for unresolved action whispers

b3aafab

Merge branch 'main' into fix/mention-whisper-parent-resolution

1adc181

Krishna2323 approved these changes Apr 11, 2026

View reviewed changes

Krishna2323 mentioned this pull request Apr 13, 2026

[Due for payment 2026-04-28] Chat - Not all whispers from Concierge are deleted after deleting message containing mention #86084

Open

7 tasks

Merge branch 'main' into fix/mention-whisper-parent-resolution

d48c733

youssef-lr approved these changes Apr 15, 2026

View reviewed changes

youssef-lr merged commit 49c908c into main Apr 15, 2026
35 checks passed

youssef-lr deleted the fix/mention-whisper-parent-resolution branch April 15, 2026 21:18

OSBotify mentioned this pull request Apr 16, 2026

Deploy Checklist: New Expensify 2026-04-16 #88022

Closed

Conversation

deetergp commented Mar 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Mar 24, 2026

Uh oh!

melvin-bot Bot commented Mar 24, 2026

Uh oh!

codecov Bot commented Mar 24, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Krishna2323 commented Mar 24, 2026

Uh oh!

deetergp commented Mar 24, 2026

Uh oh!

JmillsExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

deetergp commented Apr 7, 2026

Uh oh!

Krishna2323 commented Apr 8, 2026

Uh oh!

Krishna2323 commented Apr 9, 2026

Uh oh!

deetergp commented Apr 10, 2026

Uh oh!

Krishna2323 commented Apr 11, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

Krishna2323 left a comment

Choose a reason for hiding this comment

Uh oh!

Krishna2323 commented Apr 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

deetergp commented Apr 15, 2026

Uh oh!

Uh oh!

github-actions Bot commented Apr 15, 2026

Uh oh!

github-actions Bot commented Apr 15, 2026

Uh oh!

OSBotify commented Apr 15, 2026

Uh oh!

OSBotify commented Apr 16, 2026

Uh oh!

MelvinBot commented Apr 16, 2026

Uh oh!

OSBotify commented Apr 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

deetergp commented Mar 24, 2026 •

edited

Loading

codecov Bot commented Mar 24, 2026 •

edited by github-actions Bot

Loading

Krishna2323 commented Apr 14, 2026 •

edited

Loading