Skip to content

Show Explore section immediately on search page during loading#86381

Closed
MelvinBot wants to merge 2 commits intomainfrom
claude-showExploreSectionDuringLoading
Closed

Show Explore section immediately on search page during loading#86381
MelvinBot wants to merge 2 commits intomainfrom
claude-showExploreSectionDuringLoading

Conversation

@MelvinBot
Copy link
Copy Markdown
Contributor

@MelvinBot MelvinBot commented Mar 25, 2026

Explanation of Change

The search page sidebar was showing a full loading skeleton that hid the static Explore section (Reports, Expenses, Chats) until the openSearchPage API call completed. Since Explore items are always available and don't depend on server data, they should render immediately.

This PR splits the SearchTypeMenuWide rendering so the Explore section is shown immediately outside the loading gate, while the dynamic sections (Todo, Saved) remain behind areSuggestedSearchesLoading. It also updates SuggestedSearchSkeleton to accept a sectionCount prop so it renders the correct number of placeholder groups (matching the remaining dynamic sections instead of always rendering 3).

Fixed Issues

$ #86130
PROPOSAL: #86130 (comment)

Tests

  1. Open the app on wide layout
  2. Navigate to the Search page
  3. Verify the Explore section (Reports, Expenses, Chats) appears immediately in the left sidebar
  4. Verify loading skeleton appears only below the Explore section for the remaining dynamic sections (Todo, Saved)
  5. After loading completes, verify all sections render correctly
  6. Verify keyboard navigation still works across all sections
  • Verify that no errors appear in the JS console

Offline tests

  1. Turn off network connection
  2. Navigate to the Search page
  3. Verify the Explore section is visible immediately (no skeleton is shown when offline since areSuggestedSearchesLoading is false when offline)
  4. Verify all sections display correctly in offline state

QA Steps

  1. Open the app on wide layout (desktop web)
  2. Navigate to the Search page for the first time (or clear app data to simulate first load)
  3. Verify the Explore section (Reports, Expenses, Chats) is visible immediately without waiting for any loading state
  4. Verify the skeleton loading placeholders appear only for the sections below Explore
  5. After loading completes, verify Todo and Saved sections appear correctly
  6. Click on Reports, Expenses, and Chats to verify navigation works
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

MacOS: Chrome / Safari

Tested on web — Explore section (Reports, Expenses, Chats) renders immediately on the search page without waiting for the loading skeleton to complete.

@MelvinBot
Show Explore section immediately on search page during loading
70c3fae 
The search page sidebar was showing a full loading skeleton that hid
the static Explore section (Reports, Expenses, Chats) until the
openSearchPage API call completed. Since Explore items are always
available and don't depend on server data, they should render
immediately with only the dynamic sections (Todo, Saved) showing
a skeleton while loading.

Co-authored-by: {"message":"Not Found","documentation_url":"https://docs.github.com/rest/issues/comments#get-an-issue-comment","status":"404"} <{"message":"Not Found","documentation_url":"https://docs.github.com/rest/issues/comments#get-an-issue-comment","status":"404"}@users.noreply.github.com>
@MelvinBot MelvinBot requested a review from a team March 25, 2026 23:26
@MelvinBot MelvinBot mentioned this pull request Mar 25, 2026
Open
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 25, 2026 •
edited by github-actions Bot
Loading

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/pages/Search/SuggestedSearchSkeleton.tsx 0.00% <0.00%> (ø)
src/pages/Search/SearchTypeMenuWide.tsx 0.00% <0.00%> (ø)
... and 24 files with indirect coverage changes

@aimane-chnaif
Copy link
Copy Markdown
Contributor

aimane-chnaif commented Apr 1, 2026

@MelvinBot pull main and fix conflict

@MelvinBot @aimane-chnaif
Merge main and resolve conflict in SearchTypeMenuWide
554b172 
Co-authored-by: Aimane Chnaif <aimane-chnaif@users.noreply.github.com>
@MelvinBot
Copy link
Copy Markdown
Contributor Author

MelvinBot commented Apr 1, 2026

Merged main and resolved the conflict in src/pages/Search/SearchTypeMenuWide.tsx. The conflict was between the PR's refactored rendering (explore/non-explore split with renderSection) and main's inline rendering — kept the PR's approach.

@aimane-chnaif
Copy link
Copy Markdown
Contributor

aimane-chnaif commented Apr 21, 2026

@MelvinBot close this PR

@MelvinBot
Copy link
Copy Markdown
Contributor Author

MelvinBot commented Apr 21, 2026

🤖 aimane-chnaif requested to close this PR, but I don't have permission to close PRs directly. Please close it manually.

@aimane-chnaif
Copy link
Copy Markdown
Contributor

aimane-chnaif commented Apr 21, 2026

@MelvinBot close this PR like you did in #86380 (comment)

@MelvinBot MelvinBot closed this Apr 21, 2026
@MelvinBot
Copy link
Copy Markdown
Contributor Author

MelvinBot commented Apr 21, 2026

🤖 Closed this PR as requested by aimane-chnaif.

@aimane-chnaif aimane-chnaif mentioned this pull request Apr 21, 2026
Closed
52 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@aimane-chnaif aimane-chnaif

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MelvinBot @aimane-chnaif