[No QA] Add help site docs for Duplicate Expenses feature#86388
[No QA] Add help site docs for Duplicate Expenses feature#86388
Conversation
Add a new article explaining how to duplicate cash, distance, and per diem expenses using the Duplicate option in the More menu. Update the Expense and Report Actions article to include Duplicate in the secondary actions table. Co-authored-by: Stephanie Elliott <stephanieelliott@users.noreply.github.com>
|
A preview of your ExpensifyHelp changes have been deployed to https://e4330f4c.helpdot.pages.dev ⚡️ Updated articles: |
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? cc @muttmuure |
|
@muttmuure Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Co-authored-by: Stephanie Elliott <stephanieelliott@users.noreply.github.com>
|
Fixed the failing spellcheck: added |
|
@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
docs/articles/new-expensify/reports-and-expenses/How-to-Duplicate-an-Expense.md
Outdated
Show resolved
Hide resolved
docs/articles/new-expensify/reports-and-expenses/How-to-Duplicate-an-Expense.md
Show resolved
Hide resolved
docs/articles/new-expensify/reports-and-expenses/How-to-Duplicate-an-Expense.md
Show resolved
Hide resolved
docs/articles/new-expensify/reports-and-expenses/Expense-and-Report-Actions.md
Outdated
Show resolved
Hide resolved
docs/articles/new-expensify/reports-and-expenses/How-to-Duplicate-an-Expense.md
Outdated
Show resolved
Hide resolved
docs/articles/new-expensify/reports-and-expenses/How-to-Duplicate-an-Expense.md
Outdated
Show resolved
Hide resolved
HelpDot Documentation ReviewOverall AssessmentThis PR adds a new help article for the Duplicate Expenses feature and updates the Expense and Report Actions reference table. The article is well-structured, follows the single-workflow-per-article principle, and provides comprehensive coverage of the duplication feature. However, there are critical style compliance issues -- most notably around the Three Dots Menu Rule -- that must be addressed before merging. Scores Summary
Key FindingsCritical issues that must be addressed:
Other issues to address:
Positive aspects worth highlighting:
RecommendationsPriority 1 (must fix):
Priority 2 (should fix):
Priority 3 (nice to have):
Files Reviewed
Note: Detailed line-by-line feedback has been provided as inline comments where applicable. |
…eport-Actions.md Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…ate-an-Expense.md Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
Applied all relevant bot comments. Also confirmed the UI naming is correct, the naming conventions file is just too strict. Will create a separate PR to address that. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
|
🚧 @muttmuure has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/muttmuure in version: 9.3.52-0 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Adds help site documentation for the new Duplicate Expenses feature in New Expensify. This includes:
How-to-Duplicate-an-Expense.md- A dedicated article covering how to duplicate cash, distance, and per diem expenses using the Duplicate option in the More menu. Includes eligibility requirements, what fields are copied vs. reset, cross-workspace limitations for per diem and distance expenses, and an FAQ section.Expense-and-Report-Actions.md- Added Duplicate to the secondary ("More" menu) actions table so users can discover the feature when reviewing available expense actions.Both articles follow the HelpDot authoring guidelines, naming conventions, and template structure.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/616432
Tests
How-to-Duplicate-an-Expense.md#, multiple##)Expense-and-Report-Actions.mdand verify the Duplicate row appears in the secondary actions tableOffline tests
N/A — Documentation-only changes with no runtime behavior.
QA Steps
How-to-Duplicate-an-Expense.mdon the help siteExpense-and-Report-Actions.mdarticlePR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
N/A — Documentation-only changes
Android: mWeb Chrome
N/A — Documentation-only changes
iOS: Native
N/A — Documentation-only changes
iOS: mWeb Safari
N/A — Documentation-only changes
MacOS: Chrome / Safari
N/A — Documentation-only changes