83838 migrate workspace quickbooks online part 2#86504
83838 migrate workspace quickbooks online part 2#86504mjasikowski merged 8 commits intoExpensify:mainfrom
Conversation
…NSES_ACCOUNT_SELECT
|
@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@mjasikowski Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e6ecacd8d0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppandroid-bt-qbo.movAndroid: mWeb Chromemweb-chrome-bt-qbo.moviOS: HybridAppios-bt-qbo.moviOS: mWeb Safarimweb-safari-bt-qbo.movMacOS: Chrome / Safariweb-bt-qbo.mov |
|
@huult please resolve conflicts and we can merge |
…pace-quickbooks-online-part-2
|
@mjasikowski resolved |
|
@huult another one, sorry! there will be conflicts every time we merge an accounting integration |
…pace-quickbooks-online-part-2
|
Resovled |
|
🚧 @mjasikowski has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/mjasikowski in version: 9.3.54-0 🚀
Bundle Size Analysis (Sentry): |
|
No help site changes are required for this PR. This is a purely technical routing refactor — it migrates QBO export routes from static to dynamic route definitions ( |
Explanation of Change
Fixed Issues
$ #83838
PROPOSAL:
Tests
Same QA step
Offline tests
QA Steps
Precondition:
Case 1: Preferred Exporter
Case 2: Export Date
Case 3: Export Out-of-Pocket Expenses As
Case 4: Export As
Case 5: Account
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-03-27.at.11.56.25.mp4
Android: mWeb Chrome
Screen.Recording.2026-03-27.at.11.57.26.mp4
iOS: Native
Screen.Recording.2026-03-27.at.12.00.10.mp4
iOS: mWeb Safari
Screen.Recording.2026-03-27.at.12.00.59.mp4
MacOS: Chrome / Safari
Screen.Recording.2026-03-27.at.11.52.34.mp4