Preserve local image source on expense creation#86512
Merged
marcaaron merged 3 commits intoExpensify:mainfrom Apr 1, 2026
Merged
Preserve local image source on expense creation#86512marcaaron merged 3 commits intoExpensify:mainfrom
marcaaron merged 3 commits intoExpensify:mainfrom
Conversation
Contributor
Author
|
Before before.movAfter after.mov |
melvin-bot
bot
requested review from
jjcoffee and
joekaufmanexpensify
and removed request for
a team
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
src/libs/actions/IOU/index.ts
Outdated
| onyxMethod: Onyx.METHOD.SET, | ||
| key: `${ONYXKEYS.COLLECTION.TRANSACTION}${transaction.transactionID}`, | ||
| value: transaction, | ||
| value: shouldPreserveLocalReceiptSource ? {...transaction, receipt: {...transaction.receipt, localSource: String(transaction.receipt?.source)}} : transaction, |
Contributor
There was a problem hiding this comment.
❌ CONSISTENCY-3 (docs)
The expression shouldPreserveLocalReceiptSource ? {...transaction, receipt: {...transaction.receipt, localSource: String(transaction.receipt?.source)}} : transaction is duplicated verbatim here and in buildOnyxDataForMoneyRequest (line 1984). Both occurrences perform the same conditional augmentation of the transaction with a localSource field.
Extract a small helper function to eliminate the duplication:
function getTransactionWithPreservedLocalReceiptSource(transaction: OnyxTypes.Transaction, isScanRequest: boolean): OnyxTypes.Transaction {
if (isScanRequest && isLocalFile(transaction.receipt?.source)) {
return {...transaction, receipt: {...transaction.receipt, localSource: String(transaction.receipt?.source)}};
}
return transaction;
}Then both call sites simplify to:
value: getTransactionWithPreservedLocalReceiptSource(transaction, isScanRequest),Please rate this suggestion with 👍 or 👎 to help us improve! Reactions are used to monitor reviewer efficiency.
marcaaron
approved these changes
Apr 1, 2026
Contributor
marcaaron
left a comment
marcaaron
left a comment
There was a problem hiding this comment.
Changes LGTM! Nice improvement 🙇
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
joekaufmanexpensify
approved these changes
Apr 1, 2026
Contributor
joekaufmanexpensify
left a comment
joekaufmanexpensify
left a comment
There was a problem hiding this comment.
Good from a product perspective
Contributor
|
I don't think Reassure tests are related so going to merge this one! |
Contributor
|
🚧 @marcaaron has triggered a test Expensify/App build. You can view the workflow run here. |
Contributor
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Contributor
|
🚀 Deployed to staging by https://github.com/marcaaron in version: 9.3.52-0 🚀
Bundle Size Analysis (Sentry): |
Contributor
|
I reviewed all changes in this PR. The modifications are:
Conclusion: No help site changes are required. This is an internal bug fix that prevents receipt images from flickering when the server response replaces the local file URI. It does not introduce, rename, or modify any user-facing features, settings, buttons, or workflows. The existing help site articles about expenses and SmartScan remain accurate as-is. |
7 tasks
7 tasks
50 tasks
50 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Problem: when user create an expense with receipt its local source (
file://) is replaced by server createdsourcevalue and due to this application tries to download image from server - although it's already available locally.To handle this we preserve the local source in
localSourceand render the image like thislocalSource ?? sourceso if there is local image it takes precedence and user does not need to wait for the image.Fixed Issues
$ #85875
PROPOSAL:
Tests
Offline tests
N/A. Solution needs internet connection as bug is related to server's overwriting local image.
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
after.mov