[No QA] deprecate session data & refactor `getCleanUpTransactionThreadReportOnyxData` by parasharrajat · Pull Request #86605 · Expensify/App

parasharrajat · 2026-03-28T11:31:50Z

Explanation of Change

Fixed Issues

$ #66519
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I verified there are no new alerts related to the canBeMissing param for useOnyx
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If new assets were added or existing ones were modified, I verified that:
- The assets are optimized and compressed (for SVG files, run npm run compress-svg)
- The assets load correctly across all supported platforms.
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

melvin-bot · 2026-03-28T11:38:39Z

@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

parasharrajat · 2026-03-28T11:39:55Z

src/libs/actions/IOU/Duplicate.ts

    const allTransactionViolations = getAllTransactionViolations();
    const allReports = getAllReports();
    const currentUserEmail = getCurrentUserEmail();
+    const currentUserAccountID = getUserAccountID();


in later PRs...

ikevin127 · 2026-03-28T22:00:53Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If new assets were added or existing ones were modified, I verified that:
- The assets are optimized and compressed (for SVG files, run npm run compress-svg)
- The assets load correctly across all supported platforms.
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Screen.Recording.2026-03-28.at.15.56.14.mov

ikevin127 · 2026-03-28T22:48:21Z

src/libs/actions/IOU/index.ts

        ...chatReport,
        lastReadTime: DateUtils.getDBTime(),
-        hasOutstandingChildRequest: hasOutstandingChildRequest(chatReport, iouReport?.reportID, currentUserEmail, currentUserAccountIDParam, allTransactionViolations, undefined),
+        hasOutstandingChildRequest: hasOutstandingChildRequest(chatReport, iouReport?.reportID, deprecatedCurrentUserEmail, currentUserAccountIDParam, allTransactionViolations, undefined),


⚠️ MINOR SUGGESTION

Naming Consistency: Consider standardizing on currentUserAccountID across all call sites (currently uses currentUserAccountIDParam in some places, which is existing codebase convention).

Not in the scope of this project. Will update later.

Yeah, I agree with the suggestion too. I'm fine if you update it in later PRs.

ikevin127

📊 OVERALL ASSESSMENT

Category	Status
Code Quality	✅ EXCELLENT - Proper deprecation, clear naming
Onyx Patterns	✅ CORRECT - Moves away from anti-pattern
Type Safety	✅ GOOD - Proper types enforced
Error Handling	✅ ADEQUATE - Proper null checks

✅ Approved - This PR follows Expensify's architectural patterns correctly and is safe to merge after verification that test coverage exists for all modified call sites.

Manual tests I've ran: 3 Online/Offline Tests

Online: Create and delete expense with transaction thread - verify thread cleanup works correctly ✅
Offline: Delete expense while offline, then go online - verify optimistic data syncs correctly ✅
Merge Duplicates: Merge duplicate expenses - verify source transaction thread cleanup works ✅

joekaufmanexpensify · 2026-03-30T21:33:47Z

No product review needed

parasharrajat · 2026-03-31T07:55:48Z

cc: @tgolen

tgolen · 2026-03-31T15:31:06Z

src/libs/actions/IOU/index.ts

        ...chatReport,
        lastReadTime: DateUtils.getDBTime(),
-        hasOutstandingChildRequest: hasOutstandingChildRequest(chatReport, iouReport?.reportID, currentUserEmail, currentUserAccountIDParam, allTransactionViolations, undefined),
+        hasOutstandingChildRequest: hasOutstandingChildRequest(chatReport, iouReport?.reportID, deprecatedCurrentUserEmail, currentUserAccountIDParam, allTransactionViolations, undefined),


Yeah, I agree with the suggestion too. I'm fine if you update it in later PRs.

tgolen · 2026-03-31T15:33:34Z

Quite a few tests are failing, so I can't merge it yet.

codecov · 2026-03-31T18:38:39Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/libs/actions/IOU/Duplicate.ts	`95.76% <100.00%> (+0.01%)`	⬆️
src/libs/actions/IOU/Split.ts	`80.98% <ø> (ø)`
src/libs/actions/MergeTransaction.ts	`63.24% <ø> (ø)`
src/libs/actions/IOU/index.ts	`74.59% <90.47%> (+0.03%)`	⬆️
... and 10 files with indirect coverage changes

parasharrajat · 2026-03-31T18:55:02Z

Ready @tgolen

github-actions · 2026-04-01T16:28:41Z

🚧 @tgolen has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-04-01T16:33:32Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #86605.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-ae5c562-08e403c-cc771e996458bf1a4f5f897b556a9613d24c6e6b/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-ae5c562-08e403c-1157a8c435dc03f65751a6799bea0801f6bc9ff6/index.html

Web 🕸️
https://86605.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-04-02T20:20:47Z

🚀 Deployed to staging by https://github.com/tgolen in version: 9.3.52-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-04-02T20:22:11Z

No help site changes are required for this PR.

This is a purely internal refactoring that renames module-level variables (userAccountID → deprecatedUserAccountID, currentUserEmail → deprecatedCurrentUserEmail) and threads currentUserAccountID as an explicit parameter to getCleanUpTransactionThreadReportOnyxData. No user-facing behavior, features, UI text, or workflows changed — so nothing in docs/articles needs updating.

deprecate session data

86063b4

melvin-bot bot assigned parasharrajat Mar 28, 2026

Refactor getCleanUpTransactionThreadReportOnyxData

792935f

parasharrajat changed the title ~~deprecate session data~~ [No QA] deprecate session data Mar 28, 2026

parasharrajat marked this pull request as ready for review March 28, 2026 11:38

parasharrajat requested review from a team as code owners March 28, 2026 11:38

melvin-bot bot requested review from ikevin127 and joekaufmanexpensify and removed request for a team March 28, 2026 11:38

parasharrajat changed the title ~~[No QA] deprecate session data~~ [No QA] deprecate session data & refactor getCleanUpTransactionThreadReportOnyxData Mar 28, 2026

parasharrajat commented Mar 28, 2026

View reviewed changes

parasharrajat added 2 commits March 28, 2026 17:10

Fix lint

656e7ee

cleanup

fffc25a

ikevin127 reviewed Mar 28, 2026

View reviewed changes

ikevin127 approved these changes Mar 28, 2026

View reviewed changes

melvin-bot bot requested a review from danieldoglas March 28, 2026 23:00

joekaufmanexpensify removed their request for review March 30, 2026 21:33

Merge branch 'main' of github.com:Expensify/App into onyx/session-1

23c0595

tgolen previously approved these changes Mar 31, 2026

View reviewed changes

parasharrajat added 2 commits March 31, 2026 23:47

Merge branch 'main' of github.com:Expensify/App into onyx/session-1

7b5f467

Fixes

b7c7e0d

parasharrajat dismissed tgolen’s stale review via b7c7e0d March 31, 2026 18:24

Pretty pretty

1d48951

tgolen approved these changes Apr 1, 2026

View reviewed changes

tgolen merged commit ae5c562 into Expensify:main Apr 1, 2026
31 checks passed

OSBotify mentioned this pull request Apr 2, 2026

Deploy Checklist: New Expensify 2026-04-02 #86989

Open

Conversation

parasharrajat commented Mar 28, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Mar 28, 2026

Uh oh!

parasharrajat Mar 28, 2026

Choose a reason for hiding this comment

Uh oh!

ikevin127 commented Mar 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ikevin127 Mar 28, 2026

Choose a reason for hiding this comment

Uh oh!

parasharrajat Mar 31, 2026

Choose a reason for hiding this comment

Uh oh!

tgolen Mar 31, 2026

Choose a reason for hiding this comment

Uh oh!

ikevin127 left a comment

Choose a reason for hiding this comment

📊 OVERALL ASSESSMENT

Uh oh!

joekaufmanexpensify commented Mar 30, 2026

Uh oh!

parasharrajat commented Mar 31, 2026

Uh oh!

tgolen Mar 31, 2026

Choose a reason for hiding this comment

Uh oh!

tgolen commented Mar 31, 2026

Uh oh!

codecov bot commented Mar 31, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

parasharrajat commented Mar 31, 2026

Uh oh!

Uh oh!

github-actions bot commented Apr 1, 2026

Uh oh!

github-actions bot commented Apr 1, 2026

Uh oh!

OSBotify commented Apr 2, 2026

Uh oh!

MelvinBot commented Apr 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

ikevin127 commented Mar 28, 2026 •

edited

Loading

codecov bot commented Mar 31, 2026 •

edited by github-actions bot

Loading