[CP staging] Revert "fix: android pressability issue with measureAsyncOnUI patch"#86701
Conversation
melvin-bot
Bot
requested review from
trjExpensify
and removed request for
a team
|
🚧 @jasperhuangg has triggered a test Expensify/App build. You can view the workflow run here. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 524982fb29
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| return { | ||
| onPressIn: onPress, |
There was a problem hiding this comment.
This helper now drops onPress and only wires callbacks to onPressIn, which means non-touch activations can no longer trigger these actions on Android. In our pressable stack, activation paths such as accessibility/keyboard are handled through the onPress pipeline (GenericPressable calls onPressHandler for onPress/accessibility taps), so mapping only onPressIn makes tooltip dismiss/confirm controls effectively no-op for users relying on TalkBack or hardware keyboard navigation.
Useful? React with 👍 / 👎.
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
🚧 @jasperhuangg has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
jasperhuangg
changed the title
|
straight revert |
|
@jasperhuangg looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
|
🚧 @jasperhuangg has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
…abilityNewArch-v3 [CP staging] Revert "fix: android pressability issue with measureAsyncOnUI patch" (cherry picked from commit 2b517db) (cherry-picked to staging by jasperhuangg)
|
🚀 Cherry-picked to staging by https://github.com/jasperhuangg in version: 9.3.50-8 🚀
Bundle Size Analysis (Sentry): |
|
I have failed to help you. I let you down and for that I am sorry. Please try again later. This may be due to a Claude outage (check here). Failure details: https://github.com/Expensify/Expensify/actions/runs/23811964226 |
|
🚀 Cherry-picked to staging by https://github.com/jasperhuangg in version: 9.3.51-0 🚀
Bundle Size Analysis (Sentry): |
|
🤖 Help Site Review — No Changes Required I reviewed all the changes in this PR and confirmed that no updates are needed to the help site files under Reasoning: This PR reverts a React Native patch (
None of these changes affect user-facing features, workflows, settings names, button labels, or any functionality documented in the help site. I also searched all files under |
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.3.50-8 🚀
|
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.3.51-10 🚀
|
4 participants
Reverts #86160
$ #86566