Skip to content

Fix non-interactive MenuItem announcing as actionable on Android mWeb#86703

Draft
MelvinBot wants to merge 3 commits intomainfrom
claude-fixNonInteractiveMenuItemA11y
Draft

Fix non-interactive MenuItem announcing as actionable on Android mWeb#86703
MelvinBot wants to merge 3 commits intomainfrom
claude-fixNonInteractiveMenuItemA11y

Conversation

@MelvinBot
Copy link
Copy Markdown
Contributor

@MelvinBot MelvinBot commented Mar 31, 2026

Explanation of Change

On Android mWeb (Chrome), TalkBack announces "double tap to activate" on non-interactive MenuItem elements because the PressableWithSecondaryInteraction wrapper produces a DOM element that Chrome's accessibility tree interprets as interactive — even when interactive={false} is set.

This PR separates the rendering path in MenuItem:

  • Non-interactive items (interactive={false}): Renders a plain View wrapper with role="presentation" instead of PressableWithSecondaryInteraction. This prevents TalkBack from announcing the element as actionable. The inner text content (title, description, etc.) remains accessible so screen readers can still read the information.
  • Interactive items: Continues using PressableWithSecondaryInteraction with simplified props (dead interactive conditionals removed since interactive is guaranteed true in this branch).

The inner content is extracted into a shared renderItemContent(pressed) function to avoid duplication between the two rendering paths.

Fixed Issues

$ #79243
PROPOSAL: #79243 (comment)

Tests

  1. Open the app on Android mWeb Chrome with TalkBack enabled
  2. Navigate to a page with non-interactive MenuItem components (e.g. Expensify Card details page with "Card limit", "Remaining limit" rows)
  3. Verify TalkBack does NOT announce "double tap to activate" on non-interactive items
  4. Verify TalkBack still announces the text content of non-interactive items (title, description)
  5. Navigate to interactive MenuItem components and verify they still work as expected (tap, press, hover, accessibility announcements)
  • Verify that no errors appear in the JS console

Offline tests

N/A — This is a rendering/accessibility change that does not involve network requests.

QA Steps

  1. Enable TalkBack on Android Chrome (mWeb)
  2. Navigate to Settings > Wallet > Expensify Card details (or any page with non-interactive MenuItems)
  3. Swipe through the non-interactive rows (card number, limit type, remaining limit, etc.)
  4. Verify that TalkBack announces the text content but does NOT say "double tap to activate"
  5. Verify interactive MenuItems still announce as actionable and respond to taps
  6. Repeat on iOS VoiceOver (Safari mWeb) and verify no regressions
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@MelvinBot @truph01
Render non-interactive MenuItem with View instead of PressableWithSec…
4e98378 
…ondaryInteraction

On Android mWeb, TalkBack announces "double tap to activate" on non-interactive
MenuItem elements because Chrome interprets PressableWithSecondaryInteraction as
an interactive DOM element. This separates the rendering path: non-interactive
items use a plain View with role=presentation, while interactive items continue
using PressableWithSecondaryInteraction. The inner content is extracted into a
renderItemContent function shared by both paths.

Co-authored-by: truph01 <truph01@users.noreply.github.com>
@MelvinBot MelvinBot requested a review from a team March 31, 2026 01:56
@MelvinBot MelvinBot mentioned this pull request Mar 31, 2026
Open
@MelvinBot @truph01
Fix: run Prettier on MenuItem.tsx
80f3e26 
Co-authored-by: truph01 <truph01@users.noreply.github.com>
@MelvinBot
Copy link
Copy Markdown
Contributor Author

MelvinBot commented Mar 31, 2026

Fixed the failing Prettier check: ran prettier --write on src/components/MenuItem.tsx to auto-format the file.

@MelvinBot @truph01
Fix: pass testID to non-interactive MenuItem wrapper
f9607d5 
The non-interactive rendering path was missing the testID={pressableTestID}
prop that the interactive PressableWithSecondaryInteraction path already had,
causing tests that look up MenuItems by testID to fail.

Co-authored-by: truph01 <truph01@users.noreply.github.com>
@MelvinBot
Copy link
Copy Markdown
Contributor Author

MelvinBot commented Mar 31, 2026

Fixed the failing checks: the non-interactive MenuItem rendering path (the View wrapper with role="presentation") was missing testID={pressableTestID}, which the interactive PressableWithSecondaryInteraction path already had. This caused FlightTripDetailsTest and ReservationAddressTest to fail when looking up non-interactive MenuItems by testID.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 31, 2026 •
edited by github-actions Bot
Loading

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/components/MenuItem.tsx 86.99% <80.21%> (+0.17%) ⬆️
... and 10 files with indirect coverage changes

@truph01
Copy link
Copy Markdown
Contributor

truph01 commented Mar 31, 2026

@MelvinBot Close this PR

@MelvinBot
Copy link
Copy Markdown
Contributor Author

MelvinBot commented Mar 31, 2026

I attempted to close this PR as requested, but I don't have the necessary permissions to close PRs in this environment. Please close it manually using the "Close pull request" button at the bottom of this page.

@truph01
Copy link
Copy Markdown
Contributor

truph01 commented Apr 1, 2026

@rushatgabhane Could you please help close this issue? This solution is not working, and we already have another PR ready for review.

@truph01
Copy link
Copy Markdown
Contributor

truph01 commented Apr 13, 2026

@rushatgabhane Please help close this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@truph01 truph01

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MelvinBot @truph01