BT - Migrate `EXIT_SURVEY_REASON` and `EXIT_SURVEY_CONFIRM` by mananjadhav · Pull Request #86767 · Expensify/App

mananjadhav · 2026-03-31T18:53:05Z

Explanation of Change

Fixed Issues

$ #83364
PROPOSAL:

Tests

Test Steps:

Open the Expensify App
Click on "Accounts" and select "Troubleshoot"
Click on "Switch to Expensify Classic"
Observe the URL being settings/troubleshoot/exit-survey/reason.
Enter the reason and click on "Next".
It should open the Confirm page. Going back should open the reason page too.
Do a refresh and ensure the pages open properly.

Verify that no errors appear in the JS console

Offline tests

Cannot test offline.

QA Steps

Same as Test Steps.

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android-exit-survey.mov

Android: mWeb Chrome

mweb-chrome-exit-survey.mov

iOS: Native

ios-exit-survey.mov

iOS: mWeb Safari

mweb-safari-exit-survey.mov

MacOS: Chrome / Safari

web-replace-route.mov

…grate-exit-survey

codecov · 2026-04-02T04:06:25Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/ROUTES.ts	`16.93% <ø> (+0.01%)`	⬆️
src/SCREENS.ts	`100.00% <ø> (ø)`
...igation/linkingConfig/RELATIONS/SETTINGS_TO_RHP.ts	`100.00% <ø> (ø)`
src/libs/Navigation/linkingConfig/config.ts	`76.92% <ø> (ø)`
src/pages/settings/InitialSettingsPage.tsx	`0.00% <ø> (ø)`
...c/pages/settings/Troubleshoot/TroubleshootPage.tsx	`0.00% <ø> (ø)`
...gation/AppNavigator/ModalStackNavigators/index.tsx	`6.96% <0.00%> (ø)`
...ettings/ExitSurvey/DynamicExitSurveyReasonPage.tsx	`0.00% <0.00%> (ø)`
...ttings/ExitSurvey/DynamicExitSurveyConfirmPage.tsx	`0.00% <0.00%> (ø)`
... and 7 files with indirect coverage changes

mananjadhav · 2026-04-02T05:12:59Z

@collectioneur I think we need to tweak way dynamic routes are being replaced.

Test Steps:

Open the Expensify App
Click on "Accounts" and select "Troubleshoot"
Click on "Switch to Expensify Classic"
Observe the URL being settings/troubleshoot/exit-survey/reason.
Enter the reason and click on "Next".
The valid URL should be settings/troubleshoot/exit-survey/confirm but the new URL is settings/troubleshoot/exit-survey/reason/exit-survey/confirm.

I tried fixing it with the dynamicRoute utils but the navigation pushes the stack it doesn't work. I could probably just migrate reason page and keep confirm as static route.

web-replace-route.mov

melvin-bot · 2026-04-02T05:45:04Z

@huult Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 735e14d6f2

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

joekaufmanexpensify · 2026-04-03T20:47:46Z

No product review needed

…grate-exit-survey

huult · 2026-04-12T15:29:51Z

        queryParams: ['fieldName', 'fieldValue', 'policyID'],
    },
+    EXIT_SURVEY_REASON: {
+        path: 'exit-survey/reason',


Suggested change

path: 'exit-survey/reason',

path: 'exit-survey-reason',

Not changing this now. To avoid unnecessary old route mapping.

huult · 2026-04-12T15:50:07Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-04-12.at.22.41.38.mp4

Android: mWeb Chrome

Screen.Recording.2026-04-12.at.22.43.22.mp4

iOS: HybridApp

Screen.Recording.2026-04-12.at.22.46.52.mp4

iOS: mWeb Safari

Screen.Recording.2026-04-12.at.22.46.00.mp4

MacOS: Chrome / Safari

Screen.Recording.2026-04-12.at.22.41.38.mp4

huult · 2026-04-12T15:53:05Z

@collectioneur ould you take a look? @mananjadhav asked you about this: #86767 (comment)

…grate-exit-survey

mananjadhav · 2026-04-15T21:25:49Z

@collectioneur @huult Following the forceReplace logic we used for categories import, I've used the same for the exit survery paths here. I've also added the offline settings redirect that I missed in the previous commit.

web-bt-exit-survey-reason-nav.mov

…grate-exit-survey

mananjadhav · 2026-04-20T03:00:58Z

@huult Please review this PR.

huult

LGTM!

github-actions · 2026-04-20T07:00:40Z

🚧 @mjasikowski has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-04-20T07:06:26Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #86767.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-93f91bc-f81070b-c987c6d8e7fb23dbb3722fd169fbefb4274c18c9/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-93f91bc-f81070b-c02656508e2c181dd12c2832109c557a9e790d7c/index.html

Web 🕸️
https://86767.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-04-20T07:10:09Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-04-21T11:36:10Z

🚀 Deployed to staging by https://github.com/mjasikowski in version: 9.3.61-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-04-21T11:37:19Z

I reviewed the changes in this PR and checked the help site docs under App/docs/articles.

No help site updates are required. This PR is a purely internal navigation refactor — it migrates the EXIT_SURVEY_REASON and EXIT_SURVEY_CONFIRM routes from static to dynamic route patterns. There are no changes to user-facing text, UI labels, feature names, or functionality. The exit survey flow ("Switch to Expensify Classic") works the same way from the user's perspective.

The help site docs do not document the exit survey flow or the internal route paths that were changed.

lanitochka17 · 2026-04-21T20:29:52Z

Deploy Blocker ##88476 was identified to be related to this PR.

mananjadhav added 3 commits March 31, 2026 01:20

feat: migrate survey page

c540462

fix: rename the component with dynamic prefix

00e779a

fix: rename the component with dynamic prefix

30bdcde

melvin-bot Bot assigned mananjadhav Mar 31, 2026

Merge branch 'main' of github.com:mananjadhav/App into mj-83364-bt-mi…

4d2d04a

…grate-exit-survey

mananjadhav added 2 commits April 2, 2026 09:38

feat: migrate exit reason page

21717f9

fix: route replacement logic for the exit-survey

735e14d

mananjadhav changed the title ~~Mj 83364 bt migrate exit survey~~ BT - Migrate EXIT_SURVEY_REASON and EXIT_SURVEY_CONFIRM Apr 2, 2026

mananjadhav commented Apr 2, 2026

View reviewed changes

Comment thread src/libs/Navigation/helpers/dynamicRoutesUtils/createDynamicRoute.ts Outdated

mananjadhav marked this pull request as ready for review April 2, 2026 05:44

mananjadhav requested review from a team as code owners April 2, 2026 05:44

melvin-bot Bot requested a review from huult April 2, 2026 05:45

melvin-bot Bot requested review from joekaufmanexpensify and removed request for a team April 2, 2026 05:45

chatgpt-codex-connector Bot reviewed Apr 2, 2026

View reviewed changes

Comment thread src/libs/Navigation/helpers/dynamicRoutesUtils/createDynamicRoute.ts Outdated

Comment thread src/pages/settings/ExitSurvey/DynamicExitSurveyConfirmPage.tsx Outdated

This comment was marked as outdated.

Sign in to view

huult reviewed Apr 3, 2026

View reviewed changes

Comment thread src/libs/Navigation/AppNavigator/ModalStackNavigators/index.tsx

huult reviewed Apr 3, 2026

View reviewed changes

Comment thread src/ROUTES.ts Outdated

huult reviewed Apr 3, 2026

View reviewed changes

Comment thread src/ROUTES.ts Outdated

huult reviewed Apr 3, 2026

View reviewed changes

Comment thread src/pages/settings/ExitSurvey/DynamicExitSurveyConfirmPage.tsx

joekaufmanexpensify removed their request for review April 3, 2026 20:47

mananjadhav added 3 commits April 5, 2026 20:31

Merge branch 'main' of github.com:mananjadhav/App into mj-83364-bt-mi…

e80eb26

…grate-exit-survey

fix: remove screen.root

e779f4f

fix: update route

6cf01a6

mananjadhav added 3 commits April 6, 2026 00:09

fix: spell error

ae53213

Merge branch 'main' of github.com:mananjadhav/App into mj-83364-bt-mi…

b77c019

…grate-exit-survey

fix: remove unwanted test

4331bdc

huult reviewed Apr 9, 2026

View reviewed changes

Comment thread cspell.json

mananjadhav added 2 commits April 9, 2026 23:50

Merge branch 'main' of github.com:mananjadhav/App into mj-83364-bt-mi…

ea421b7

…grate-exit-survey

fix: reorder

bd3b367

huult reviewed Apr 12, 2026

View reviewed changes

Comment thread src/ROUTES.ts

huult reviewed Apr 12, 2026

View reviewed changes

mananjadhav added 4 commits April 16, 2026 02:13

Merge branch 'main' of github.com:mananjadhav/App into mj-83364-bt-mi…

caad087

…grate-exit-survey

fix: route navigation

b834e58

fix: lint error

18d1dd1

fix: update order

8243219

mananjadhav added 2 commits April 16, 2026 03:07

fix: lint fixes

036ab03

Merge branch 'main' of github.com:mananjadhav/App into mj-83364-bt-mi…

2d37ef8

…grate-exit-survey

huult approved these changes Apr 20, 2026

View reviewed changes

melvin-bot Bot requested a review from mjasikowski April 20, 2026 03:17

mjasikowski approved these changes Apr 20, 2026

View reviewed changes

mjasikowski merged commit 93f91bc into Expensify:main Apr 20, 2026
39 checks passed

OSBotify mentioned this pull request Apr 21, 2026

Deploy Checklist: New Expensify 2026-04-21 #88394

Open

lanitochka17 mentioned this pull request Apr 21, 2026

[$250] No reason and confirm pages open when user switch to Expensify Classic #88476

Open

7 tasks

Conversation

mananjadhav commented Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Apr 2, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

mananjadhav commented Apr 2, 2026

Uh oh!

Uh oh!

melvin-bot Bot commented Apr 2, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

joekaufmanexpensify commented Apr 3, 2026

Uh oh!

Uh oh!

Uh oh!

huult Apr 12, 2026

Choose a reason for hiding this comment

Uh oh!

mananjadhav Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

huult commented Apr 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

huult commented Apr 12, 2026

Uh oh!

mananjadhav commented Apr 15, 2026

Uh oh!

mananjadhav commented Apr 20, 2026

Uh oh!

huult left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Apr 20, 2026

Uh oh!

github-actions Bot commented Apr 20, 2026

Uh oh!

OSBotify commented Apr 20, 2026

Uh oh!

OSBotify commented Apr 21, 2026

Uh oh!

MelvinBot commented Apr 21, 2026

Uh oh!

lanitochka17 commented Apr 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

mananjadhav commented Mar 31, 2026 •

edited

Loading

codecov Bot commented Apr 2, 2026 •

edited by github-actions Bot

Loading

huult commented Apr 12, 2026 •

edited

Loading