Conversation
|
@Krishna2323 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Reviewing... |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4ba14458fd
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| accessible | ||
| accessibilityRole={CONST.ROLE.BUTTON} | ||
| accessibilityLabel={translate('common.previous')} | ||
| accessibilityLabel={CONST.ROLE.BUTTON} |
There was a problem hiding this comment.
Use distinct accessibility labels for prev/next controls
Setting accessibilityLabel to CONST.ROLE.BUTTON makes both controls announce as the same generic "button" in screen readers, so users cannot distinguish the previous action from the next action. This is an accessibility regression for assistive-technology navigation; keep accessibilityRole as button, but restore descriptive localized labels per control.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
The pre-#80122 code already had CONST.ROLE.BUTTON.
|
@chuckdries Please fix the failing checks. |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppandroid_hybrid.mp4Android: mWeb Chromeandroid_mweb.mp4iOS: HybridAppios_hybrid.mp4iOS: mWeb Safariios_safari.mp4MacOS: Chrome / Safariweb_chrome.mp4 |
|
🚧 @cead22 has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
(cherry picked from commit 7c573a7) (cherry-picked to staging by jasperhuangg)
|
🚀 Cherry-picked to staging by https://github.com/jasperhuangg in version: 9.3.51-1 🚀
Bundle Size Analysis (Sentry): |
|
No help site changes are required for this PR. This PR reverts #80122, which was a set of internal code changes to the chat message list rendering:
All of these are implementation-level changes to how the chat view renders and scrolls. They don't introduce, remove, or modify any user-facing features, settings, navigation flows, or terminology that would be covered in the help site articles under |
|
@chuckdries, CP was passed by the QA team on Web 1775038524600.bandicam_2026-04-01_13-13-35-279.mp4 |
|
Hi @IuliiaHerets, would you mind retesting this issue which is also linked to this revert please. Any staging build |
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.3.51-10 🚀
|
|
🚀 Cherry-picked to staging by https://github.com/jasperhuangg in version: 9.3.52-0 🚀
Bundle Size Analysis (Sentry): |
|
No help site changes are required for this PR. This is a revert of #80122, and all changes are internal to the chat message list rendering (switching back to |
Explanation of Change
This reverts commit 84815b8, reversing changes made to 3fdf0b8.
Unfortunately, the revert had minor conflicts in ReportActionsView, so this will need to be properly reviewed
Fixed Issues
$ #86787
PROPOSAL:
Tests
Offline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari