feat: display assigned account manager, partner manager, guide by Pujan92 · Pull Request #86952 · Expensify/App

Pujan92 · 2026-04-02T10:12:49Z

Explanation of Change

This PR adds Account Manager, Partner Manager, and Setup Specialist (Guide) contact items to the Help Page for paid policy admins.

Fixed Issues

$ #85993
PROPOSAL:

Tests

Preconditions:

Use an account that is a paid policy admin
Ensure the account has at least one of: Account Manager, Partner Manager, or Setup Specialist assigned

Navigate to Settings → Help
If an Account Manager is assigned → confirm a menu item appears with their name, avatar, and label "Your Account Manager"
If a Partner Manager is assigned → confirm a menu item appears with their name, avatar, and label "Your Partner Manager"
If a Setup Specialist (Guide) is assigned → confirm a menu item appears with their name, avatar, and label "Your Setup Specialist"
Tap any of the above items → verify it navigates to a DM chat with that contact

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2026-04-14.at.22.59.24.mov

iOS: mWeb Safari

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2026-04-14.at.23.06.14.mov

MacOS: Chrome / Safari

Screen.Recording.2026-04-06.at.22.14.20.mov

melvin-bot · 2026-04-02T10:12:57Z

@FitseTLT Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2026-04-02T10:22:21Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/CONST/index.ts	`92.30% <ø> (ø)`
src/libs/API/types.ts	`100.00% <ø> (ø)`
src/libs/actions/Help.ts	`0.00% <0.00%> (ø)`
src/pages/settings/HelpPage/HelpPage.tsx	`0.00% <0.00%> (ø)`
... and 9 files with indirect coverage changes

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5242add9f7

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

melvin-bot · 2026-04-06T16:21:54Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

Pujan92 · 2026-04-06T16:53:11Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c2d6f68f6e

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Pujan92 · 2026-04-07T12:17:23Z

@Valforte can you plz run the translations workflow

Valforte · 2026-04-14T16:49:08Z

Missed your message, running now!

OSBotify · 2026-04-14T16:51:05Z

🦜 Polyglot Parrot! 🦜

Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues:

The diff is too large to include in this comment (64KB), so I've created a gist for you:

📋 View the translation diff here 📋

Note

You can apply these changes to your branch by copying the patch to your clipboard, then running pbpaste | git apply, or directly by running gh gist view --raw b679ec5b09ae4ac37d60989972e6f549 | git apply 😉

View workflow run

FitseTLT · 2026-04-14T20:13:03Z

+    partnerManagerAccountID?: number;
+
+    /** The email of the partner manager */
+    partnerManagerEmail?: string;


~~I don't see this being used.~~ Ignore it I see in the discussion that it is returned from BE

FitseTLT · 2026-04-14T21:13:37Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ x If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

2026-04-15.00-00-23.mp4

Android: mWeb Chrome

2026-04-15.00-03-09.mp4

iOS: HybridApp

2026-04-15.00-12-11.mp4

iOS: mWeb Safari

2026-04-15.00-06-42.mp4

MacOS: Chrome / Safari

2026-04-15.00-05-10.mp4

FitseTLT

LGTM

github-actions · 2026-04-15T13:50:32Z

🚧 @Valforte has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-04-15T13:55:20Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #86952.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-b6297ca-d10f585-86d3f2457de6cd2aa154228b2875e190c01d12d2/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-b6297ca-d10f585-766d70d1b27189c417c8b10f9312027b4df74edd/index.html

Web 🕸️
https://86952.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-04-15T14:00:38Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-04-16T03:56:08Z

🚀 Deployed to staging by https://github.com/Valforte in version: 9.3.60-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-04-16T03:59:45Z

I reviewed the changes in this PR and confirmed that help site updates are needed. This PR adds Account Manager, Partner Manager, and Setup Specialist (Guide) contacts to the Settings > Help page for paid Workspace Admins — a new user-facing feature that isn't currently documented.

Draft PR created: #88029

The draft PR adds a new article at docs/articles/new-expensify/settings/Find-Your-Assigned-Support-Contacts.md covering:

Who can see the assigned support contacts (paid Workspace Admins)
What each contact role is (Account Manager, Partner Manager, Setup Specialist)
How to find and message them from Settings > Help
FAQ for common questions (why contacts don't appear, how to get one assigned)

Note: I was unable to add the PR to GitHub project 196 due to token permission restrictions. Please add it manually: gh project item-add 196 --owner Expensify --url https://github.com/Expensify/App/pull/88029

m-natarajan · 2026-04-16T13:47:56Z

@Valforte @Pujan92 @FitseTLT Can this one please be tested internally, This one requires an account that is a paid policy

Pujan92 · 2026-04-16T16:51:23Z

This one requires an account that is a paid policy

This means you need to be just an admin of any workspace. This can be tested internally, for assigning manager I think @johncschuster can help here.

johncschuster · 2026-04-17T20:19:45Z

Yep! We can test this internally. I've already assigned myself to the valforte.dev domain as it's account manager, let me go ahead and assign someone else as a Partner Manager so we can test that flow as well.

johncschuster · 2026-04-17T20:34:58Z

I've tested this on staging. Here's how it looks having all relationship types assigned:

OSBotify · 2026-04-21T11:10:03Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.3.60-22 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Pujan92 added 4 commits March 27, 2026 22:42

initial changes for assigned act manager

9bbe83f

Merge branch 'main' into feat/85993-assigned-rm

f3ca3c0

onPress for manager menuitem

2c53ea7

Merge branch 'main' into feat/85993-assigned-rm

5242add

Pujan92 requested review from a team as code owners April 2, 2026 10:12

melvin-bot Bot assigned Pujan92 Apr 2, 2026

melvin-bot Bot requested review from FitseTLT and heyjennahay and removed request for a team April 2, 2026 10:12

melvin-bot Bot removed the request for review from a team April 2, 2026 10:12

Pujan92 marked this pull request as draft April 2, 2026 10:16

chatgpt-codex-connector Bot reviewed Apr 2, 2026

View reviewed changes

Comment thread src/libs/actions/Help.ts

Pujan92 and others added 4 commits April 2, 2026 15:55

Add GetAssignedSupportData to ReadCommandParameters type map

2705db1

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Merge branch 'main' into feat/85993-assigned-rm

d9f6163

partner manager item added

cf4c87d

guide item added

c855512

jamie translations

c2d6f68

Pujan92 marked this pull request as ready for review April 6, 2026 16:33

Pujan92 changed the title ~~feat: display assigned account manager~~ feat: display assigned account manager, partner manager, guide Apr 6, 2026

minor translation change

87a27ee

chatgpt-codex-connector Bot reviewed Apr 6, 2026

View reviewed changes

Comment thread src/pages/settings/HelpPage/HelpPage.tsx Outdated

Pujan92 added 3 commits April 6, 2026 22:34

sentry label fix

84997c5

spanish translations corrected

69c6ca1

Merge branch 'main' into feat/85993-assigned-rm

4cafefc

Merge branch 'main' into feat/85993-assigned-rm

fddada9

Pujan92 mentioned this pull request Apr 14, 2026

[Due for payment 2026-04-28] [$500] [Message your Relationship Manager] Display assigned relationship manager on Help landing page for eligible roles #85993

Open

Pujan92 added 4 commits April 14, 2026 22:43

Merge branch 'main' into feat/85993-assigned-rm

cbb8ce2

translations added

c697698

fixed translations

fdbee7c

param fix

e2a7fd4

FitseTLT reviewed Apr 14, 2026

View reviewed changes

FitseTLT approved these changes Apr 14, 2026

View reviewed changes

melvin-bot Bot requested a review from Valforte April 14, 2026 21:33

johncschuster removed the request for review from heyjennahay April 14, 2026 22:51

Valforte approved these changes Apr 15, 2026

View reviewed changes

Valforte merged commit b6297ca into Expensify:main Apr 15, 2026
35 of 37 checks passed

OSBotify mentioned this pull request Apr 16, 2026

Deploy Checklist: New Expensify 2026-04-16 #88022

Closed

MelvinBot mentioned this pull request Apr 16, 2026

[NO QA] Docs updates for E/A#86952 Add help article for assigned support contacts #88029

Draft

3 tasks

Conversation

Pujan92 commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Apr 2, 2026

Uh oh!

codecov Bot commented Apr 2, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

melvin-bot Bot commented Apr 6, 2026

Uh oh!

Pujan92 commented Apr 6, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Pujan92 commented Apr 7, 2026

Uh oh!

Valforte commented Apr 14, 2026

Uh oh!

OSBotify commented Apr 14, 2026

🦜 Polyglot Parrot! 🦜

Uh oh!

FitseTLT Apr 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

FitseTLT commented Apr 14, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

FitseTLT left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Apr 15, 2026

Uh oh!

github-actions Bot commented Apr 15, 2026

Uh oh!

OSBotify commented Apr 15, 2026

Uh oh!

OSBotify commented Apr 16, 2026

Uh oh!

MelvinBot commented Apr 16, 2026

Uh oh!

m-natarajan commented Apr 16, 2026

Uh oh!

Pujan92 commented Apr 16, 2026

Uh oh!

johncschuster commented Apr 17, 2026

Uh oh!

johncschuster commented Apr 17, 2026

Uh oh!

OSBotify commented Apr 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Pujan92 commented Apr 2, 2026 •

edited

Loading

codecov Bot commented Apr 2, 2026 •

edited by github-actions Bot

Loading

FitseTLT Apr 14, 2026 •

edited

Loading