Fix invite onboarding task not checked after expense submission by MelvinBot · Pull Request #86969 · Expensify/App

MelvinBot · 2026-04-02T13:33:35Z

Explanation of Change

When a user signs up via a workspace invite email, creates and submits an expense, then navigates to the Concierge chat, the "Submit an expense" onboarding task is never checked off.

Root cause: There is a race condition in ReportFetchHandler.tsx. The fetchReport function has a timing guard (line 122) that blocks openReport while isLoadingApp is true to wait for policy data. However, when isLoadingApp later becomes false, fetchReport is never re-called because the useEffect dependency array ([route, isLinkedMessagePageReady, reportActionIDFromRoute]) does not include isLoadingApp or introSelected.

This means for invite onboarding users, openReport either:

Runs before introSelected is populated (so getGuidedSetupDataForOpenReport returns undefined due to !introSelected check)
Is blocked by the timing guard and never re-triggered

In both cases, the guided setup tasks (including "Submit an expense") are never created in the Concierge chat.

Fix: Added a new useEffect that watches for the isLoadingApp transition from true to false. When this happens for invite onboarding users who still need guided setup tasks, it re-triggers fetchReport() so that openReport can run with the now-available introSelected data and create the guided setup tasks. This is safe because getGuidedSetupDataForOpenReport already guards against duplicate task creation via the hasOpenReportWithGuidedSetupData check on persisted requests.

Fixed Issues

$ #74781
PROPOSAL: #74781 (comment)

Tests

Log in as an admin of a workspace (or create one)
Enter a custom name for the workspace
Navigate to Account Settings > Workspaces > Your workspace
In Workspace Settings, click on Members
Click on the Invite Member button
Add an email address that does not have an Expensify account (use a real email inbox)
Click Invite
On a different device/browser, open the email inbox of the invited user
Open the invitation email and tap "Get Started"
Create and submit an expense
Navigate to the Concierge chat
Verify that the "Submit an expense" task is checked off

Verify that no errors appear in the JS console

Offline tests

This change only affects the initial app loading flow when isLoadingApp transitions to false. Offline behavior is not impacted since:

The timing guard already handles the case where the app is loading
The openReport call will be queued if offline (handled by existing Onyx persist logic)

QA Steps

Using two separate devices/browsers:
- Device A: Log in as a workspace admin
- Device B: Will be used for the invited user
On Device A: Go to workspace settings > Members > Invite Member
Invite an email address that doesn't have an Expensify account
On Device B: Open the invitation email and sign up via the "Get Started" link
On Device B: Create and submit an expense
On Device B: Navigate to the Concierge chat
Verify the "Submit an expense" onboarding task is checked off

Verify that no errors appear in the JS console