Skip to content

[No QA] docs: Document update flow for personal bank accounts with missing info#86993

Open
MelvinBot wants to merge 3 commits intomainfrom
docs-update-personal-bank-account-info
Open

[No QA] docs: Document update flow for personal bank accounts with missing info#86993
MelvinBot wants to merge 3 commits intomainfrom
docs-update-personal-bank-account-info

Conversation

@MelvinBot
Copy link
Copy Markdown
Contributor

Explanation of Change

Updates the help site article Connect-a-Personal-Bank-Account.md to document the new "Update bank account" flow introduced in #80020. Changes include:

  • Added a new # Update a U.S. bank account with missing information section with step-by-step instructions for the update flow
  • Added a new FAQ entry explaining what the "Action required" badge means
  • Added relevant keywords (update bank account, action required, missing info) to article metadata

Fixed Issues

$ #76053

Tests

  1. Open the help site article at docs/articles/new-expensify/wallet-and-payments/Connect-a-Personal-Bank-Account.md
  2. Verify the new "Update a U.S. bank account with missing information" section is present and follows the existing article style
  3. Verify the new FAQ entry "Why does my bank account show 'Action required'?" is present
  4. Verify the article renders correctly in markdown
  • Verify that no errors appear in the JS console

Offline tests

N/A — documentation-only change.

QA Steps

  1. Visit the help site page for "Connect a Personal Bank Account"
  2. Verify the new section about updating bank accounts with missing information is visible
  3. Verify the FAQ about "Action required" is present
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

N/A — documentation-only change.

Android: mWeb Chrome

N/A — documentation-only change.

iOS: Native

N/A — documentation-only change.

iOS: mWeb Safari

N/A — documentation-only change.

MacOS: Chrome / Safari

N/A — documentation-only change.

…info

Documents the new "Update bank account" flow for US personal bank accounts
missing owner information (name, address, phone), including the "Action required"
badge and step-by-step update instructions.

Co-authored-by: TaduJR <TaduJR@users.noreply.github.com>
@MelvinBot MelvinBot requested a review from a team April 2, 2026 20:23
@MelvinBot
Copy link
Copy Markdown
Contributor Author

I created this PR from an upstream branch since I don't have push access to your fork.

To take ownership of this branch and be able to push updates, run:

git remote add upstream https://github.com/Expensify/App.git
git fetch upstream docs-update-personal-bank-account-info
git checkout -b docs-update-personal-bank-account-info upstream/docs-update-personal-bank-account-info
git push -u origin docs-update-personal-bank-account-info

Then you can close this PR and open a new one from your fork.

@github-actions github-actions Bot changed the title docs: Document update flow for personal bank accounts with missing info [No QA] docs: Document update flow for personal bank accounts with missing info Apr 22, 2026
@OSBotify
Copy link
Copy Markdown
Contributor

OSBotify commented Apr 22, 2026

A preview of your ExpensifyHelp changes have been deployed to https://81390f51.helpdot.pages.dev ⚡️

Updated articles:

@stephanieelliott stephanieelliott self-assigned this Apr 22, 2026
@stephanieelliott stephanieelliott marked this pull request as ready for review April 22, 2026 00:48
@stephanieelliott stephanieelliott self-requested a review as a code owner April 22, 2026 00:48
@melvin-bot
Copy link
Copy Markdown

melvin-bot Bot commented Apr 22, 2026

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @lydiabarclay

@melvin-bot melvin-bot Bot requested review from dukenv0307 and lydiabarclay and removed request for a team April 22, 2026 00:48
@melvin-bot
Copy link
Copy Markdown

melvin-bot Bot commented Apr 22, 2026

@dukenv0307 @lydiabarclay One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]


---

# Update a bank account with missing information
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heading hierarchy violation: Per HELP_AUTHORING_GUIDELINES.md Section 4, only one # heading (the article title) is allowed, plus the exempt # FAQ. This should be demoted to ##:

Suggested change
# Update a bank account with missing information
## Update a bank account with missing information

Alternatively, if this workflow is distinct enough, consider splitting it into its own article (per the "one primary workflow per article" rule).

If a bank account is missing required information (such as your legal name, address, or phone number), an **Action required** badge will appear on the bank account row in your Wallet. This information is needed for reimbursement payments to process successfully.

To update your bank account information:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent interaction verb: This step uses "Tap" (mobile-specific), while steps 3 and 6 use "Click" (web-specific). Per HELPSITE_NAMING_CONVENTIONS.md, if web and mobile navigation differ, provide separate labeled instructions. If they are structurally the same, use a single consistent verb. Consider using "Click" consistently here, or provide separate Web/Mobile instructions if the interaction genuinely differs.


1. Go to **Account > Wallet > Bank Accounts**.
2. Tap the bank account row that displays the **Action required** badge.
3. Click **Continue setup**.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent interaction verb: Same issue as step 2 — "Tap" is used here while other steps use "Click". Also, per HELPSITE_NAMING_CONVENTIONS.md, consider using "Click" for consistency, or clarify platform-specific behavior if the interaction differs between web and mobile.

title: Connect a Personal Bank Account
description: Learn how to connect your personal bank account to receive reimbursements in Expensify, including support for both US and international accounts.
keywords: [New Expensify, bank account, personal bank account, reimbursements, wallet, US bank account, global reimbursements, manual bank connection, add bank account for reimbursement, reimbursement account setup, wallet, deposit account, direct deposit]
keywords: [New Expensify, bank account, personal bank account, reimbursements, wallet, US bank account, global reimbursements, manual bank connection, add bank account for reimbursement, reimbursement account setup, wallet, deposit account, direct deposit, update bank account, action required, missing info]
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing required YAML metadata: Per HELP_AUTHORING_GUIDELINES.md Section 3, every article must include an internalScope field in the frontmatter. This article is missing it. Please add, e.g.:

internalScope: Audience is members receiving reimbursements. Covers connecting and updating personal bank accounts, does not cover business bank accounts or workspace-level payment settings.

@github-actions
Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR adds a new section and FAQ entry to the "Connect a Personal Bank Account" article, covering how to update a bank account that has missing information (the "Action required" badge flow). The additions are clear, actionable, and well-structured. A few governance compliance items should be addressed.

Scores Summary

  • Readability: 9/10 - Steps are clear, sequential, and action-oriented. The new section explains the trigger (badge appearing), the resolution steps, and the outcome. Easy to scan and follow.
  • AI Readiness: 7/10 - The new heading uses a task-based verb ("Update"), and three relevant keywords were added. However, the new section uses a # heading, which adds to the existing violation of the one-#-heading rule (only the article title and # FAQ should use #; all other sections should use ##). The internalScope field remains absent from the YAML metadata, though that is a pre-existing gap.
  • Style Compliance: 7/10 - Two issues: (1) The new steps mix "Tap" and "Click" without specifying platform context (steps 2 and 5 use "Tap"; steps 3 and 6 use "Click"). Per the naming conventions, if web and mobile navigation differ, separate instructions should be provided rather than mixing verbs. (2) The new FAQ heading wraps a UI element in quotation marks ("Action required"), but the naming conventions require bold formatting for UI elements and prohibit quotation marks around them.

Key Findings

  • The new procedural steps (1-6) are well-written, follow the actual UI flow, and align with the step formatting standard.
  • Adding keywords ("update bank account", "action required", "missing info") improves search discoverability.
  • The new FAQ entry is a good addition that anticipates a common user question.
  • The heading level (# instead of ##) perpetuates an existing structural issue in this article. Per HELP_AUTHORING_GUIDELINES.md Section 4, only the article title and # FAQ may use #.
  • The FAQ question ## Why does my bank account show "Action required"? should use bold instead of quotation marks for the UI label, per HELPSITE_NAMING_CONVENTIONS.md (Button Naming Standards).
  • Mixing "Tap" and "Click" without platform labels conflicts with the cross-platform clarity rule in HELPSITE_NAMING_CONVENTIONS.md.

Recommendations

  1. Change the new section heading from # to ##: ## Update a bank account with missing information. This aligns with the one-#-heading governance rule.
  2. Use bold instead of quotes in the FAQ heading: Change ## Why does my bank account show "Action required"? to ## Why does my bank account show an Action required badge? or similar phrasing that avoids wrapping a UI element in quotation marks.
  3. Standardize action verbs in steps: Either use "Click" consistently (if the flow is web-only) or provide separate Web/Mobile instruction blocks if the steps differ by platform (e.g., "Tap" for mobile, "Click" for web).

Files Reviewed

  • docs/articles/new-expensify/wallet-and-payments/Connect-a-Personal-Bank-Account.md - New section and FAQ entry added; three style/structure items flagged above.

Note: Scores reflect only the proposed changes in this PR, not pre-existing issues in unchanged content.

@dukenv0307
Copy link
Copy Markdown
Contributor

I think we should wait for this PR

@lydiabarclay
Copy link
Copy Markdown
Contributor

@stephanieelliott should I review now or wait?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants