Add '+' label to disambiguate FAB button in onboarding instructions by wildan-m · Pull Request #87040 · Expensify/App

wildan-m · 2026-04-03T00:33:42Z

Explanation of Change

The GC (Global Create) button is now grey, not green. But onboarding task instructions still reference it with a green circle emoji (GLOBAL_CREATE), misleading users into clicking the green Scan button instead.

This PR removes the GLOBAL_CREATE green circle emoji from all onboarding task descriptions and replaces it with a plain bold *+* text label. Only instructions pointing to the persistent GC button are changed — other button references (empty state subtitles, split expense compose button) are left as-is.

Updated 6 task descriptions across all 10 language files (en, de, es, fr, it, ja, nl, pl, pt-BR, zh-hans).

Fixed Issues

$ #86449
PROPOSAL: #86449 (comment)

Tests

Log in with a new account
Complete the onboarding flow, Choose "Track and Budget Expenses" on "What do you want to do today?"
Open the Concierge chat and find an onboarding task (e.g. "Create your first report", "Submit an expense", "Track an expense")
Verify the task description says "Click the + button" — NO green circle emoji before it
Repeat for other onboarding tasks: "Start a chat", "Split expenses", "Create your first report"
Verify step 1 in each task says "Click the + button" with no emoji

Verify that no errors appear in the JS console

Offline tests

This change is copy-only (localization strings). No network requests are involved — the text renders from bundled translations. No offline-specific behavior is affected.

QA Steps

Same as Tests above.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Kapture.2026-04-04.at.00.22.04.mp4

Android: mWeb Chrome

Kapture.2026-04-04.at.00.23.39.mp4

iOS: Native

Kapture.2026-04-04.at.00.24.46.mp4

iOS: mWeb Safari

Kapture.2026-04-04.at.00.25.50.mp4

MacOS: Chrome / Safari

Kapture.2026-04-03.at.23.53.42.mp4

…ng instructions Users confuse the green FAB emoji with the green Scan button because the onboarding task instructions just say "Click the [green circle] button" without specifying which green button. Adding *+* after the emoji makes it clear it's the plus/create button, consistent with the existing splitExpenseTask pattern that already uses "grey *+* button". Updates all 10 language files: onboarding task descriptions and empty state subtitles.

…iguate-fab-instructions

melvin-bot · 2026-04-03T00:33:48Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

codecov · 2026-04-03T03:17:15Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
see 12 files with indirect coverage changes

wildan-m · 2026-04-03T08:01:04Z

@garrettmknight @FitseTLT what do you think about this case?

below button is not + in this case.

What if we change this way?
'Use the button below to create an expense.' — drop both color and + since this isn't about the FAB

garrettmknight · 2026-04-03T10:44:21Z

We're only focused on instructions that are pointing to the GC button in the bottom right corner since it's persistent. I don't know if we have any instructions that specifically say Go to Reports > Expenses > click + Create`, but if we do we should leave them that way.

The GC (Global Create) button is now grey, not green. Onboarding task instructions reference it with a green circle emoji that misleads users into clicking the green Scan button instead. Remove the GLOBAL_CREATE emoji from all onboarding task descriptions and replace with plain bold *+*. Updates 6 task descriptions across all 10 language files.

wildan-m · 2026-04-03T17:39:43Z

@MelvinBot re-run jest unit test

wildan-m · 2026-04-03T17:40:15Z

updated

wildan-m · 2026-04-03T17:42:08Z

@FitseTLT based on this, I think we'll only focus on onboarding?

melvin-bot · 2026-04-03T17:42:16Z

@FitseTLT Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

wildan-m · 2026-04-03T17:43:12Z

note: Jest unit test is transient network error, not related to the code

joekaufmanexpensify

👍

FitseTLT · 2026-04-06T15:32:18Z

@wildan-m merge main

…iguate-fab-instructions

…eact-native-onyx

wildan-m · 2026-04-06T16:18:18Z

@FitseTLT latest main merged

…iguate-fab-instructions

wildan-m · 2026-04-07T20:50:13Z

@FitseTLT latest main merged

FitseTLT · 2026-04-09T16:40:33Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ x If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

FitseTLT

LGTM

github-actions · 2026-04-09T20:45:54Z

🚧 @carlosmiceli has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-04-09T20:54:05Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #87040.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-99a44ee-b0990c7-6d19a789025720ce9b279fd461cca7e90674add1/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-99a44ee-b0990c7-7769e75afc832ceb494d147f4334bb187b08273c/index.html

Web 🕸️
https://87040.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-04-10T08:25:52Z

🚀 Deployed to staging by https://github.com/carlosmiceli in version: 9.3.58-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-04-10T08:34:50Z

Yes, help site changes are required. The GC/FAB button is now grey, but 42 help site articles still reference a "green + button" or "green ➕ Create button."

I've created a draft PR with the fixes: #87573

Changes made:

Removed "green" from all + button and ➕ Create button references that refer to the Global Create/FAB button (42 files)
Left unchanged: green Receipt button references (still green), green + on receipt icon, and other green action buttons (Create Policy, Modify, Cancel, etc.)

wildan-m added 2 commits April 3, 2026 07:32

Merge remote-tracking branch 'upstream/main' into wildan/86449-disamb…

8e55d9d

…iguate-fab-instructions

melvin-bot bot assigned wildan-m Apr 3, 2026

wildan-m force-pushed the wildan/86449-disambiguate-fab-instructions branch from f697be6 to f2c1ccb Compare April 3, 2026 03:10

wildan-m force-pushed the wildan/86449-disambiguate-fab-instructions branch 4 times, most recently from 6635847 to 60de6a4 Compare April 3, 2026 07:30

wildan-m force-pushed the wildan/86449-disambiguate-fab-instructions branch from 60de6a4 to 287e003 Compare April 3, 2026 16:26

wildan-m marked this pull request as ready for review April 3, 2026 17:42

wildan-m requested review from a team as code owners April 3, 2026 17:42

melvin-bot bot requested a review from FitseTLT April 3, 2026 17:42

melvin-bot bot requested review from joekaufmanexpensify and removed request for a team April 3, 2026 17:42

wildan-m mentioned this pull request Apr 3, 2026

[$250] Onboarding instructions reference green button but the global-create button is now grey #86449

Open

joekaufmanexpensify previously approved these changes Apr 3, 2026

View reviewed changes

Merge remote-tracking branch 'upstream/main' into wildan/86449-disamb…

36e1c59

…iguate-fab-instructions

Fix ChronosUtils import: OnyxInputOrEntry is in src/types/onyx, not r…

7fa800c

…eact-native-onyx

wildan-m dismissed joekaufmanexpensify’s stale review via 7fa800c April 6, 2026 15:58

Merge remote-tracking branch 'upstream/main' into wildan/86449-disamb…

627a92c

…iguate-fab-instructions

FitseTLT approved these changes Apr 9, 2026

View reviewed changes

melvin-bot bot requested a review from carlosmiceli April 9, 2026 20:04

carlosmiceli approved these changes Apr 9, 2026

View reviewed changes

carlosmiceli merged commit 99a44ee into Expensify:main Apr 9, 2026
33 checks passed

github-actions bot mentioned this pull request Apr 9, 2026

Investigate workflow job failing on main: typecheck / typecheck #87541

Open

OSBotify mentioned this pull request Apr 10, 2026

Deploy Checklist: New Expensify 2026-04-10 #87562

Open

84 tasks

MelvinBot mentioned this pull request Apr 10, 2026

[No QA] Remove green color from + button references in help docs #87573

Draft

52 tasks

Conversation

wildan-m commented Apr 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Apr 3, 2026

Uh oh!

codecov bot commented Apr 3, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

wildan-m commented Apr 3, 2026

Uh oh!

garrettmknight commented Apr 3, 2026

Uh oh!

wildan-m commented Apr 3, 2026

Uh oh!

wildan-m commented Apr 3, 2026

Uh oh!

wildan-m commented Apr 3, 2026

Uh oh!

melvin-bot bot commented Apr 3, 2026

Uh oh!

wildan-m commented Apr 3, 2026

Uh oh!

joekaufmanexpensify left a comment

Choose a reason for hiding this comment

Uh oh!

FitseTLT commented Apr 6, 2026

Uh oh!

wildan-m commented Apr 6, 2026

Uh oh!

wildan-m commented Apr 7, 2026

Uh oh!

FitseTLT commented Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

FitseTLT left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Apr 9, 2026

Uh oh!

github-actions bot commented Apr 9, 2026

Uh oh!

OSBotify commented Apr 10, 2026

Uh oh!

MelvinBot commented Apr 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

wildan-m commented Apr 3, 2026 •

edited

Loading

codecov bot commented Apr 3, 2026 •

edited by github-actions bot

Loading

FitseTLT commented Apr 9, 2026 •

edited

Loading