Decompose scan pr1 selectors getters by rinej · Pull Request #87083 · Expensify/App

rinej · 2026-04-03T12:44:22Z

Explanation of Change

This is PR 1 of 5 in the IOURequestStepScan decomposition series (see #85571 for the full split plan).

Adds Onyx selectors to derived hooks to prevent full-collection re-renders:

useReportIsArchived: uses isArchivedReport as selector for stable boolean output
useDefaultExpensePolicy: extracts getSingleGroupPolicyID selector, replaces collection iteration with selector + per-key lookup
usePolicyForMovingExpenses: extracts getPolicyQualificationResult selector returning only IDs and flags
useReportAttributes: adds useReportAttributesByID for single-report lookups with cheap deep comparison
Also exports two getter functions from IOU actions (getAllTransactionDrafts, getAllReportNameValuePairs) needed by downstream variant components.

No user-visible behavior changes - return types and values are preserved.

Fixed Issues

$ #85583
PROPOSAL:

Tests

Log in to the app
Tap the FAB (+) button → Request money → Scan → capture a receipt → verify the confirmation screen appears
Open an existing report → tap (+) → Scan → capture a receipt → verify participants are set from the report

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

…-renders

…etters

…selectors-getters # Conflicts: # src/libs/actions/IOU/index.ts

codecov · 2026-04-08T17:17:53Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/hooks/useReportIsArchived.ts	`100.00% <100.00%> (ø)`
src/hooks/usePolicyForMovingExpenses.ts	`86.95% <95.00%> (+2.10%)`	⬆️
src/hooks/useReportAttributes.ts	`0.00% <0.00%> (ø)`
src/libs/actions/IOU/index.ts	`78.42% <0.00%> (-0.07%)`	⬇️
src/hooks/useDefaultExpensePolicy.tsx	`62.50% <53.84%> (+22.50%)`	⬆️
... and 54 files with indirect coverage changes

bernhardoj · 2026-04-15T08:42:28Z


+    // Selector returns only the qualifying policy ID — stable value, prevents re-renders
+    const [singleGroupPolicyID] = useOnyx(ONYXKEYS.COLLECTION.POLICY, {
+        selector: (policies) => getSingleGroupPolicyID(policies, login),


Can we return the policy here instead of the ID, similar to what we did with useReportAttributesByID?

Policy objects are large, so returning the full object from a collection selector would require Onyx to deep compare it on every collection change, it might defeat the performance a bit
useReportAttributesByID works differently because it selects from a derived value where each entry is a small object, making deep comparison cheap. Here we're selecting from the full COLLECTION.POLICY, so returning only the stable ID and doing a per-key lookup is more efficient
what do you think?

Deep comparison is cheap (single small object)
selects from a derived value where each entry is a small object

Ah, you're right. I've been thinking how it can be cheap if it's a report object. I forgot that it's a report attributes 🤦. All good!

bernhardoj · 2026-04-15T08:42:51Z

+    // Returns only IDs + flags (stable output) to prevent re-renders when unrelated policies change.
+    const policyQualificationSelector = (policies: OnyxCollection<Policy>) => getPolicyQualificationResult(policies, login, isPerDiemRequest, isTimeRequest, expensePolicyID);
+    const [qualificationResult] = useOnyx(ONYXKEYS.COLLECTION.POLICY, {
+        selector: policyQualificationSelector,


Same as above

rinej · 2026-04-15T11:03:21Z

Thanks for the review! I addressed the comments

melvin-bot · 2026-04-15T11:03:33Z

@bernhardoj Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

bernhardoj · 2026-04-15T13:28:46Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

web.mp4

bernhardoj

LGTM!

joekaufmanexpensify · 2026-04-15T21:51:57Z

No product review needed

cristipaval · 2026-04-17T11:50:04Z

@rinej could you please resolve the conflicts?

rinej added 2 commits April 3, 2026 14:34

perf: add selectors to policy/derived hooks to prevent unnecessary re…

df3cc40

…-renders

feat: export getAllTransactionDrafts and getAllReportNameValuePairs g…

3f94e05

…etters

melvin-bot Bot assigned rinej Apr 3, 2026

rinej mentioned this pull request Apr 3, 2026

Camera jank caused by unnecessary Onyx re-renders on the scan screen #85583

Open

Merge remote-tracking branch 'upstream/main' into decompose-scan-pr1-…

fac7ab1

…selectors-getters # Conflicts: # src/libs/actions/IOU/index.ts

rinej mentioned this pull request Apr 14, 2026

Decompose scan pr2 camera multiscan #87883

Open

50 tasks

bernhardoj reviewed Apr 15, 2026

View reviewed changes

rinej marked this pull request as ready for review April 15, 2026 11:03

rinej requested review from a team as code owners April 15, 2026 11:03

melvin-bot Bot requested review from bernhardoj and joekaufmanexpensify and removed request for a team April 15, 2026 11:03

melvin-bot Bot removed the request for review from a team April 15, 2026 11:03

bernhardoj approved these changes Apr 15, 2026

View reviewed changes

melvin-bot Bot requested a review from cristipaval April 15, 2026 13:40

cristipaval approved these changes Apr 15, 2026

View reviewed changes

joekaufmanexpensify removed their request for review April 15, 2026 21:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Decompose scan pr1 selectors getters#87083

Decompose scan pr1 selectors getters#87083
rinej wants to merge 3 commits intoExpensify:mainfrom
callstack-internal:decompose-scan-pr1-selectors-getters

rinej commented Apr 3, 2026 •

edited

Loading

Uh oh!

codecov Bot commented Apr 8, 2026 •

edited by github-actions Bot

Loading

Uh oh!

bernhardoj Apr 15, 2026

Uh oh!

rinej Apr 15, 2026

Uh oh!

bernhardoj Apr 15, 2026

Uh oh!

bernhardoj Apr 15, 2026

Uh oh!

rinej commented Apr 15, 2026

Uh oh!

melvin-bot Bot commented Apr 15, 2026

Uh oh!

bernhardoj commented Apr 15, 2026 •

edited

Loading

Uh oh!

bernhardoj left a comment

Uh oh!

joekaufmanexpensify commented Apr 15, 2026

Uh oh!

cristipaval commented Apr 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

rinej commented Apr 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Apr 8, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

bernhardoj Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

rinej Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

bernhardoj Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

bernhardoj Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

rinej commented Apr 15, 2026

Uh oh!

melvin-bot Bot commented Apr 15, 2026

Uh oh!

bernhardoj commented Apr 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

bernhardoj left a comment

Choose a reason for hiding this comment

Uh oh!

joekaufmanexpensify commented Apr 15, 2026

Uh oh!

cristipaval commented Apr 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

rinej commented Apr 3, 2026 •

edited

Loading

codecov Bot commented Apr 8, 2026 •

edited by github-actions Bot

Loading

bernhardoj commented Apr 15, 2026 •

edited

Loading