Move date filter Range text outside ScrollView for consistent visibility by MelvinBot · Pull Request #87099 · Expensify/App

MelvinBot · 2026-04-03T15:11:07Z

Explanation of Change

The "Range" summary text in the Filters page date picker (DateFilterBase) was rendered inside the ScrollView, which pushed it below the visible viewport when two vertically-stacked calendars are displayed. Users had to scroll down to see it after selecting dates.

This PR moves the Range text outside the ScrollView, placing it between the scroll area and the action buttons. This matches the existing pattern used by the exposed filter (DateSelectPopup), where the Range text is always visible as a fixed element at the bottom.

Fixed Issues

$ #87028
PROPOSAL: #87028 (comment)

Tests

Open the Expensify app on a mobile size screen
Navigate to "Reports" > "Expenses"
Tap on "Filters"
Scroll down to "Date" and open the field.
Tap on "Custom Range"
Apply any date on each calendar.
Verify that "Range" text appears on the bottom of the screen without having to scroll down

2026-04-03_10-50-10.mp4

Verify that no errors appear in the JS console

Offline tests

N/A - This is a layout-only change that does not involve network requests.

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

I only tested on web because the changes are platform independent. Please see the test video above.

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

The Range summary text was rendered inside the ScrollView, pushing it below the visible viewport when two vertical calendars are displayed. Move it outside the ScrollView (between the scroll area and action buttons) so it stays visible without scrolling, matching the existing pattern in DateSelectPopup. Co-authored-by: Neil Marcellini <neil-marcellini@users.noreply.github.com>

codecov · 2026-04-03T15:20:01Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...ponents/Search/FilterComponents/DateFilterBase.tsx	`0.00% <0.00%> (ø)`
... and 7 files with indirect coverage changes

melvin-bot · 2026-04-03T17:27:25Z

@bernhardoj Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

neil-marcellini · 2026-04-03T17:27:31Z

(Neil's AI agent)

@MelvinBot please test this PR

MelvinBot · 2026-04-03T17:34:00Z

🤖 Test Results: PASS ✅

All checks pass and I verified the fix in the browser. The Range text is now correctly positioned outside the ScrollView, between the calendar area and the Reset/Apply buttons, and is visible without scrolling.

Verifications:

Custom range dialog opens correctly with From and To calendars
After selecting a From date, "Range: April 10, 2026" appears immediately at the bottom — no scroll needed
After selecting a To date, text updates to "Range: Apr 10, 2026 - Apr 20, 2026" and stays visible
DOM inspection confirmed the Range text has no scrollable ancestors (it's outside the ScrollView)

Screenshots (web):

Initial state	From date selected	Full range selected

melvin-bot · 2026-04-03T17:52:18Z

@eVoloshchak @neil-marcellini One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2026-04-03T17:52:18Z

@thesahindia @neil-marcellini One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

deetergp

LGTM 👍

deetergp · 2026-04-03T17:59:16Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

MelvinBot · 2026-04-03T17:59:39Z

The only failing check is checklist (PR Author/Reviewer Checklist), which is not a code issue — it's an administrative check that requires manual reviewer action.

All code-related checks are passing: ESLint, Prettier, typecheck, all test jobs, builds, storybook, perf tests, and more. No code fix is needed.

OSBotify · 2026-04-03T18:19:10Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-04-03T18:27:06Z

🚧 @neil-marcellini has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-04-03T18:31:49Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #87099.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-f5672b1-4cded0d-565789f42f224549aea0313cf589c1eed9ab94d4/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-f5672b1-4cded0d-f72c603fd58f6495d68c8cd7922613c38cb34f9e/index.html

Web 🕸️
https://87099.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

MelvinBot assigned neil-marcellini Apr 3, 2026

MelvinBot requested a review from a team April 3, 2026 15:11

MelvinBot mentioned this pull request Apr 3, 2026

Reports - Inconsistent behavior of "Range" text on "Date" exposed filter and "Filters" page #87028

Open

7 tasks

neil-marcellini marked this pull request as ready for review April 3, 2026 17:27

neil-marcellini requested a review from a team as a code owner April 3, 2026 17:27

melvin-bot bot requested review from bernhardoj and removed request for a team April 3, 2026 17:27

melvin-bot bot requested review from joekaufmanexpensify and removed request for a team April 3, 2026 17:27

neil-marcellini marked this pull request as draft April 3, 2026 17:35

neil-marcellini marked this pull request as ready for review April 3, 2026 17:52

neil-marcellini requested a review from a team as a code owner April 3, 2026 17:52

melvin-bot bot requested review from eVoloshchak, neil-marcellini and thesahindia April 3, 2026 17:52

melvin-bot bot removed request for a team April 3, 2026 17:52

deetergp approved these changes Apr 3, 2026

View reviewed changes

neil-marcellini merged commit f5672b1 into main Apr 3, 2026
49 of 50 checks passed

neil-marcellini deleted the claude-fixDateRangeTextVisibility branch April 3, 2026 18:10

btkcodedev mentioned this pull request Apr 5, 2026

feat: Date Range filter follow up with fixes (#81501) #87055

Open

53 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move date filter Range text outside ScrollView for consistent visibility#87099

Move date filter Range text outside ScrollView for consistent visibility#87099
neil-marcellini merged 1 commit intomainfrom
claude-fixDateRangeTextVisibility

MelvinBot commented Apr 3, 2026 •

edited by neil-marcellini

Loading

Uh oh!

codecov bot commented Apr 3, 2026 •

edited by github-actions bot

Loading

Uh oh!

melvin-bot bot commented Apr 3, 2026

Uh oh!

neil-marcellini commented Apr 3, 2026

Uh oh!

MelvinBot commented Apr 3, 2026

Uh oh!

melvin-bot bot commented Apr 3, 2026

Uh oh!

melvin-bot bot commented Apr 3, 2026

Uh oh!

deetergp left a comment

Uh oh!

deetergp commented Apr 3, 2026 •

edited

Loading

Uh oh!

MelvinBot commented Apr 3, 2026

Uh oh!

Uh oh!

OSBotify commented Apr 3, 2026

Uh oh!

github-actions bot commented Apr 3, 2026

Uh oh!

github-actions bot commented Apr 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

MelvinBot commented Apr 3, 2026 • edited by neil-marcellini Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Apr 3, 2026 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot bot commented Apr 3, 2026

Uh oh!

neil-marcellini commented Apr 3, 2026

Uh oh!

MelvinBot commented Apr 3, 2026

Uh oh!

melvin-bot bot commented Apr 3, 2026

Uh oh!

melvin-bot bot commented Apr 3, 2026

Uh oh!

deetergp left a comment

Choose a reason for hiding this comment

Uh oh!

deetergp commented Apr 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

MelvinBot commented Apr 3, 2026

Uh oh!

Uh oh!

OSBotify commented Apr 3, 2026

Uh oh!

github-actions bot commented Apr 3, 2026

Uh oh!

github-actions bot commented Apr 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

MelvinBot commented Apr 3, 2026 •

edited by neil-marcellini

Loading

codecov bot commented Apr 3, 2026 •

edited by github-actions bot

Loading

deetergp commented Apr 3, 2026 •

edited

Loading