refactor: remove getReportTransactions calls from UI component#87131
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
…MostRecentIOUReportAction
Because I removed the dead code |
…n for better performance
|
@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
No product review needed |
|
@codex review |
|
@linhvovan29546 I see isMostRecentIOUReportAction is still being used. Not sure why we can safely remove it |
isMostRecentIOUReportAction used here. |
|
@linhvovan29546 Ag ok, got it |
Reviewer Checklist
Screenshots/VideosScreen.Recording.2026-04-07.at.16.15.30.mov |
|
Codex Review: Didn't find any major issues. Delightful! ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 @Valforte has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/Valforte in version: 9.3.54-0 🚀
Bundle Size Analysis (Sentry): |
|
No help site changes are required for this PR. This is a purely internal refactoring that replaces |
Explanation of Change
getReportTransactionsusage from all React component and hook callers, replacing them with theuseReportTransactionsCollectionhook (or useOnyx where hooks can't be called in a loop). This is part of the effort to remove the module-level Onyx.connect() for ONYXKEYS.COLLECTION.TRANSACTION in ReportUtils.tsisIOUReportPendingCurrencyConversion, since it’s dead code and no longer used.Note:
getReportTransactionsis still used at the lib/action level (ReportUtils.ts, IOU/index.ts, Report/index.ts, Search.ts, TransactionUtils, etc.). These are non-React pure functions that can't use hooks. Migrating those usages will be handled in a later phase.Fixed Issues
$ #66418
PROPOSAL: N/A
Tests
Test 1:
Test 2:
Test 3:
Offline tests
Same as test above
QA Steps
Same as test above
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-04-05.at.16.30.05.mov
Android: mWeb Chrome
Screen.Recording.2026-04-05.at.16.19.20.mov
iOS: Native
Screen.Recording.2026-04-05.at.16.24.59.mov
iOS: mWeb Safari
Screen.Recording.2026-04-05.at.16.18.05.mov
MacOS: Chrome / Safari
Screen.Recording.2026-04-05.at.16.05.05.mov
Screen.Recording.2026-04-05.at.16.16.32.mov