Compact row styles for context menus and popovers

[shawnborton]

Explanation of Change

cc @Expensify/design @JmillsExpensify @trjExpensify this is a quick test PR to see what more compact row styles would look like for popovers and context menus.

Fixed Issues

$
PROPOSAL:

Tests

• Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

[github-actions]

🚧 @shawnborton has triggered a test Expensify/App build. You can view the workflow run here.

[codecov]

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/components/MenuItem.tsx	87.22% <ø> (ø)
...ns/QuickEmojiReactions/BaseQuickEmojiReactions.tsx	90.00% <100.00%> (ø)
src/styles/index.ts	49.00% <ø> (ø)
src/components/PopoverMenu.tsx	82.23% <83.33%> (+0.36%)	⬆️
...ls/generators/ReportActionContextMenuStyleUtils.ts	33.33% <0.00%> (-4.17%)	⬇️
src/components/ContextMenuItem.tsx	0.00% <0.00%> (ø)
... and 109 files with indirect coverage changes

[shawnborton]

Okay these are the same size as the LHN rows on Reports now, but I wonder if that still feels too small?

Or maybe we just need to make the menus less wide, to make this less awkward:

[github-actions]

🚧 @shawnborton has triggered a test Expensify/App build. You can view the workflow run here.

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #87155.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-4b842d9-e41257d-fe23eba47666df5226eff53a322b8cab4ab3215c/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-4b842d9-e41257d-fd3b4ae4c19075a4de55af4ea5a86cc35dcb2c10/index.html

Web 🕸️
https://87155.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[shawnborton]

This definitely does not feel super great as it is right now, feels way too compact. Gonna keep tinkering, we might want to do something where we use 20px horizontal padding and bump the height up slightly.

[shawnborton]

56px height with 20px horizontal padding feels way better:

I'll let you both check out the existing builds first though, and then I can push this change above for comparison.

[dannymcclain]

Oh yeah not super into the current build 😂. I think if we're going to stick with the edge-to-edge + bold style, they probably need a bit more space like you're suggesting.

Also, have you tried/could you try making the icons 16x16 instead of 20x20? That might help a bit too.

[shawnborton]

Haven't tried yet because I was mostly trying to stay somewhat consistent with the LHN rows and FAB rows. But happy to give it a go and show ya!

[dannymcclain]

Haven't tried yet because I was mostly trying to stay somewhat consistent with the LHN rows and FAB rows. But happy to give it a go and show ya!

Maybe let's wait and see what Jon thinks of the current build / your proposal for the 56px height first.

[shawnborton]

Sounds like a plan to me!

[dubielzyk-expensify]

I think partially why it's looking weird is because of the container of it all:

I think it looks a bit better if we do something like this:

Up for going up to 56px as well 👍

[shawnborton]

Okay just pushed a change to update that container style, and make them 52. That might be a good balance. Will run another test build.

[github-actions]

🚧 @shawnborton has triggered a test Expensify/App build. You can view the workflow run here.

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #87155.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-6b332f7-37e8f9e-4de43d6e576c0db900841da940005f39c9f5654f/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-6b332f7-37e8f9e-4b0cf8fe5f6888fd7874d56be3e5c6638a6aaa3c/index.html

Web 🕸️
https://87155.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[shawnborton]

Okay, take it for a spin! I quite like it - thoughts? Makes me wonder if we should do this:

• not just on web, but on mobile too
• not just for context menus, but just all option row buttons in general? This would be a bigger update since some option row buttons contain 40x40 avatar images (bank rows for instance)