[No QA] [NO QA] [HOLD for testing] Update help site docs for bulk change approver feature#87192
[No QA] [NO QA] [HOLD for testing] Update help site docs for bulk change approver feature#87192
Conversation
Add documentation for the new bulk change approver flow introduced in the Search/Reports page, covering Add approver and Bypass approvers actions when multiple reports are selected. Co-authored-by: Qichen Zhu <QichenZhu@users.noreply.github.com>
docs/articles/new-expensify/reports-and-expenses/Approve-Expenses.md
Outdated
Show resolved
Hide resolved
|
@MelvinBot why can't @QichenZhu edit the PR? |
|
Since this PR was opened from the main Options:
|
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@Krishna2323 @CortneyOfstad One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
| 2. Select two or more reports using the checkboxes. | ||
| 3. Choose **Selected**, then **Change approver**. | ||
| 4. Select **Add approver** or **Bypass approvers**. | ||
| 5. If you selected **Add approver**, choose the approver and save. |
There was a problem hiding this comment.
Button naming violation: If "Save" is a UI button, it must be bolded per HELPSITE_NAMING_CONVENTIONS.md ("Bold all button names using bold formatting"). Change "save" to Save.
| 5. If you selected **Add approver**, choose the approver and save. | |
| 5. If you selected **Add approver**, choose the approver and click **Save**. |
| - Download as CSV | ||
| - **Print** | ||
| - Change Workspace | ||
| - Change Approver |
There was a problem hiding this comment.
Button naming violation: Per HELPSITE_NAMING_CONVENTIONS.md, all button/menu item names must be bolded. This should be Change Approver to match the formatting standard.
| - Change Approver | |
| - **Change Approver** |
HelpDot Documentation ReviewOverall AssessmentThis PR adds documentation for a new "Change approver" bulk action across three files. The changes are focused and well-scoped, documenting a single new feature addition in the appropriate existing articles. The additions are generally clear and follow most governance conventions, with a few items worth addressing. Scores Summary
Key FindingsIssues to address:
Positive aspects:
Recommendations
Files Reviewed
Review based on proposed diff changes only, scored against docs/HELPSITE_NAMING_CONVENTIONS.md, docs/HELP_AUTHORING_GUIDELINES.md, and docs/TEMPLATE.md. |
|
A preview of your ExpensifyHelp changes have been deployed to https://d5c30f77.helpdot.pages.dev ⚡️ Updated articles: |
Explanation of Change
Updates three help site articles to document the new bulk "Change approver" feature added in #77857. The feature allows users to select multiple reports on the Reports page and change the approver (add an approver or bypass approvers) in bulk.
Changes:
Fixed Issues
$ #75220
$ #77372
Tests
Offline tests
N/A — documentation-only changes.
QA Steps
[No QA] — documentation-only changes. No code behavior is affected.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
N/A — documentation-only changes.
Android: mWeb Chrome
N/A — documentation-only changes.
iOS: Native
N/A — documentation-only changes.
iOS: mWeb Safari
N/A — documentation-only changes.
MacOS: Chrome / Safari
N/A — documentation-only changes.