Remove Onyx.connect() usage for ONYXKEYS.COLLECTION.POLICY_TAGS in getMoneyRequestInformation function from src/libs/actions/IOU/index.ts#87236
Conversation
…-fork into Guccio163/onyx-connect/policy_tags/getMoneyRequestInformation
melvin-bot
Bot
requested review from
heyjennahay and
parasharrajat
and removed request for
a team
|
@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
melvin-bot
Bot
requested review from
a team and
amyevans
and removed request for
a team
…-fork into Guccio163/onyx-connect/policy_tags/getMoneyRequestInformation
…-fork into Guccio163/onyx-connect/policy_tags/getMoneyRequestInformation
|
@Guccio163 there are some conflicts to resolve 😄 @parasharrajat bump for review please |
|
I will get this tomorrow. |
| optimisticReportPreviewActionID, | ||
| shouldDeferAutoSubmit, | ||
| } = distanceRequestInformation; | ||
| const {policy, policyCategories, policyTagList, policyRecentlyUsedCategories, policyRecentlyUsedTags} = policyParams; |
There was a problem hiding this comment.
We were passing policyTagList here in params so why did we remove it.
There was a problem hiding this comment.
policyTagList is removed because its value is never used beside policyParams in getMoneyRequestInformation. Since we're not certain that this exact param contains the exact same values as getPolicyTagsData(iouReport.policyID) inside getPolicyTagsData, I think that the best move forward is using policyTagList to pass down correct, bubbled-up value, extracted by us, but bubbling it step-by-step, just like until now - one function per PR.
| function getMoneyRequestPolicyTags({ | ||
| existingIOUReport, | ||
| moneyRequestReportID, | ||
| parentChatReport, | ||
| participant, | ||
| }: { | ||
| existingIOUReport?: OnyxEntry<OnyxTypes.Report>; | ||
| moneyRequestReportID?: string; | ||
| parentChatReport: OnyxEntry<OnyxTypes.Report>; | ||
| participant: Participant; | ||
| }): OnyxTypes.PolicyTagLists { | ||
| const iouReportPolicyID = | ||
| existingIOUReport?.policyID ?? | ||
| (moneyRequestReportID ? allReports?.[`${ONYXKEYS.COLLECTION.REPORT}${moneyRequestReportID}`]?.policyID : undefined) ?? | ||
| parentChatReport?.policyID ?? | ||
| allReports?.[`${ONYXKEYS.COLLECTION.REPORT}${participant.reportID}`]?.policyID; | ||
| // eslint-disable-next-line @typescript-eslint/no-deprecated | ||
| return getPolicyTagsData(iouReportPolicyID) ?? {}; | ||
| } |
There was a problem hiding this comment.
What is the basis of this implementation? why are we using this many params?
There was a problem hiding this comment.
getMoneyRequestPolicyTags exists to let callers of getMoneyRequestInformation resolve the correct policyTagList before passing it in, so the function no longer needs to call getPolicyTagsData
internally.
The multiple params are needed because the policy ID of the IOU report can come from several different sources depending on the call context, mirroring the exact fallback chain that
getMoneyRequestInformation uses internally when resolving iouReport (lines 2301–2308):
- existingIOUReport?.policyID — direct match to iouReport = existingIOUReport
- allReports[moneyRequestReportID]?.policyID — direct match to iouReport = allReports[moneyRequestReportID]
- parentChatReport?.policyID — equivalent to new optimistic report's policyID: chatReport.policyID where chatReport = parentChatReport
- allReports[participant.reportID]?.policyID — same, but for the policy expense chat path where chatReport was resolved from allReports[participant.reportID]
Cases 3 and 4 are equivalent to the internal iouReport.policyID because expense reports always inherit their policyID from the parent chat — either set directly on buildOptimisticExpenseReport({
policyID: chatReport.policyID }), or already stored that way on the existing report in Onyx.
In short: every param is a different source of the same policyID. Together they guarantee that getMoneyRequestPolicyTags returns the exact same PolicyTagLists that
getPolicyTagsData(iouReport.policyID) would have returned had it been called inside getMoneyRequestInformation.
There was a problem hiding this comment.
I can get you a breakdown of how it maps to getMoneyRequestInformation's internal iouReport calculations if it might help, just let me know 👀
…-fork into Guccio163/onyx-connect/policy_tags/getMoneyRequestInformation
parasharrajat
left a comment
parasharrajat
left a comment
There was a problem hiding this comment.
Reviewer Checklist
- I have verified the author checklist is complete (all boxes are checked off).
- I verified the correct issue is linked in the
### Fixed Issuessection above - I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the
Testssection - I verified the steps for Staging and/or Production testing are in the
QA stepssection - I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I verified the steps for local testing are in the
- I checked that screenshots or videos are included for tests on all platforms
- I included screenshots or videos for tests on all platforms
- I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
- I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
- I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
toggleReportand notonIconClick). - I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to
src/languages/*files and using the translation method - I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in
STYLE.md) were followed
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
- If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
- I verified that this PR follows the guidelines as stated in the Review Guidelines
- I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like
Avatar, I verified the components usingAvatarhave been tested & I retested again) - I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
- I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
- If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a
/** comment above it */ - The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to
thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor) - Any internal methods bound to
thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick) - All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
- If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
- If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e.
StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
- If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
- If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like
Avataris modified, I verified thatAvataris working as expected in all cases) - If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
- If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
- If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added
Designlabel and/or tagged@Expensify/designso the design team can review the changes.
- If a new page is added, I verified it's using the
ScrollViewcomponent to make it scrollable when more elements are added to the page. - For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
- If the
mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps. - I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.
17.04.2026_18.04.18_REC.mp4
🎀 👀 🎀 C+ reviewed
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 @amyevans has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/amyevans in version: 9.3.61-0 🚀
Bundle Size Analysis (Sentry): |
|
I reviewed the changes in this PR. It's a purely internal code refactoring that removes an No help site documentation changes are required. This PR:
|
5 participants
Explanation of Change
Fixed Issues
$ #72721
PROPOSAL:
Tests
Test 1 – Tag is saved as recently used after submitting an expense
Preconditions:
Steps:
Expected result:
Test 2 – Recently used tags are isolated per workspace
Preconditions:
Steps:
Expected result:
Test 3 – fall back: fewer than 12 tags, recently used stored but no "Recent" section
Preconditions:
Steps:
Expected result:
Expected result:
TagX appears as a recently used tag
Verify that no errors appear in the JS console
Offline tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
test1.mov
test2.mov
test3.mov