Skip to content

fix: route Home report creation through Reports tab#87486

Draft
KJ21-ENG wants to merge 1 commit intoExpensify:mainfrom
KJ21-ENG:codex/issue-87073-home-reports
Draft

fix: route Home report creation through Reports tab#87486
KJ21-ENG wants to merge 1 commit intoExpensify:mainfrom
KJ21-ENG:codex/issue-87073-home-reports

Conversation

@KJ21-ENG
Copy link
Copy Markdown
Contributor

@KJ21-ENG KJ21-ENG commented Apr 9, 2026

Explanation of Change

This keeps the fix intentionally narrow.

It routes Home-originated report creation into the Reports/Search-side report route instead of the Inbox-owned REPORT_WITH_ID fallback, and it preserves that same Reports destination when the Home flow goes through workspace selection.

Search-originated behavior stays unchanged.

Fixed Issues

$ #87073
PROPOSAL: #87073 (comment)

Tests

  1. Run npx jest tests/unit/getCreateReportRouteTest.ts tests/ui/components/QuickCreationActionsBarTest.tsx --runInBand and verify both suites pass.
  2. From Home, tap the Report quick action and verify the app navigates to Reports and opens the new empty report in the wide RHP.
  3. From Home, open the FAB and tap Create report. Verify the app navigates to Reports and opens the new empty report in the wide RHP.
  4. From Home, trigger report creation through workspace selection and verify selecting a workspace still lands on Reports with the new empty report open in the wide RHP.
  5. From Search, create a report and verify Search behavior is unchanged.
  • Verify that no errors appear in the JS console

Offline tests

  1. Not run yet. Draft PR for route-review scope.

QA Steps

  1. Same as Tests.
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability)
  • I verified there are no console errors related to my changes
  • I added unit tests for the bug fix in this PR
  • I followed the PR title convention (fix: concise description)

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 9, 2026

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
...nents/Navigation/QuickCreationActionsBar/index.tsx 82.35% <100.00%> (+82.35%) ⬆️
...rc/libs/Navigation/helpers/getCreateReportRoute.ts 100.00% <100.00%> (ø)
src/pages/NewReportWorkspaceSelectionPage.tsx 0.00% <0.00%> (ø)
...BPopoverContent/menuItems/CreateReportMenuItem.tsx 52.63% <0.00%> (ø)
...Navigation/helpers/isHomeTopmostFullScreenRoute.ts 20.00% <20.00%> (ø)
... and 34 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant