fix: route Home report creation through Reports tab#87486
Draft
KJ21-ENG wants to merge 1 commit intoExpensify:mainfrom
Draft
fix: route Home report creation through Reports tab#87486KJ21-ENG wants to merge 1 commit intoExpensify:mainfrom
KJ21-ENG wants to merge 1 commit intoExpensify:mainfrom
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
This keeps the fix intentionally narrow.
It routes Home-originated report creation into the Reports/Search-side report route instead of the Inbox-owned
REPORT_WITH_IDfallback, and it preserves that same Reports destination when the Home flow goes through workspace selection.Search-originated behavior stays unchanged.
Fixed Issues
$ #87073
PROPOSAL: #87073 (comment)
Tests
npx jest tests/unit/getCreateReportRouteTest.ts tests/ui/components/QuickCreationActionsBarTest.tsx --runInBandand verify both suites pass.Reportquick action and verify the app navigates toReportsand opens the new empty report in the wide RHP.Create report. Verify the app navigates toReportsand opens the new empty report in the wide RHP.Reportswith the new empty report open in the wide RHP.Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionfix: concise description)