BT - Migrate `SAGE_INTACCT` Export by mananjadhav · Pull Request #87554 · Expensify/App

mananjadhav · 2026-04-10T03:01:42Z

Explanation of Change

Fixed Issues

$ #83845
PROPOSAL:

Tests

Preconditions

A workspace is connected to Sage Intacct.
You are a workspace admin (or have access to Accounting export settings).
For each test, remove the backTo query param from the URL (if present) before starting.

Case 1 : POLICY_ACCOUNTING_SAGE_INTACCT_EXPORT
(regression test)

Open Expensify.
Open the Sage Intacct–connected workspace.
Go to Accounting → Export (Sage Intacct export configuration).
Confirm the Export screen loads.
Press Back.
Confirm you return to the previous Accounting screen (e.g. connection / accounting hub), as expected for your navigation entry point.

Case 2 : POLICY_ACCOUNTING_SAGE_INTACCT_PREFERRED_EXPORTER

Open Expensify.
Open the Sage Intacct–connected workspace.
Go to Accounting → Export.
Open Preferred exporter.
Confirm the preferred exporter screen loads.
Press Back.
Confirm you return to Sage Intacct Export.

Case 3 : POLICY_ACCOUNTING_SAGE_INTACCT_EXPORT_DATE

Open Expensify.
Open the Sage Intacct–connected workspace.
Go to Accounting → Export.
Open Export date.
Confirm the export date screen loads.
Press Back.
Confirm you return to Sage Intacct Export.

Case 4 : POLICY_ACCOUNTING_SAGE_INTACCT_REIMBURSABLE_EXPENSES

Open Expensify.
Open the Sage Intacct–connected workspace.
Go to Accounting → Export.
Open Reimbursable expenses.
Confirm the reimbursable expenses screen loads.
Press Back.
Confirm you return to Sage Intacct Export.

Case 5 : POLICY_ACCOUNTING_SAGE_INTACCT_REIMBURSABLE_DESTINATION

Open Expensify.
Open the Sage Intacct–connected workspace.
Go to Accounting → Export → Reimbursable expenses.
Open Destination.
Confirm the reimbursable destination screen loads.
Press Back.
Confirm you return to Reimbursable expenses.

Case 6 : POLICY_ACCOUNTING_SAGE_INTACCT_NON_REIMBURSABLE_EXPENSES

Open Expensify.
Open the Sage Intacct–connected workspace.
Go to Accounting → Export.
Open Non-reimbursable expenses.
Confirm the non-reimbursable expenses screen loads.
Press Back.
Confirm you return to Sage Intacct Export.

Case 7 : POLICY_ACCOUNTING_SAGE_INTACCT_NON_REIMBURSABLE_DESTINATION

Open Expensify.
Open the Sage Intacct–connected workspace.
Go to Accounting → Export → Non-reimbursable expenses.
Open Destination.
Confirm the non-reimbursable destination screen loads.
Press Back.
Confirm you return to Non-reimbursable expenses.

Case 8 : POLICY_ACCOUNTING_SAGE_INTACCT_DEFAULT_VENDOR

Open Expensify.
Open the Sage Intacct–connected workspace.
Go to Accounting → Export → Reimbursable expenses.
Open Default vendor.
Confirm the default vendor screen loads.
Press Back.
Confirm you return to Reimbursable expenses.
Repeat steps 3–7 from Non-reimbursable expenses and confirm back navigation returns there.

Case 9 : POLICY_ACCOUNTING_SAGE_INTACCT_NON_REIMBURSABLE_CREDIT_CARD_ACCOUNT

Open Expensify.
Open the Sage Intacct–connected workspace.
Go to Accounting → Export → Non-reimbursable expenses.
Open Credit card account.
Confirm the credit card account screen loads.
Press Back.
Confirm you return to Non-reimbursable expenses.

Verify that no errors appear in the JS console

Offline tests

Same as Test Steps

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Same as Test Steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

mweb-chrome-sage-intacct-export-1.mov

iOS: Native

ios-sage-intacct-export-1.mov

iOS: mWeb Safari

mweb-safari-sage-intacct-export-1.mov

MacOS: Chrome / Safari

web-sage-intacct-export-1.mov

codecov · 2026-04-10T04:45:34Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/ROUTES.ts	`17.04% <ø> (+0.07%)`	⬆️
src/SCREENS.ts	`100.00% <ø> (ø)`
src/libs/Navigation/linkingConfig/OldRoutes.ts	`100.00% <ø> (ø)`
...gation/linkingConfig/RELATIONS/WORKSPACE_TO_RHP.ts	`100.00% <ø> (ø)`
src/libs/Navigation/linkingConfig/config.ts	`76.92% <ø> (ø)`
...ntacct/export/DynamicSageIntacctExportDatePage.tsx	`0.00% <ø> (ø)`
...eIntacctNonReimbursableExpensesDestinationPage.tsx	`0.00% <ø> (ø)`
...export/DynamicSageIntacctPreferredExporterPage.tsx	`0.00% <ø> (ø)`
...SageIntacctReimbursableExpensesDestinationPage.tsx	`0.00% <ø> (ø)`
.../DynamicSageIntacctNonReimbursableExpensesPage.tsx	`0.00% <0.00%> (ø)`
... and 3 more
... and 16 files with indirect coverage changes

melvin-bot · 2026-04-10T11:19:38Z

@huult Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mananjadhav · 2026-04-10T11:23:22Z

Issues with my Android emulator. @huult Can you review and help with the QA for Android Native?

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 992d36105b

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-04-10T11:31:43Z

        entryScreens: [SCREENS.WORKSPACE.ACCOUNTING.QUICKBOOKS_ONLINE_EXPORT],
    },
+    POLICY_ACCOUNTING_SAGE_INTACCT_PREFERRED_EXPORTER: {
+        path: 'sage-preferred-exporter',


Keep legacy Sage preferred-exporter route reachable

Changing this suffix from preferred-exporter to sage-preferred-exporter breaks previously issued Sage Intacct export URLs (for example browser history, shared links, or stale backTo links) because the old static Sage route was removed in this commit and there is no compatibility remap in OldRoutes. Users opening the old URL will no longer land on the intended screen, so we should keep an alias/redirect for the legacy path.

Useful? React with 👍 / 👎.

@collectioneur I am getting this conflicts with path name errors. For now I am fixing it with adding prefixes. Let me know if there's any other alternative. I have seen us removing advanced/ etc. prefixes from other PRs.

Found conflicting screens with the same pattern. The pattern 'preferred-exporter' resolves to both 'RightModalNavigator > Settings > Dynamic_Workspace_Accounting_Quickbooks_Online_Export_Preferred_Exporter' and 'RightModalNavigator > Settings > Dynamic_Policy_Accounting_Sage_Intacct_Preferred_Exporter'. Patterns must be unique and cannot resolve to more than one screen.

Yes, this is right approach. We just need to add a mapping from the old route to the new one that you migrated. I'll open a PR today to show exactly how to do this. And from now on, whenever a suffix is renamed, let's make sure to add a redirect so that users with bookmarks or deep links are smoothly redirected to the new, migrated route

chatgpt-codex-connector · 2026-04-10T11:31:43Z

+        path: 'nonreimbursable-expenses',
+        entryScreens: [SCREENS.WORKSPACE.ACCOUNTING.DYNAMIC_SAGE_INTACCT_NON_REIMBURSABLE_EXPENSES],
+    },
+    POLICY_ACCOUNTING_SAGE_INTACCT_REIMBURSABLE_DESTINATION: {
+        path: 'reimbursable-expenses',


Keep legacy Sage destination URLs reachable

Renaming destination suffixes to nonreimbursable-expenses and reimbursable-expenses changes previously valid URLs (.../nonreimbursable/destination and .../reimbursable/destination) without a migration path, so old deep links/history entries now fail to resolve to the destination pages. This is a regression for anyone reopening existing links, and we should preserve backward compatibility with aliases or explicit redirects.

Useful? React with 👍 / 👎.

Same as before.

huult · 2026-04-10T14:22:43Z

@mananjadhav could you review the Codex comment? Thanks!

…ge-export-1

mananjadhav · 2026-04-13T23:05:48Z

@huult The codex comments are about the error we already discussed and also asked for @collectioneur feedback here.

huult · 2026-04-14T02:34:18Z

Thanks, I’ll come back after the comments are resolved.

huult · 2026-04-20T02:59:33Z

@mananjadhav Is this PR ready?

mananjadhav · 2026-04-20T03:01:35Z

Looks like I've got some lint errors. I'll sync main and add the OldRoute mapping. Then it'll be ready.

…ge-export-1

huult · 2026-04-20T03:02:48Z

Okay, let's do it. I’ll review this PR soon

…ge-export-1

mananjadhav · 2026-04-20T17:14:30Z

PR is ready for review.

huult · 2026-04-21T07:54:18Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-04-21.at.14.45.22.mp4

Android: mWeb Chrome

Screen.Recording.2026-04-21.at.14.48.37.mp4

iOS: HybridApp

Screen.Recording.2026-04-21.at.14.51.12.mp4

iOS: mWeb Safari

Screen.Recording.2026-04-21.at.14.52.23.mp4

MacOS: Chrome / Safari

Screen.Recording.2026-04-21.at.14.41.30.mp4

huult

LGTM!

github-actions · 2026-04-21T08:04:25Z

🚧 @mjasikowski has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-04-21T08:09:56Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #87554.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-ae2d424-c079286-ae3585755f701bdb83c37bf9e35da0649551e6bc/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-ae2d424-c079286-0b6a58f71b26f4e9a4d10301ff0c2bafd15dc080/index.html

Web 🕸️
https://87554.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-04-21T08:12:01Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-04-21T11:37:37Z

🚀 Deployed to staging by https://github.com/mjasikowski in version: 9.3.61-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-04-21T11:38:55Z

This PR is a purely internal navigation refactor — it migrates Sage Intacct export route definitions from static routes to dynamic routes (ROUTES.ts, SCREENS.ts, ModalStackNavigators, page components).

No user-facing labels, feature names, settings, or behavior changed. I reviewed the Sage Intacct help site articles under docs/articles/new-expensify/connections/sage-intacct/ and confirmed they describe configuration from a user perspective and are unaffected by internal routing changes.

No help site updates are required for this PR.

izarutskaya · 2026-04-21T12:15:07Z

Hi @mananjadhav @mjasikowski Could you please share steps for QA team? thanks

mananjadhav · 2026-04-21T12:49:45Z

@izarutskaya The QA steps are same as the test steps. I missed adding that comment. Are you able to continue with the test steps now?

Revert "Sage Intacct BT dynamic routes, part 1" (#87554) — fixes #88434

…bt-sage-export-1" This reverts commit ae2d424, reversing changes made to 0d9f70c.

Revert "Sage Intacct BT dynamic routes, part 1" (#87554) — fixes #88434 (cherry picked from commit 8d953c1) (cherry-picked to staging by marcaaron)

mananjadhav added 2 commits April 10, 2026 08:13

feat: move sage intacct to dynamic route

8e4d420

fix: add dynamic prefix to file names

373c4d7

melvin-bot Bot assigned mananjadhav Apr 10, 2026

mananjadhav added 3 commits April 10, 2026 08:39

fix: remove import

f4c3469

refactor: add prefix

123e427

fix: update route

ecf7e12

fix: remove the route

992d361

mananjadhav marked this pull request as ready for review April 10, 2026 11:19

mananjadhav requested review from a team as code owners April 10, 2026 11:19

melvin-bot Bot requested review from heyjennahay and huult April 10, 2026 11:19

melvin-bot Bot removed request for a team April 10, 2026 11:19

chatgpt-codex-connector Bot reviewed Apr 10, 2026

View reviewed changes

huult reviewed Apr 10, 2026

View reviewed changes

Comment thread src/pages/workspace/accounting/intacct/export/DynamicSageIntacctExportDatePage.tsx Outdated

mananjadhav added 2 commits April 14, 2026 04:31

Merge branch 'main' of github.com:mananjadhav/App into mj-83845-bt-sa…

0a34692

…ge-export-1

fix: remove fallback path

8c3e636

Merge branch 'main' of github.com:mananjadhav/App into mj-83845-bt-sa…

9c3b777

…ge-export-1

mananjadhav added 2 commits April 20, 2026 08:52

fix: lint fixes

4998b5f

fix: update old routes

40abcf6

Merge branch 'main' of github.com:mananjadhav/App into mj-83845-bt-sa…

06e2093

…ge-export-1

huult approved these changes Apr 21, 2026

View reviewed changes

melvin-bot Bot requested a review from mjasikowski April 21, 2026 07:56

mjasikowski approved these changes Apr 21, 2026

View reviewed changes

mjasikowski merged commit ae2d424 into Expensify:main Apr 21, 2026
33 checks passed

OSBotify mentioned this pull request Apr 21, 2026

Deploy Checklist: New Expensify 2026-04-21 #88394

Open

neil-marcellini mentioned this pull request Apr 21, 2026

Revert "Sage Intacct BT dynamic routes, part 1" (#87554) — fixes #88434 #88490

Merged

52 tasks

neil-marcellini added a commit that referenced this pull request Apr 21, 2026

Merge pull request #88490 from Expensify/neil/revert-87554-fix-88434

8d953c1

Revert "Sage Intacct BT dynamic routes, part 1" (#87554) — fixes #88434

KioCoan pushed a commit to KioCoan/App that referenced this pull request Apr 21, 2026

Revert "Merge pull request Expensify#87554 from mananjadhav/mj-83845-…

f74be48

…bt-sage-export-1" This reverts commit ae2d424, reversing changes made to 0d9f70c.

Conversation

mananjadhav commented Apr 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Apr 10, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented Apr 10, 2026

Uh oh!

mananjadhav commented Apr 10, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

mananjadhav Apr 13, 2026

Choose a reason for hiding this comment

Uh oh!

collectioneur Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

mananjadhav Apr 13, 2026

Choose a reason for hiding this comment

Uh oh!

huult commented Apr 10, 2026

Uh oh!

Uh oh!

mananjadhav commented Apr 13, 2026

Uh oh!

huult commented Apr 14, 2026

Uh oh!

huult commented Apr 20, 2026

Uh oh!

mananjadhav commented Apr 20, 2026

Uh oh!

huult commented Apr 20, 2026

Uh oh!

mananjadhav commented Apr 20, 2026

Uh oh!

huult commented Apr 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

huult left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Apr 21, 2026

Uh oh!

github-actions Bot commented Apr 21, 2026

Uh oh!

OSBotify commented Apr 21, 2026

Uh oh!

OSBotify commented Apr 21, 2026

Uh oh!

MelvinBot commented Apr 21, 2026

Uh oh!

izarutskaya commented Apr 21, 2026

Uh oh!

mananjadhav commented Apr 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

mananjadhav commented Apr 10, 2026 •

edited

Loading

codecov Bot commented Apr 10, 2026 •

edited by github-actions Bot

Loading

huult commented Apr 21, 2026 •

edited

Loading